[Bug 51452] New: oleaut32:varformat fails in Wine when the currency sign has two characters or more

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51452

Bug ID: 51452
           Summary: oleaut32:varformat fails in Wine when the currency
                    sign has two characters or more
           Product: Wine
           Version: 6.10
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: oleaut32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

oleaut32:varformat fails in Wine when the currency sign has two characters or
more:

https://test.winehq.org/data/patterns.html#oleaut32:varformat

varformat.c:641: str=L"\062f.\0645.\200f 0.000"
varformat.c:643: Test failed: Unexpected hr 0x80020005.

In Morocco the currency sign has 5 characters. This is simply not supported by
VarParseNumFromStr().

But even the currency sign is only two characters VarParseNumFromStr() fails
because it advances a pointer by one character only. For instance with Polish:

varformat.c:641: str=L"0,000 z\0142"
varformat.c:643: Test failed: Unexpected hr 0x80020005.

Note that the w10pro64 TestBot Windows VMs have an incorrect UserDefaultLCID so
that these issues are not actually tested (see bug 51451). The w7u VMs are more
correct in this regard but only test simple European cases (€).

[Bug 51452] oleaut32:varformat fails in Wine when the currency sign has two characters or more

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51452

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]
           Keywords|                            |source, testcase

[Bug 51452] oleaut32:varformat fails in Wine when the currency sign has two characters or more

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51452

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |fc5e603cd3e8ff68e52044e24a1
                   |                            |2e3f19a116afa
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from François Gouget  ---
This is fixed:

commit fc5e603cd3e8ff68e52044e24a12e3f19a116afa
Author: Francois Gouget 
Date:   Sun Aug 8 00:49:01 2021 +0200

oleaut32: Add support for longer currency symbols.

Signed-off-by: Francois Gouget 
    Signed-off-by: Alexandre Julliard

[Bug 51452] oleaut32:varformat fails in Wine when the currency sign has two characters or more

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51452

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Alexandre Julliard  ---
Closing bugs fixed in 6.15.

[Bug 51452] oleaut32:varformat fails in Wine when the currency sign has two characters or more

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51452

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |6.0.x

[Bug 51452] oleaut32:varformat fails in Wine when the currency sign has two characters or more

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51452

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|6.0.x                       |---

--- Comment #3 from Michael Stefaniuc  ---
Removing the 6.0.x milestone from bug fixes included in 6.0.3.