[Bug 12441] New: winecfg: confusing interface for setting per-app overrides

http://bugs.winehq.org/show_bug.cgi?id=12441

Summary: winecfg: confusing interface for setting per-app
                    overrides
           Product: Wine
           Version: CVS/GIT
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: programs
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

winecfg's interface for setting per-app library overrides
screams "obscure!  side-effect!  unclean!"

[Bug 12441] winecfg: confusing interface for setting per-app overrides

http://bugs.winehq.org/show_bug.cgi?id=12441

--- Comment #1 from Dmitry Timoshkov   2008-04-09 01:49:56 ---
My first desire once I saw this report was to close it as invalid, but
when I noticed the reporter I decided to not press 'Commit' :-)

Dan, do you have any constructive criticism or even patches how make it
better?

[Bug 12441] winecfg: confusing interface for setting per-app overrides

http://bugs.winehq.org/show_bug.cgi?id=12441

--- Comment #2 from Dan Kegel   2008-04-09 01:59:31 ---
Thanks, Dmitry :-)

Yes.  The main problem is that the "Libraries" tab
is overloaded.  By default it controls the systemwide
default library overrides, but if you go over to the
Applications tab and add an application, the Libraries
tab magically and silently changes meaning to cover
just overrides of that application.

The quickest fix would be to show the currently selected
application in the Libraries tab as well, I think.

[Bug 12441] winecfg: confusing interface for setting per-app overrides

http://bugs.winehq.org/show_bug.cgi?id=12441

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Jeff Zaroyko   2008-04-09 02:02:19 ---
sounds similar to bug 6233?

[Bug 12441] winecfg: confusing interface for setting per-app overrides

http://bugs.winehq.org/show_bug.cgi?id=12441

--- Comment #4 from Dan Kegel   2008-04-09 02:08:17 ---
Related, yes.  Both the Libraries and the Version info are
global by default, but can be set per-app if you select an
app, and that needs to be clearer in the UI.

[Bug 12441] winecfg: confusing interface for setting per-app overrides

http://bugs.winehq.org/show_bug.cgi?id=12441

--- Comment #5 from Austin English   2008-04-09 02:30:02 ---
Also related, if someone is fixing up winecfg, is that pressing enter when
entering a dll override doesn't add the override. For those of us that neglect
our mice in favor of keyboards, it's quite a pain. I couldn't find a bug report
for this, though I could've sworn I'd seen one before...

[Bug 12441] winecfg: confusing interface for setting per-app overrides

http://bugs.winehq.org/show_bug.cgi?id=12441

--- Comment #6 from Dan Kegel   2008-04-09 02:32:37 ---
Yeah, that gets me every other time I run it...

[Bug 12441] winecfg: confusing interface for setting per-app overrides

http://bugs.winehq.org/show_bug.cgi?id=12441

--- Comment #7 from Austin English   2008-04-25 21:59:23 ---
(In reply to comment #6)
> Yeah, that gets me every other time I run it...

Filed bug 12804 for this.

[Bug 12441] winecfg: confusing interface for setting per-app overrides

http://bugs.winehq.org/show_bug.cgi?id=12441

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Keywords|                            |download, source

[Bug 12441] winecfg: confusing interface for setting per-app overrides

http://bugs.winehq.org/show_bug.cgi?id=12441

nathan.n  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 12441] winecfg: confusing interface for setting per-app overrides

http://bugs.winehq.org/show_bug.cgi?id=12441

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |unspecified

--- Comment #8 from Austin English   2009-01-19 15:14:57 ---
Removing deprecated CVS/GIT version tag. Please retest in current git. If the
bug is still present in today's wine, but was not present in some earlier
version of wine, please update version field to earliest known version of wine
that had the bug. Thanks!

[Bug 12441] winecfg: confusing interface for setting per-app overrides

http://bugs.winehq.org/show_bug.cgi?id=12441

--- Comment #9 from Austin English   2010-07-18 04:38:20 ---
Still present in 1.2.

[Bug 12441] winecfg: confusing interface for setting per-app overrides

http://bugs.winehq.org/show_bug.cgi?id=12441

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from [e-mail] 2012-05-17 15:30:44 CDT ---
This bug has not been updated for two years. Is this still an issue i current
(1.5.4) or newer wine ? You may also close this as abandoned if you feel that
that this is issue is no longer relevant to you.

[Bug 12441] winecfg: confusing interface for setting per-app overrides

http://bugs.winehq.org/show_bug.cgi?id=12441

--- Comment #11 from [e-mail] 2013-04-22 14:48:54 CDT ---
This bug has not been updated for three years. Is this still an issue i current
(1.5.28) or newer wine ? You may also close this as abandoned if you feel that
that this is issue is no longer relevant to you.

[Bug 12441] winecfg: confusing interface for setting per-app overrides

http://bugs.winehq.org/show_bug.cgi?id=12441

--- Comment #12 from Austin English  2013-04-23 00:54:07 CDT ---
(In reply to comment #11)
> This bug has not been updated for three years. Is this still an issue i current
> (1.5.28) or newer wine ? You may also close this as abandoned if you feel that
> that this is issue is no longer relevant to you.

Yes, it is still present.

[Bug 12441] winecfg: confusing interface for setting per-app overrides

http://bugs.winehq.org/show_bug.cgi?id=12441

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           See Also|                            |http://bugs.winehq.org/show
                   |                            |_bug.cgi?id=6233

[Bug 12441] winecfg: confusing interface for setting per-app overrides

https://bugs.winehq.org/show_bug.cgi?id=12441

Dmirty Kozliuk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from Dmirty Kozliuk  ---
Created attachment 50204
  --> https://bugs.winehq.org/attachment.cgi?id=50204
Implementation as of 2014-12-13

Changed UI so that applications are listed on the left while tabbed settings
reside on the right. The only setting which remains in "Applications" tab is
Windows version, so I renamed the tab to "Compatibility" (similar to the one in
Windows Explorer shortcut properties dialog). To reduce confusion, window title
is set to "Wine Configuraton for <app>" only for "Compatibility", "Libraries",
and "Graphics" tab.

Note: 
  While working on this patch, I noted bug #37713 (window title reset when
removing application from list). Fix for that bug is not included in this patch
intentionally.

User caveats:
  * TAB key cannot be used to switch between application list and tabbed
settings (see the reason below). The user has to use mouse at least once.
  * Even when switched to the tab without application-specific settings,
application remains selected in the list. However, window title is correct.

Developer notes:
  Previously, main window was created by system when the property sheet with
settings tabs was displayed. Now main window is a dialog box containing to
top-level components: a child dialog (control group) with application list
controls and the old property sheet dialog as a child. This is not the most
elegant solution, but it is legitimate and keeps the changes minimal. There is
an (old) comment in the code that property sheet should be replaced by tab
control---I think it's time to do so. It will give developers much control and
flexibility when implementing other UI features. However, it will definitely
constitute a separate set of changes.

[Bug 12441] winecfg: confusing interface for setting per-app overrides

https://bugs.winehq.org/show_bug.cgi?id=12441

--- Comment #14 from Austin English  ---
Hi Dmirty,

Thanks for working on this. Note that patches aren't picked up from bugzilla,
they should be sent to [e-mail]. See
http://wiki.winehq.org/SubmittingPatches

[Bug 12441] winecfg: confusing interface for setting per-app overrides

https://bugs.winehq.org/show_bug.cgi?id=12441

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #15 from [e-mail] ---
The patch against

wine 2.0-git.

patching file programs/winecfg/about.c
patching file programs/winecfg/appdefaults.c
Hunk #1 succeeded at 34 (offset -1 lines).
Hunk #5 succeeded at 394 with fuzz 1.
patching file programs/winecfg/audio.c
Hunk #1 succeeded at 545 (offset 191 lines).
Hunk #2 FAILED at 367.
1 out of 2 hunks FAILED -- saving rejects to file programs/winecfg/audio.c.rej
patching file programs/winecfg/driveui.c
patching file programs/winecfg/libraries.c
Hunk #1 succeeded at 540 (offset 6 lines).
Hunk #2 succeeded at 601 (offset 6 lines).
patching file programs/winecfg/main.c
Hunk #1 succeeded at 34 (offset -2 lines).
Hunk #2 succeeded at 65 (offset -2 lines).
Hunk #3 succeeded at 98 (offset -2 lines).
Hunk #4 succeeded at 161 (offset -2 lines).
Hunk #5 succeeded at 192 (offset -2 lines).
Hunk #6 succeeded at 204 (offset -2 lines).
Hunk #7 succeeded at 379 (offset -2 lines).
patching file programs/winecfg/resource.h
patching file programs/winecfg/theme.c
Hunk #1 succeeded at 1193 (offset 66 lines).
Hunk #2 succeeded at 1332 (offset 75 lines).
Hunk #3 succeeded at 1343 (offset 75 lines).
patching file programs/winecfg/winecfg.c
patching file programs/winecfg/winecfg.h
patching file programs/winecfg/winecfg.rc
Hunk #2 succeeded at 129 (offset 6 lines).
Hunk #3 FAILED at 162.
1 out of 3 hunks FAILED -- saving rejects to file
programs/winecfg/winecfg.rc.rej
patching file programs/winecfg/x11drvdlg.c
Hunk #1 succeeded at 343 (offset -7 lines).
Hunk #2 succeeded at 409 (offset -7 lines).