[Bug 25749] New: TortoiseSVN fails after successful commit

http://bugs.winehq.org/show_bug.cgi?id=25749

Summary: TortoiseSVN fails after successful commit
           Product: Wine
           Version: 1.3.11
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=32800)
 --> (http://bugs.winehq.org/attachment.cgi?id=32800)
TortoiseSVN log for commit operation

TortoiseSVN fails after successful commit for wine 1.3.*. In wine 1.2.* all
works perfectly.

[Bug 25749] TortoiseSVN fails after successful commit

http://bugs.winehq.org/show_bug.cgi?id=25749

--- Comment #1 from Austin English  2011-01-10 14:19:39 CST ---
Please run a regression test:
http://wiki.winehq.org/RegressionTesting

[Bug 25749] TortoiseSVN fails after successful commit

http://bugs.winehq.org/show_bug.cgi?id=25749

--- Comment #2 from Andrey Niakhaichyk  2011-01-11 11:03:51 CST ---
(In reply to comment #1)
> Please run a regression test:
> http://wiki.winehq.org/RegressionTesting

6d1ef3a6a64f0fabf05ce1bba5f0ec4373684786 is the first bad commit
commit 6d1ef3a6a64f0fabf05ce1bba5f0ec4373684786
Author: Huw Davies 
Date:   Thu Jul 22 13:37:19 2010 +0100

ole32: Implement cross-process drag and drop.

:040000 040000 ab88cc6bf0936bc4adc7bff0673415282613d919
065c727204a46d01708bc01f10484cad8527e1a2 M      dlls

[Bug 25749] TortoiseSVN fails after successful commit

http://bugs.winehq.org/show_bug.cgi?id=25749

Andrey Niakhaichyk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 25749] TortoiseSVN fails after successful commit

http://bugs.winehq.org/show_bug.cgi?id=25749

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 25749] TortoiseSVN fails after successful commit

http://bugs.winehq.org/show_bug.cgi?id=25749

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Jerome Leclanche  2011-04-20 18:26:45 CDT ---
Is this still an issue with wine-1.3.18?

+source

[Bug 25749] TortoiseSVN fails after successful commit

http://bugs.winehq.org/show_bug.cgi?id=25749

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source

[Bug 25749] TortoiseSVN fails after successful commit

http://bugs.winehq.org/show_bug.cgi?id=25749

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://downloads.sourceforg
                   |                            |e.net/tortoisesvn/TortoiseS
                   |                            |VN-1.6.15.21042-win32-svn-1
                   |                            |.6.16.msi?download
          Component|-unknown                    |ole32

--- Comment #4 from Ken Sharp  2011-04-20 19:28:42 CDT ---
A log with debug symbols might help.

[Bug 25749] TortoiseSVN fails after successful commit

http://bugs.winehq.org/show_bug.cgi?id=25749

--- Comment #5 from Andrey Niakhaichyk  2011-04-22 08:45:20 CDT ---
(In reply to comment #3)
> Is this still an issue with wine-1.3.18?

I've just tried it for wine-1.3.18 tag. Yes, still.
> +source

What do you mean?

[Bug 25749] TortoiseSVN fails after successful commit

http://bugs.winehq.org/show_bug.cgi?id=25749

--- Comment #6 from Andrey Niakhaichyk  2011-04-22 08:47:22 CDT ---
(In reply to comment #4)
> A log with debug symbols might help.

How to make it?

[Bug 25749] TortoiseSVN fails after successful commit

http://bugs.winehq.org/show_bug.cgi?id=25749

--- Comment #7 from Jerome Leclanche  2011-04-22 08:51:30 CDT ---
(In reply to comment #6)
> (In reply to comment #4)
> > A log with debug symbols might help.
>
> How to make it?

http://wiki.winehq.org/FAQ#head-a37de3282d447376d2220d20a278ae52258551a4

(In reply to comment #5)
> > +source
>
> What do you mean?

Nothing important now.

[Bug 25749] TortoiseSVN fails after successful commit

http://bugs.winehq.org/show_bug.cgi?id=25749

--- Comment #8 from Andrey Niakhaichyk  2011-04-22 09:05:01 CDT ---
Created an attachment (id=34285)
 --> (http://bugs.winehq.org/attachment.cgi?id=34285)
TortoiseSVN log for commit operation

[Bug 25749] TortoiseSVN fails after successful commit

http://bugs.winehq.org/show_bug.cgi?id=25749

--- Comment #9 from Andrey Niakhaichyk  2011-04-22 09:25:44 CDT ---
> > > A log with debug symbols might help.
> >
> > How to make it?
>
> http://wiki.winehq.org/FAQ#head-a37de3282d447376d2220d20a278ae52258551a4

http://holey.org/log-verbose20110422.zip

[Bug 25749] TortoiseSVN fails after successful commit

http://bugs.winehq.org/show_bug.cgi?id=25749

Andrey Niakhaichyk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.3.11                      |1.3.18

[Bug 25749] TortoiseSVN fails after successful commit

http://bugs.winehq.org/show_bug.cgi?id=25749

Andrey Niakhaichyk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32800|0                           |1
        is obsolete|                            |

[Bug 25749] TortoiseSVN fails after successful commit

http://bugs.winehq.org/show_bug.cgi?id=25749

Andrey Niakhaichyk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34285|0                           |1
        is obsolete|                            |

--- Comment #10 from Andrey Niakhaichyk  2011-04-22 09:28:20 CDT ---
Created an attachment (id=34286)
 --> (http://bugs.winehq.org/attachment.cgi?id=34286)
TortoiseSVN log for commit operation

[Bug 25749] TortoiseSVN fails after successful commit

http://bugs.winehq.org/show_bug.cgi?id=25749

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.3.18                      |1.3.11

--- Comment #11 from Dmitry Timoshkov  2011-04-22 23:46:31 CDT ---
Please do not change an originally reported Wine version.

[Bug 25749] TortoiseSVN (TortoiseProc.exe) crashes upon exit (OLE teardown)

http://bugs.winehq.org/show_bug.cgi?id=25749

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
            Summary|TortoiseSVN fails after     |TortoiseSVN
                   |successful commit           |(TortoiseProc.exe) crashes
                   |                            |upon exit (OLE teardown)
     Ever Confirmed|0                           |1

--- Comment #12 from Anastasius Focht  2011-04-26 11:41:22 CDT ---
Hello,

confirming, crashes on exit.
This issue does not only apply to commits, you can also reproduce with other
commands.

Fun fact: it seems using builtin msvcr90 prevents the crash at the end.
This is most likely due to some stuff not really implemented/stubbed...

WINEDLLOVERRIDES="msvcr90=b" wine "C:\Program
Files\TortoiseSVN\bin\TortoiseProc.exe" /command:commit .

Crash:

WINEDLLOVERRIDES="msvcr90=n" wine "C:\Program
Files\TortoiseSVN\bin\TortoiseProc.exe" /command:commit .

The code where the crash occurs is most likely the following
(CrashRpt.UninstallEx -> in CCrashHandler destructor):

https://tortoisesvn.googlecode.com/svn/trunk/src/crashrpt/CrashHandler.cpp

The crash is triggered in ole32.CoUninitialize() teardown.

There are at least 6 open bugs when searching for that offending "cross process
drap & drop" commit:

http://bugs.winehq.org/buglist.cgi?query_format=advanced&bug_status=UNCO...

--- snip ---
0009:Call ole32.RegisterDragDrop(00010086,00ee28b0) ret=00e8c817 
...
0009:Ret  ole32.RegisterDragDrop() retval=00000000 ret=00e8c817
...
0009:Call ole32.RegisterDragDrop(00010088,00bf53a8) ret=00460ac9 
...
0009:Ret  ole32.RegisterDragDrop() retval=00000000 ret=00460ac9
...
0009:Call ole32.RevokeDragDrop(00010086) ret=00e8c06a
...
0009:Ret  ole32.RevokeDragDrop() retval=00000000 ret=00e8c06a
0009:Call ole32.OleUninitialize() ret=00e8f051
0009:Ret  ole32.OleUninitialize() retval=00000000 ret=00e8f051 
...
0009:CALL CrashRpt.UninstallEx(<unknown, check return>) ret=0070e389 
...
0009:Call ole32.CoUninitialize() ret=02001459 
...
*boom*
--- snip ---

Revoke is only called for one window before OLE is teared down finally.

Reverting back to old behavior in RegisterDragDrop() and RevokeDragDrop()
prevents the crash.
Other bugs might be dupes of each other.

Regards

[Bug 25749] TortoiseSVN (TortoiseProc.exe) crashes upon exit (OLE teardown)

http://bugs.winehq.org/show_bug.cgi?id=25749

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |DUPLICATE

--- Comment #13 from Anastasius Focht  2011-04-29 03:55:41 CDT ---
Hello,

making this bug a dupe of bug 23861 (some analysis in there).

Regards

*** This bug has been marked as a duplicate of bug 23861 ***

[Bug 25749] TortoiseSVN (TortoiseProc.exe) crashes upon exit (OLE teardown)

http://bugs.winehq.org/show_bug.cgi?id=25749

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #14 from Nikolay Sivov  2011-04-30 01:27:21 CDT ---
Closing.

[Bug 25749] TortoiseSVN (TortoiseProc.exe) crashes upon exit (OLE teardown)

http://bugs.winehq.org/show_bug.cgi?id=25749

--- Comment #15 from Andrey Niakhaichyk  2011-06-30 04:25:14 CDT ---
Created an attachment (id=35372)
 --> (http://bugs.winehq.org/attachment.cgi?id=35372)
TortoiseSVN standart log for commit operation

for 1.3.23

[Bug 25749] TortoiseSVN (TortoiseProc.exe) crashes upon exit (OLE teardown)

http://bugs.winehq.org/show_bug.cgi?id=25749

Andrey Niakhaichyk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35372|TortoiseSVN standart log    |TortoiseSVN standard log
        description|for commit operation        |for commit operation

[Bug 25749] TortoiseSVN (TortoiseProc.exe) crashes upon exit (OLE teardown)

http://bugs.winehq.org/show_bug.cgi?id=25749

Andrey Niakhaichyk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |REOPENED
         Resolution|DUPLICATE                   |

--- Comment #16 from Andrey Niakhaichyk  2011-06-30 04:31:35 CDT ---
It has not been fixed after closing bug 23861. I've tested with 1.3.23.

See short attachment:
http://bugs2.winehq.org/attachment.cgi?id=35372
and full one:
http://holey.org/log-verbose20110630.zip

Thanks.

[Bug 25749] TortoiseSVN (TortoiseProc.exe) crashes upon exit (OLE teardown)

http://bugs.winehq.org/show_bug.cgi?id=25749

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |6d1ef3a6a64f0fabf05ce1bba5f
                   |                            |0ec4373684786

[Bug 25749] TortoiseSVN (TortoiseProc.exe) crashes upon exit (OLE teardown)

http://bugs.winehq.org/show_bug.cgi?id=25749

--- Comment #17 from Huw Davies  2011-10-03 11:31:08 CDT ---
Could you use an unstripped build of wine and post the backtrace again?

[Bug 25749] TortoiseSVN (TortoiseProc.exe) crashes upon exit (OLE teardown)

http://bugs.winehq.org/show_bug.cgi?id=25749

--- Comment #18 from Andrey Niakhaichyk  2011-10-03 21:56:20 CDT ---
Where I can get it? Or how to create it?

[Bug 25749] TortoiseSVN (TortoiseProc.exe) crashes upon exit (OLE teardown)

http://bugs.winehq.org/show_bug.cgi?id=25749

--- Comment #19 from Austin English  2011-10-04 01:54:05 CDT ---
(In reply to comment #18)
> Where I can get it? Or how to create it?

Install wine-dbg package if available or compile wine manually.

[Bug 25749] TortoiseSVN (TortoiseProc.exe) crashes upon exit (OLE teardown)

http://bugs.winehq.org/show_bug.cgi?id=25749

--- Comment #20 from Andrey Niakhaichyk  2011-10-12 20:33:50 CDT ---
> Install wine-dbg package if available or compile wine manually.

http://holey.org/log-verbose20111012.zip

[Bug 25749] TortoiseSVN (TortoiseProc.exe) crashes upon exit (OLE teardown)

http://bugs.winehq.org/show_bug.cgi?id=25749

--- Comment #21 from Huw Davies  2011-10-13 04:10:04 CDT ---
Could you post a +relay,+seh,+tid,+ole,+rpc log of this?

Thanks!

[Bug 25749] TortoiseSVN (TortoiseProc.exe) crashes upon exit (OLE teardown)

http://bugs.winehq.org/show_bug.cgi?id=25749

--- Comment #22 from Andrey Niakhaichyk  2011-10-13 13:52:49 CDT ---
> Could you post a +relay,+seh,+tid,+ole,+rpc log of this?

You are welcome: http://holey.org/log-verbose20111013.zip

[Bug 25749] TortoiseSVN (TortoiseProc.exe) crashes upon exit (OLE teardown)

http://bugs.winehq.org/show_bug.cgi?id=25749

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |5c8edb0449f6c261b9d7d175601
                   |                            |1a08decd4c081
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #23 from Austin English  2012-02-07 18:58:33 CST ---
Fixed by
http://source.winehq.org/git/wine.git/commitdiff/5c8edb0449f6c261b9d7d175601...

used TortoiseMerge.exe to test.

[Bug 25749] TortoiseSVN (TortoiseProc.exe) crashes upon exit (OLE teardown)

http://bugs.winehq.org/show_bug.cgi?id=25749

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #24 from Alexandre Julliard  2012-02-11 13:53:15 CST ---
Closing bugs fixed in 1.4-rc3.

[Bug 25749] TortoiseSVN (TortoiseProc.exe) crashes upon exit (OLE teardown)

http://bugs.winehq.org/show_bug.cgi?id=25749

--- Comment #25 from Andrey Niakhaichyk  2012-02-20 06:58:13 CST ---
Confirming

[Bug 25749] TortoiseSVN (TortoiseProc.exe) crashes upon exit (OLE teardown)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=25749

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://downloads.sourceforg |https://web.archive.org/web
                   |e.net/tortoisesvn/TortoiseS |/20220108123405/https://mas
                   |VN-1.6.15.21042-win32-svn-1 |ter.dl.sourceforge.net/proj
                   |.6.16.msi?download          |ect/tortoisesvn/OldFiles/1.
                   |                            |6.15/Application/TortoiseSV
                   |                            |N-1.6.15.21042-win32-svn-1.
                   |                            |6.16.msi?viasf=1

--- Comment #26 from Anastasius Focht  ---
Hello folks,

adding stable download link via Internet Archive for documentation.

https://web.archive.org/web/20220108123405/https://master.dl.sourceforge.net...

https://www.virustotal.com/gui/file/0b97b7c4f1b8d487b6affd8462f44a18aa8cb0e4...

$ sha1sum TortoiseSVN-1.6.15.21042-win32-svn-1.6.16.msi
155bcefb2a081a9fc2a6ff818e516edd5737507e 
TortoiseSVN-1.6.15.21042-win32-svn-1.6.16.msi

$ du -sh TortoiseSVN-1.6.15.21042-win32-svn-1.6.16.msi
20M    TortoiseSVN-1.6.15.21042-win32-svn-1.6.16.msi

Regards