[Bug 38409] New: Wine Task Tray does is not in the taskbar KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

Bug ID: 38409
           Summary: Wine Task Tray does is not in the taskbar KDE 5
           Product: Wine
           Version: 1.7.40
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

The wine System Tray is not linked to the KDE desktop at all in KDE 5 but it
worked fine in KDE 4.

[Bug 38409] Wine Task Tray does is not in the taskbar KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

Ferry Toth  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Ferry Toth  ---
Yes, I confirm this. Am I missing a library? I am using a.NET program that
paces an icon in the tray.

What does wine use to tray icons?

[Bug 38409] Wine Task Tray does is not in the taskbar KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from joaopa  ---
I confirm the problem too.

[Bug 38409] Wine Task Tray does is not in the taskbar KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

sl1pkn07  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from sl1pkn07  ---
same here in plasma-desktop 5.3.0

[Bug 38409] Wine Task Tray does is not in the taskbar KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Alexandre Julliard  ---
*** Bug 38579 has been marked as a duplicate of this bug. ***

[Bug 38409] Wine Task Tray does is not in the taskbar KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #5 from Alexandre Julliard  ---
Support for XEmbed system tray has been removed in KDE 5.

[Bug 38409] Wine Task Tray does is not in the taskbar KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #6 from Jack Greiner  ---
(In reply to Alexandre Julliard from comment #5)
> Support for XEmbed system tray has been removed in KDE 5.

Will there be a fix? Or will this need to be manually patched.

[Bug 38409] Wine Task Tray does is not in the taskbar KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #7 from Ker noa  ---
http://blog.martin-graesslin.com/blog/2014/03/system-tray-in-plasma-next/

Looks like there is a replacement

http://api.kde.org/frameworks-api/frameworks5-apidocs/knotifications/html/cl...

[Bug 38409] Wine Task Tray does is not in the taskbar KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #8 from Alexandre Julliard  ---
Yeah, it will need to be reimplemented using the dbus stuff, though it's not
clear how far this can be made compatible with what Windows apps expect.

[Bug 38409] Wine Task Tray does is not in the taskbar KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Alexandre Julliard  ---
*** Bug 38606 has been marked as a duplicate of this bug. ***

[Bug 38409] Wine Task Tray does is not in the taskbar KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

Lukas Jirkovsky  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38409] Wine Task Tray does is not in the taskbar KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

Fabio Correa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38409] Wine Task Tray does is not in the taskbar KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

Yuriy Kolesnikov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38409] Wine Task Tray does is not in the taskbar KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

karaluh  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38409] Wine Task Tray does is not in the taskbar KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

Andrei Slăvoiu  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38409] Wine Task Tray does is not in the taskbar KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

Qian Hong  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38409] Wine Task Tray does is not in the taskbar KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

darkbasic  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38409] Wine Task Tray does is not in the taskbar KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #10 from Yuriy Kolesnikov  ---
Please fix a typo in bug title.(In reply to Ferry Toth from comment #1)
> Yes, I confirm this. Am I missing a library? I am using a.NET program that
> paces an icon in the tray.
>
> What does wine use to tray icons?

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Wine Task Tray does is not  |Wine's task tray is not
                   |in the taskbar KDE 5        |shown in the taskbar in KDE
                   |                            |5

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

lizhenbo  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

nucleo  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #11 from Nikolay Sivov  ---
Looks like it's back in a form of additional program/plugin -
https://github.com/davidedmundson/xembed-sni-proxy. Some developer notes are
also here http://blog.davidedmundson.co.uk/blog/xembed_back (interesting blog
engine that doesn't display posting timestamp). As far as I can tell the idea
is to merge this directly into Plasma 5.5 so users don't have to bother
installing this bridge separately. And of course I have no idea how well it
works for Wine or if it works at all at the moment.

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #12 from Robert Munteanu  ---
(In reply to comment #11)
> Looks like it's back in a form of additional program/plugin -
> https://github.com/davidedmundson/xembed-sni-proxy. Some developer notes are
> also here http://blog.davidedmundson.co.uk/blog/xembed_back (interesting blog
> engine that doesn't display posting timestamp). As far as I can tell the idea is
> to merge this directly into Plasma 5.5 so users don't have to bother installing
> this bridge separately. And of course I have no idea how well it works for Wine
> or if it works at all at the moment.

It does work in wine, with some limitations

- icons look jagged, possibly due to scaling
- sometimes icon are corrupted ( black background )
- icons don't appear when the program starts, the bar is empty , but when
clicking the empty space they appear

These are probably bugs of xembed-sni-proxy, not of wine.

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

Jagadguru  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

Alexey Min  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from Alexey Min  ---
(In reply to Robert Munteanu from comment #12)
> It does work in wine, with some limitations
> - icons look jagged, possibly due to scaling
> - sometimes icon are corrupted ( black background )
> - icons don't appear when the program starts, the bar is empty , but when
>
> clicking the empty space they appear
>
> These are probably bugs of xembed-sni-proxy, not of wine.

Yep, these are bugs of xembed-sni-proxy, caused by limitations of proxying
embedded windows screenshots, mouse clicks, etc. It is a dirty hack by nature,
you can tweak it do display some icons correctly, but other icons will look
bad; the correct solution will be for wine to implement
http://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/ anyway ;)

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #14 from Alexey Min  ---
Created attachment 52966
  --> https://bugs.winehq.org/attachment.cgi?id=52966
Huge patch adding StatusNotifierItem support

Patched dlls/winex11.drv/systray.c @ wine_notify_icon() using raw libdbus to
implement basic StatusNotifierItem support for tray icon operations, usually
invoked by Shell_NotifyIcon().

What works:
 * tray icon
 * tooltip text
 * mouse clicks and double clicks on tray icon

What is currently not done, but possible:
 * tray balloon popup message

What is not possible:
 * mouse move event from tray (WM_MOUSEMOVE)

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #15 from Alexey Min  ---
now it "worksforme" :D http://i.imgur.com/qlCtvAn.jpg

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #16 from Yuriy Kolesnikov  ---
Please submit it to staging

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #17 from sl1pkn07  ---
Hi

Tested with Share (https://appdb.winehq.org/appview.php?iVersionId=6699) the
icon is empty, but can show the tooltips and interact with it

without patch, the icon is show in a separate window (with working tooltips)

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #18 from Alexey Min  ---
(In reply to sl1pkn07 from comment #17)
> Tested with Share (https://appdb.winehq.org/appview.php?iVersionId=6699) the
> icon is empty

Probably some unexpected icon format. Can you try to run it with
WINEDEBUG=+systray and look for messages like

trace: assign_tray_icon_data: Saved icon bitmap, %u bytes

above it will info about image format

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #19 from sl1pkn07  ---
this?

trace:systray:is_statusnotifier_host_running DBus: detected that
org.kde.StatusNotifierWatcher present, will ask him about StatusNotifierHost!
trace:systray:is_statusnotifier_host_running DBus: OK: Got prop.get reply,
IsStatusNotifierHostRegistered = 1
trace:systray:can_use_dbus_sni_systray DBus: detected that we can use DBus
systray instead of XEmbed
trace:systray:add_sni_icon id=0x1, hwnd=0x1010a
trace:systray:assign_tray_icon_data fIcon = 1, (hotspot 16, 16) mask = 0x1003d,
color = 0x1003c
trace:systray:assign_tray_icon_data System icon size: 32 x 32
trace:systray:assign_tray_icon_data Got color bitmap: bmType = 0
trace:systray:assign_tray_icon_data                   size = 32 x 32
trace:systray:assign_tray_icon_data                   scanline bytes = 128
trace:systray:assign_tray_icon_data                   color planes = 1
trace:systray:assign_tray_icon_data                   bits per pixel = 32
trace:systray:assign_tray_icon_data                   bits pointer = 0x580000
trace:systray:assign_tray_icon_data Saved icon bitmap, 4096 bytes
trace:systray:start_dbus_thread started dbus_thread
trace:systray:add_sni_icon Requesting name [org.kde.StatusNotifierItem-39-1]...
trace:systray:add_sni_icon Request name [org.kde.StatusNotifierItem-39-1] OK!
trace:systray:add_sni_icon Using [wine] as application name
trace:systray:root_message_handler DBus: message for path
[/org/freedesktop/DBus] dest [:1.5318], intf
[org.freedesktop.DBus].[NameAcquired]
trace:systray:root_message_handler DBus: message for path [/StatusNotifierItem]
dest [org.kde.StatusNotifierItem-39-1], intf
[org.freedesktop.DBus.Properties].[GetAll]
trace:systray:root_message_handler DBus: Properties.GetAll(
"org.kde.StatusNotifierItem" )
trace:systray:root_message_handler Propgetall reply for icon
org.kde.StatusNotifierItem-39-1
trace:systray:Shell_NotifyIconW dwMessage = 1, nid->cbSize=936
trace:systray:modify_sni_icon id=0x1, hwnd=0x1010a
trace:systray:root_message_handler DBus: message for path [/StatusNotifierItem]
dest [org.kde.StatusNotifierItem-39-1], intf
[org.freedesktop.DBus.Properties].[GetAll]
trace:systray:root_message_handler DBus: Properties.GetAll(
"org.kde.StatusNotifierItem" )
trace:systray:root_message_handler Propgetall reply for icon
org.kde.StatusNotifierItem-39-1

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

Fabio Correa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]         |

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #20 from Alexey Min  ---
(In reply to sl1pkn07 from comment #19)
> this?

Thank you for testing! I think I've found the problem, the icon was empty (full
transparent) because of alpha channel. Should it look like this?
http://i.imgur.com/P2NyN2E.png

(In reply to Yuriy Kolesnikov from comment #16)
> Please submit it to staging

I'm working on splitting it into series of smaller patches, and once I think
it's ready I definitely will :)

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #21 from sl1pkn07  ---
yes, that's the icon

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

Thomas Kowaliczek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

Reuben  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #22 from sl1pkn07  ---
Happy new year. Any notice of this bug?

Greetings

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #23 from Robert Munteanu  ---
This works out of the box ( although icons are still a bit blurry ) with KDE
5.5 or newer. See 'Restored Legacy Icons in System Tray Support' in
https://dot.kde.org/2015/12/08/plasma-55-beautiful-new-artwork .

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #24 from sl1pkn07  ---
Out of the box like the patch provided by Alexey Min, or with use old behavior?

this is a sustancial change I want to use, the alexey min patch have better
integration (Light years) than the older integration

Alexey Min, you can share you patch with the update for fix the alpha channel
(the problem with Share.exe systray icon)

greetings

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #25 from Robert Munteanu  ---
This works without any patches to wine, wine 1.8

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #26 from sl1pkn07  ---
with use old behavior? (xembed) or use a native plasma5 (StatusNotifierItem)

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #27 from Bruno Jesus  ---
(In reply to Robert Munteanu from comment #25)
> This works without any patches to wine, wine 1.8

Upstream fixed bug then?

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #28 from sl1pkn07  ---
for me absolutely not. upstream only make a workground.

the best fix is implement StatusNotifierItem system like Alexey Min patch does

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #29 from Alexey Min  ---
Yep, plasma-5.5 has received a new feature called xembedsniproxy (
http://blog.davidedmundson.co.uk/blog/xembed_back ) but it is not perfect, see
https://bugs.kde.org/show_bug.cgi?id=355684 or similar. Also read comments in
code, for example in commit:
https://quickgit.kde.org/?p=plasma-workspace.git&a=commitdiff&h=41df...
especially one saying "a workaround for X11 bug: xembed icon may suddenly
become transparent for a one or few frames." (which has no reliable workaround,
AFAIK). There is also an interesting hack in that commit, to detect presence or
absence of alpha channel, I guess I'll have to do similar thing. It's just new
year holidays last for too long.

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #30 from [e-mail] ---
Any news on this?

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

karaluh  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]          |

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #31 from joaopa  ---
I do not know wether it was fixed in wine or in KDE, but anyway it is fixed for
kubuntu 16.04 and wine 1.9.12

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #32 from Ker noa  ---
That is the workaround mentioned above. 16.04 ships Plasma 5.5.5.

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #33 from sl1pkn07  ---
I'm still waiting

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever confirmed|0                           |1

--- Comment #34 from Frédéric Delanoy  ---
Marking NEW as per multiple confirmations

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #35 from sl1pkn07  ---
Any update about this? Alexey Min

Greetings

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #36 from sl1pkn07  ---
Alexey Min, you version can't apply into wine-1.9.21

can you fix it?

greetings

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #37 from [e-mail] ---
Could you rebase the patch?

patching file dlls/winex11.drv/Makefile.in
patching file dlls/winex11.drv/systray.c
Hunk #1 FAILED at 44.
Hunk #2 succeeded at 89 (offset 1 line).
Hunk #3 succeeded at 848 with fuzz 2 (offset 26 lines).
1 out of 3 hunks FAILED -- saving rejects to file
dlls/winex11.drv/systray.c.rej
patching file dlls/winex11.drv/systray.h
patching file dlls/winex11.drv/systray_dbus.c

against wine 2.0rc5.

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

Richard H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #38 from Alexandre Julliard  ---
*** Bug 42515 has been marked as a duplicate of this bug. ***

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

Robert Walker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

Joerg Schiermeier  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #39 from Joerg Schiermeier  ---
Still available in wine-2.14 on  KDE Frameworks 5.28.0.

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #40 from sl1pkn07  ---
i'm still waiting Alexey Min's update patch

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #41 from Gijs Vermeulen  ---
Created attachment 59016
  --> https://bugs.winehq.org/attachment.cgi?id=59016
Rebased patch by Alexey Min

Here is a rebased version of Alexey Min's patch. I do not take any credit for
the actual patch, I only rebased it to apply to current git.

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #42 from sl1pkn07  ---
Thanks for the patch

but fail in build:

gcc -m64 -c -o mci.o ../../../wine/dlls/winmm/mci.c -I.
-I../../../wine/dlls/winmm -I../../include \
  -I../../../wine/include -D__WINESRC__ -D_WINMM_ -D_REENTRANT -fPIC -Wall
-pipe \
  -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body
-Wignored-qualifiers \
  -Wshift-overflow=2 -Wstrict-prototypes -Wtype-limits
-Wunused-but-set-parameter -Wvla \
  -Wwrite-strings -Wpointer-arith -Wlogical-op -D_FORTIFY_SOURCE=2
-march=native -O2 -pipe -fstack-protector-strong -fno-plt -U_FORTIFY_SOURCE
-D_FORTIFY_SOURCE=0
../../../wine/dlls/winex11.drv/systray.c: In function 'notify_owner':
../../../wine/dlls/winex11.drv/systray.c:422:13: error: 'struct tray_icon' has
no member named 'version'
     if (icon->version >= NOTIFY_VERSION_4)
             ^~
../../../wine/dlls/winex11.drv/systray.c: In function 'tray_icon_wndproc':
../../../wine/dlls/winex11.drv/systray.c:493:17: error: 'struct tray_icon' has
no member named 'version'
         if (icon->version > 0) notify_owner( icon, NIN_SELECT, lparam );
                 ^~
../../../wine/dlls/winex11.drv/systray.c:498:17: error: 'struct tray_icon' has
no member named 'version'
         if (icon->version > 0) notify_owner( icon, WM_CONTEXTMENU, lparam );
                 ^~
../../../wine/dlls/winex11.drv/systray.c: In function 'wine_notify_icon':
../../../wine/dlls/winex11.drv/systray.c:865:17: error: 'struct tray_icon' has
no member named 'version'
             icon->version = data->u.uVersion;
                 ^~
make[1]: *** [Makefile:490: systray.o] Error 1

greetings

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

Josh  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                   |                            |ace.de

--- Comment #43 from Josh  ---
Any news on this? Is there something I can do to help with my limited skills
such as testing a patch, etc.?

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #44 from Robert Walker  ---
(In reply to Josh from comment #43)
> Any news on this? Is there something I can do to help with my limited skills
> such as testing a patch, etc.?

I'm very far from an expert on dbus... But I tried testing a rebased version of
the original patch against Wine 3.2... Testing with the Valve Steam Client -
since this application is badly affected by this bug.

This led to Steam correctly registering a tray icon with the Plasma 5 Desktop
system tray. Then whenever there is an attempt to interact with that tray icon
- the dbus link is severed. For example the registered tray item disappears
from the qtdbus (dbus introspection) viewer.
In addition the Steam icon disappears from the system tray.

The RHS mouse click context menu might show / work once.
Watching dbus messages shows nothing enlightening either.

This is bug is quite significant in that Valve Steam Client can ONLY minimise
to a system tray (not to a Desktop taskbar / panel). The only way to restore
the Steam Client is to interact with the tray icon. The Valve Steam Client has
NO option available (or even a hidden setting) to disable minimising to the
system tray.

On Plasma 5 (with legacy system tray support) the system tray icon, with
vanilla Wine, does nothing (no context menus, etc.) So Steam cannot be restored
from a minimised state - when not run in a Wine Virtual Desktop. Far from
ideal!

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #45 from Alexey Min  ---
I thought KDE's xembedsniproxy should solve all (most) problems with old-style
tray icons...

@Robert Walker you can try to run steam without xembedsniproxy running (killall
xembedsniproxy before starting wine) and a separate wine tray window should
appear ;)

Version of plasma-desktop BTW?
> Any news on this? Is there something I can do to help with my limited skills such as testing a patch, etc.?

You can try to convince wine mantainers to move to more modern patch submission
system - who uses email patches in 2018? Don't tell me about linux kernel...

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #46 from Robert Walker  ---
Created attachment 60604
  --> https://bugs.winehq.org/attachment.cgi?id=60604
wine_steam_systray.log.txt

@Alexey Min

I've rebuilt plasma-desktop without legacy systray support. I've also done:

killall xembedsniproxy

and verified that xembedsniproxy is no longer running.
However sadly this makes little difference to my previous issues experienced
with your patch.

Tested with vanilla Wine 3.2 and Plasma 5.12.2 on Gentoo GNU/Linux.

I've attached a terminal log with:

export WINEDEBUG=-all,+tid,+timestamp,+systray

and starting up the Windows Steam client with auto-login enabled.

I've demonstrated that it's possible to switch panes in the Steam window with
the RHS mouse click on the systray icon. The context menu works - as does the
action.

However I consistently get the:

13788.054:007c:trace:systray:root_message_handler DBus: message for path
[/org/freedesktop/DBus/Local] dest [(null)], intf
[org.freedesktop.DBus.Local].[Disconnected]

when the system tray icon disappears - with little variation in the timing (~4
seconds from systray icon appearing to disappearing). Whether I interact with
the systray icon or not - has no effect on how long it stays active.

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #47 from Alexey Min  ---
@Robert Walker
I just tested windows steam client with unpatched wine 3.2 (from git) with
Ubuntu 16.04 (Plasma 5.8.8, KF 5.36, Qt 5.6.1) and it works fine. With
xembedsniproxy running.
> Steam Client can ONLY minimise to a system tray (not to a Desktop taskbar / panel)

Not only Steam window can be minimized to taskbar and restored from it, but it
can also be successfully restored from tray icon, when steam window was
actually closed (disappeared from task bar panel). So, this whole patch is not
so important, I guess: https://i.imgur.com/8CbP236.png (blurry icon is a
consequence of using xembedsniproxy).

I suggest you to try vanilla wine from git (no patches) and Plasma with
legacy-systray (xembedsniproxy). If it does not work, you can killall
xembedsniproxy, restart wine and a separate wine systray popup window should
appear, it should always work as last resort.

I can try to test it with Gentoo and Plasma 5.12 some time later today,
tomorrow or at least this week.

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #48 from Josh  ---
Just to put things into perspective:

This bug affects multiple distros and desktop environments (see the duplicates,
such as https://bugs.winehq.org/show_bug.cgi?id=42515). On elementaryOS with
Pantheon, there is no legacy systray support.

Also, as the word "legacy" implies, this is old stuff that will have to be
replaced sooner or later anyway. There may be certain workarounds that work for
a subset of users for now but this issue is still relevant.

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #49 from Alexey Min  ---
(In reply to Robert Walker from comment #46)
> Tested with vanilla Wine 3.2 and Plasma 5.12.2 on Gentoo GNU/Linux.

@Robert Walker
This is how it looks like in Gentoo with xembedsniproxy killed - a separate
floating wine tray window appears, with a icon, that what I was talking about.
It is annoying, but fully functional :) https://i.imgur.com/C9VRn7d.png
> 13788.054:007c:trace:systray:root_message_handler DBus: message for path
> [/org/freedesktop/DBus/Local] dest [(null)], intf
> [org.freedesktop.DBus.Local].[Disconnected]

It just means that we disconnected from DBus.. for some reason :(

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #50 from Robert Walker  ---
(In reply to Alexey Min from comment #49)
> (In reply to Robert Walker from comment #46)
> > Tested with vanilla Wine 3.2 and Plasma 5.12.2 on Gentoo GNU/Linux.
>
> @Robert Walker
> This is how it looks like in Gentoo with xembedsniproxy killed - a separate
> floating wine tray window appears, with a icon, that what I was talking
> about. It is annoying, but fully functional :)
> https://i.imgur.com/C9VRn7d.png

I've tested Steam with Plasma 5 on my Arch and Gentoo installs. The icon sits
dumbly there (in the systemtray) but does not respond to any mouse clicks. It's
important to note that Plasma 5 compiled with legacy tray support - will
attempt to embed the tray icon in an existing displayed system tray... That is
what I'm talking about! I.e. a Plasma 5 setup with legacy systemtray support
compiled in and enabled, and a Plasma systemtray plasmoid active in the panel
(old skool style).

Occasionally embedding fails on my system - then I also get a functional Wine
system tray floating about somewhere on the screen... That's some kind of
obscure xembed timing bug as far as I can tell... That is not what I am talking
about!
> > 13788.054:007c:trace:systray:root_message_handler DBus: message for path
> > [/org/freedesktop/DBus/Local] dest [(null)], intf
> > [org.freedesktop.DBus.Local].[Disconnected]
>
> It just means that we disconnected from DBus.. for some reason :(

It's alright - I've figured out and resolved this issue (with a minor tweak to
your patch).  I'd stupidly disabled all non systray WINEDEBUG channels - in my
posted log. Basically Dbus returned a response that about a non-UTF8 string
(which I'd excluded from the log!!)

So I was perpetually downloading a big update for Sleeping Dogs TM - where the
TM symbol is a UTF-8 code. This symbol broke your original patch
WideCharToMultiByte() call(s). As soon as this download started the Steam
systray icon was kicked off Dbus! Converting the toot tip title string to UTF8
appear to resolve that issue (correctly??) and displays the TM symbol as
expected.

I'd actually moved on to poking about to see if I can improve other areas of
functionality... I think that selecting items in the Steam context menu should
also unminimise the main Steam window... Because Steam minimises to the system
tray - leaving the panel icon as a useless place holder that doesn't really
work properly.

Thoughts? :-)

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #51 from Alexey Min  ---
(In reply to Robert Walker from comment #50)
> > > 13788.054:007c:trace:systray:root_message_handler DBus: message for path
> > > [/org/freedesktop/DBus/Local] dest [(null)], intf
> > > [org.freedesktop.DBus.Local].[Disconnected]
> >
> > It just means that we disconnected from DBus.. for some reason :(
>
> It's alright - I've figured out and resolved this issue (with a minor tweak
> to your patch).

How exactly did you resolve this issue?
> Converting the toot tip title string to
> UTF8 appear to resolve that issue (correctly??) and displays the TM symbol
> as expected.

So now it is working for you? ;)
> I think that selecting items in the Steam context menu
> should also unminimise the main Steam window... Because Steam minimises to
> the system tray - leaving the panel icon as a useless place holder that
> doesn't really work properly.
> Thoughts? :-)

Panel icon can minimize/restore Steam client window for me....

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52966|0                           |1
        is obsolete|                            |
  Attachment #59016|0                           |1
        is obsolete|                            |
                 CC|                            |[e-mail]

--- Comment #52 from François Gouget  ---
Created attachment 62509
  --> https://bugs.winehq.org/attachment.cgi?id=62509
winex11: add DBus systray support (StatusNotifierItem).

Rebased on top of the current Wine (solves a conflict with Vulkan and a
compilation error due to a missing version field).

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #53 from sl1pkn07  ---
(In reply to François Gouget from comment #52)
> Created attachment 62509 [details]
> winex11: add DBus systray support (StatusNotifierItem).
>
> Rebased on top of the current Wine (solves a conflict with Vulkan and a
> compilation error due to a missing version field).

THANKS BRO!!!!!

greetings

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

Robert Walker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60604|0                           |1
        is obsolete|                            |

--- Comment #54 from Robert Walker  ---
Created attachment 62815
  --> https://bugs.winehq.org/attachment.cgi?id=62815
wine-vanilla-3.20_implement_dbus_systray.patch

This is a rebased copy of Alexey Min's original patch. I've included some very
minimal changes, to add support for UTF-8 tooltip text. Without this support
common update notifications, e.g. from Steam game updates, will break the
original patch.

NB this patch will also apply cleanly to wine-staging-3.20 (which I tested it
on).

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

David  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #55 from David  ---
This problem also seems to affect Ubuntu 18.10 Gnome/Unity running wine
4.0-rc5. It doesn't really hurt anything, but it sure looks silly. Is there a
rebased patch available (or necessary?) for 4.0?

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

Tom Englund  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #56 from Tom Englund  ---
(In reply to Robert Walker from comment #54)
> Created attachment 62815 [details]
> wine-vanilla-3.20_implement_dbus_systray.patch
>
> This is a rebased copy of Alexey Min's original patch. I've included some
> very minimal changes, to add support for UTF-8 tooltip text. Without this
> support common update notifications, e.g. from Steam game updates, will
> break the original patch.
>
> NB this patch will also apply cleanly to wine-staging-3.20 (which I tested
> it on).

hm oddly enough the icon appears and the "tooltip text" shows when mousing over
it, but neither left or right clicks does anything. and checking with WINEDEBUG
it seems to initialize and register both clicks just fine but no context menu
shows :/

4939.841:0025:trace:systray:initialize_dbus Initialize DBUS OK
4939.841:0025:trace:systray:root_message_handler DBus: message for path
[/org/freedesktop/DBus] dest [:1.125], intf
[org.freedesktop.DBus].[NameAcquired]
4939.841:0025:trace:systray:connect_dbus DBus: connected to SESSION bus as
':1.125'.
4939.841:0025:trace:systray:is_statusnotifier_host_running DBus: detected that
org.kde.StatusNotifierWatcher present, will ask him about StatusNotifierHost!
4939.841:0025:trace:systray:is_statusnotifier_host_running DBus: OK: Got
prop.get reply, IsStatusNotifierHostRegistered = 1
4939.841:0025:trace:systray:can_use_dbus_sni_systray DBus: detected that we can
use DBus systray instead of XEmbed
4939.841:0025:trace:systray:add_sni_icon id=0x0, hwnd=0x100a0
4939.842:0025:trace:systray:assign_tray_icon_data fIcon = 1, (hotspot 8, 8)
mask = 0x1005f, color = 0x1005e
4939.842:0025:trace:systray:assign_tray_icon_data System icon size: 32 x 32
4939.842:0025:trace:systray:assign_tray_icon_data Got color bitmap: bmType = 0
4939.842:0025:trace:systray:assign_tray_icon_data                   size = 16 x
16
4939.842:0025:trace:systray:assign_tray_icon_data                   scanline
bytes = 64
4939.842:0025:trace:systray:assign_tray_icon_data                   color
planes = 1
4939.842:0025:trace:systray:assign_tray_icon_data                   bits per
pixel = 32
4939.842:0025:trace:systray:assign_tray_icon_data                   bits
pointer = 0x630000
4939.842:0025:trace:systray:assign_tray_icon_data Saved icon bitmap, 1024 bytes
4939.842:0025:trace:systray:start_dbus_thread started dbus_thread
4939.842:0025:trace:systray:add_sni_icon Requesting name
[org.kde.StatusNotifierItem-41-0]...
4939.842:0025:trace:systray:add_sni_icon Request name
[org.kde.StatusNotifierItem-41-0] OK!
4939.842:0025:trace:systray:add_sni_icon Using [wine] as application name
4939.842:0073:trace:systray:root_message_handler DBus: message for path
[/org/freedesktop/DBus] dest [:1.125], intf
[org.freedesktop.DBus].[NameAcquired]
4939.842:002a:trace:systray:Shell_NotifyIconW dwMessage = 4, nid->cbSize=956
4940.143:0073:trace:systray:root_message_handler DBus: message for path
[/StatusNotifierItem] dest [org.kde.StatusNotifierItem-41-0], intf
[org.freedesktop.DBus.Properties].[GetAll]
4940.143:0073:trace:systray:root_message_handler DBus: Properties.GetAll(
"org.kde.StatusNotifierItem" )
4940.143:0073:trace:systray:root_message_handler Propgetall reply for icon
org.kde.StatusNotifierItem-41-0
4946.750:0073:trace:systray:root_message_handler DBus: message for path
[/StatusNotifierItem] dest [org.kde.StatusNotifierItem-41-0], intf
[org.kde.StatusNotifierItem].[Activate]
4946.750:0073:trace:systray:root_message_handler
org.kde.StatusNotifierItem:Activate()
4946.750:0073:trace:systray:relay_windows_message DBus: relaying 0x201
4946.751:0073:trace:systray:relay_windows_message DBus: relaying 0x202
4947.384:0073:trace:systray:root_message_handler DBus: message for path
[/StatusNotifierItem] dest [org.kde.StatusNotifierItem-41-0], intf
[org.kde.StatusNotifierItem].[ContextMenu]
4947.384:0073:trace:systray:root_message_handler
org.kde.StatusNotifierItem:ContextMenu()
4947.384:0073:trace:systray:relay_windows_message DBus: relaying 0x204
4947.384:0073:trace:systray:relay_windows_message DBus: relaying 0x205

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #57 from Richard H.  ---
(In reply to Tom Englund from comment #56)
> (In reply to Robert Walker from comment #54)
> > Created attachment 62815 [details]
> > wine-vanilla-3.20_implement_dbus_systray.patch
> >
> > This is a rebased copy of Alexey Min's original patch. I've included some
> > very minimal changes, to add support for UTF-8 tooltip text. Without this
> > support common update notifications, e.g. from Steam game updates, will
> > break the original patch.
> >
> > NB this patch will also apply cleanly to wine-staging-3.20 (which I tested
> > it on).
>
> hm oddly enough the icon appears and the "tooltip text" shows when mousing
> over it, but neither left or right clicks does anything. and checking with
> WINEDEBUG
> it seems to initialize and register both clicks just fine but no context
> menu shows :/
>
> 4939.841:0025:trace:systray:initialize_dbus Initialize DBUS OK
> 4939.841:0025:trace:systray:root_message_handler DBus: message for path
> [/org/freedesktop/DBus] dest [:1.125], intf
> [org.freedesktop.DBus].[NameAcquired]
> 4939.841:0025:trace:systray:connect_dbus DBus: connected to SESSION bus as
> ':1.125'.
> 4939.841:0025:trace:systray:is_statusnotifier_host_running DBus: detected
> that org.kde.StatusNotifierWatcher present, will ask him about
> StatusNotifierHost!
> 4939.841:0025:trace:systray:is_statusnotifier_host_running DBus: OK: Got
> prop.get reply, IsStatusNotifierHostRegistered = 1
> 4939.841:0025:trace:systray:can_use_dbus_sni_systray DBus: detected that we
> can use DBus systray instead of XEmbed
> 4939.841:0025:trace:systray:add_sni_icon id=0x0, hwnd=0x100a0
> 4939.842:0025:trace:systray:assign_tray_icon_data fIcon = 1, (hotspot 8, 8)
> mask = 0x1005f, color = 0x1005e
> 4939.842:0025:trace:systray:assign_tray_icon_data System icon size: 32 x 32
> 4939.842:0025:trace:systray:assign_tray_icon_data Got color bitmap: bmType =
> 0
> 4939.842:0025:trace:systray:assign_tray_icon_data                   size =
> 16 x 16
> 4939.842:0025:trace:systray:assign_tray_icon_data                   scanline
> bytes = 64
> 4939.842:0025:trace:systray:assign_tray_icon_data                   color
> planes = 1
> 4939.842:0025:trace:systray:assign_tray_icon_data                   bits per
> pixel = 32
> 4939.842:0025:trace:systray:assign_tray_icon_data                   bits
> pointer = 0x630000
> 4939.842:0025:trace:systray:assign_tray_icon_data Saved icon bitmap, 1024
> bytes
> 4939.842:0025:trace:systray:start_dbus_thread started dbus_thread
> 4939.842:0025:trace:systray:add_sni_icon Requesting name
> [org.kde.StatusNotifierItem-41-0]...
> 4939.842:0025:trace:systray:add_sni_icon Request name
> [org.kde.StatusNotifierItem-41-0] OK!
> 4939.842:0025:trace:systray:add_sni_icon Using [wine] as application name
> 4939.842:0073:trace:systray:root_message_handler DBus: message for path
> [/org/freedesktop/DBus] dest [:1.125], intf
> [org.freedesktop.DBus].[NameAcquired]
> 4939.842:002a:trace:systray:Shell_NotifyIconW dwMessage = 4, nid->cbSize=956
> 4940.143:0073:trace:systray:root_message_handler DBus: message for path
> [/StatusNotifierItem] dest [org.kde.StatusNotifierItem-41-0], intf
> [org.freedesktop.DBus.Properties].[GetAll]
> 4940.143:0073:trace:systray:root_message_handler DBus: Properties.GetAll(
> "org.kde.StatusNotifierItem" )
> 4940.143:0073:trace:systray:root_message_handler Propgetall reply for icon
> org.kde.StatusNotifierItem-41-0
> 4946.750:0073:trace:systray:root_message_handler DBus: message for path
> [/StatusNotifierItem] dest [org.kde.StatusNotifierItem-41-0], intf
> [org.kde.StatusNotifierItem].[Activate]
> 4946.750:0073:trace:systray:root_message_handler
> org.kde.StatusNotifierItem:Activate()
> 4946.750:0073:trace:systray:relay_windows_message DBus: relaying 0x201
> 4946.751:0073:trace:systray:relay_windows_message DBus: relaying 0x202
> 4947.384:0073:trace:systray:root_message_handler DBus: message for path
> [/StatusNotifierItem] dest [org.kde.StatusNotifierItem-41-0], intf
> [org.kde.StatusNotifierItem].[ContextMenu]
> 4947.384:0073:trace:systray:root_message_handler
> org.kde.StatusNotifierItem:ContextMenu()
> 4947.384:0073:trace:systray:relay_windows_message DBus: relaying 0x204
> 4947.384:0073:trace:systray:relay_windows_message DBus: relaying 0x205

I can totally confirm this. BUT it's not consistent. "Sometimes" it just works.
Sometimes the Icon just is "dead". I don't know how to reproduce it, however.

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #58 from Joerg Schiermeier  ---
Created attachment 63912
  --> https://bugs.winehq.org/attachment.cgi?id=63912
Flying window instead of systray

This bug is still alive in wine version: 4.4. My KDE/Plasma is v5.14.5.

wine / the app which is started opens a separat window on top of KDE and shows
there the icon or pic which is normally show in KDEs systray.
This behaviour was introduced with Plasma. KDE 4 hadn't this bug - there was
the icon or pic show correctly in KDEs systray.

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38409

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38409

Reinhart Previano  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #59 from Reinhart Previano  ---
In Wine 5.0, KDE Plasma 5.18 I can see that WINE's systray is integrated with
Plasma (using the "System Tray" plasmoid). The window (on the attached image)
is currently visible when I'm shutting down the device.

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #60 from Reinhart Previano  ---
Created attachment 66914
  --> https://bugs.winehq.org/attachment.cgi?id=66914
Systray integration with WINE 5.0 and KDE Plasma 5.18

Tested application: LINE
(https://appdb.winehq.org/objectManager.php?sClass=version&iId=38803)

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38409

Pacho Ramos  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38409

Konrad Materka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #61 from Konrad Materka  ---
System tray icons are working correctly in KDE, thanks to XEmbedSNIProxy. I
fixed most of the issues in XEmbedSNIProxy, it is pretty stable now. We can say
that the initial issue is solved.

Unfortunately XEmbedSNIProxy is not a proper solution, it is just a workaround.
For example tooltips are not working and never will. There are other
limitations to.

Support for legacy XEmbed was dropped long time ago, not only in KDE, but also
in Gnome. StatusNotifierItem DBus protocol is the only supported one. As a
bonus it removes dependency on X11 and can work on Wayland.

@Alexey Min
Can you try to upstream your SNI DBus patch? I guess Wine Staging would be a
good place for it, at least initially. I saw that there are some issues and
limitation (left/right click not working, missing balloon messages) but this
can be worked out.
What do you think?

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38409

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #62 from [e-mail] ---
I would love to see this upstreamed as well. If @Alexey Min isn't interested in
submitting this upstream, could @Robert Walker submit his patch upstream maybe?
It also contains some fixes, such as UTF-8 notifications.

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #63 from Alexey Min  ---
One gigantic patch like this is not suitable for upstreaming anyway. It needs
to be split into several commits; but most importantly all this logic does not
belong to winex11.drv, it should be placed into explorer.exe before actual call
into backend, so theoretical wayland support is possible in the future.

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38409

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #64 from sl1pkn07  ---
62509 seems start fail wen build with community/mingw-w64-gcc in wine 5.16

/usr/bin/ld: systray_dbus.o: in function `can_use_dbus_sni_systray':
systray_dbus.c:(.text+0x27d8): undefined reference to `wine_dlopen'
/usr/bin/ld: systray_dbus.c:(.text+0x2aa8): undefined reference to `wine_dlsym'
/usr/bin/ld: systray_dbus.c:(.text+0x2ad3): undefined reference to `wine_dlsym'
/usr/bin/ld: systray_dbus.c:(.text+0x2afe): undefined reference to `wine_dlsym'
/usr/bin/ld: systray_dbus.c:(.text+0x2b29): undefined reference to `wine_dlsym'
/usr/bin/ld: systray_dbus.c:(.text+0x2b54): undefined reference to `wine_dlsym'
/usr/bin/ld: systray_dbus.o:systray_dbus.c:(.text+0x2b7f): more undefined
references to `wine_dlsym' follow

how to fix this?

greetings

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #65 from sl1pkn07  ---
ok, seems change to

+    if (!(handle = dlopen(SONAME_LIBDBUS_1, RTLD_NOW )))

and

+#define DO_FUNC(f) if (!(p_##f = dlsym( handle, #f ))) goto failed

do the trick

greetings

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #66 from sl1pkn07  ---
Created attachment 68103
  --> https://bugs.winehq.org/attachment.cgi?id=68103
patch with upstream wine dlopen/dlsym changes

updated 62509 patch

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38409

Josh  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]          |

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #67 from Joerg Schiermeier  ---
This behaviour could not be seen in wine v6.0-rc1.

So: seems to be fixed now!

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #68 from Joerg Schiermeier  ---
Not seen again since wine version v6.0-rc1.

Look like the issue is solved.

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38409

--- Comment #69 from Richard H.  ---
Yes, I can confirm it is fixed now.

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38409

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #70 from Gijs Vermeulen  ---
Reported fixed, marking as such.
If anyone can still reproduce, please reopen.

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38409

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]           |

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38409

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #71 from Alexandre Julliard  ---
Closing bugs fixed in 6.6.

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38409

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #72 from [e-mail] ---
Wait, how is this fixed ?

First, I still have the issue on sway (7.15 staging).

And unless I’m missing something, master still uses the legacy method :
https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/winex11.drv/window.c#....

[Bug 38409] Wine's task tray is not shown in the taskbar in KDE 5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38409

Zeb Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #73 from Zeb Figura  ---
(In reply to sloonz from comment #72)
> Wait, how is this fixed ?
>
> First, I still have the issue on sway (7.15 staging).

Is the issue specific to Wayland, or does it occur with x11 as well?
> And unless I’m missing something, master still uses the legacy method :
> https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/winex11.drv/window.
> c#L2217.

Presumably due to xembed-sni-proxy.