[Bug 58552] New: Yabridge plugins GUI is not located on the exact location of the GUI element (WINE 10.12)

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58552

Bug ID: 58552
           Summary: Yabridge plugins GUI is not located on the exact
                    location of the GUI element (WINE 10.12)
           Product: Wine
           Version: 10.12
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

hi, i use vanilla OS debian unstable. i have a problem on wine version 10,
Where the GUI is not located in the exact gui element. i keep clicking on the
empty places, it makes a sound. i don't know why its like that, but i hope you
can fix it.

I'm suffering installing wine 9.0 since the older packages is not available in
the newer versions of Vanilla/Debian. I hope this can be fixed sooner.

-Yuji Chen, Vanilla OS 2 (Debian Sid)

[Bug 58552] Yabridge plugins GUI is not located on the exact location of the GUI element (WINE 10.12)

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58552

--- Comment #1 from Austin English  ---
Hi Yuji,

Does this application have a free demo/download available that can reproduce
the issue? Can you please attach a screenshot showing the problem (and a
screenshot from windows showing the correct behavior, if possible). Lastly,
please attach the terminal output.

[Bug 58552] Yabridge plugins GUI is not located on the exact location of the GUI element (WINE 10.12)

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58552

Stian Low  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Stian Low  ---
(In reply to Austin English from comment #1)
> Hi Yuji,
>
> Does this application have a free demo/download available that can reproduce
> the issue? Can you please attach a screenshot showing the problem (and a
> screenshot from windows showing the correct behavior, if possible). Lastly,
> please attach the terminal output.

This seems to be related to a known yabridge wine issue:
https://github.com/robbert-vdh/yabridge/issues/382

Sample VSTs (extracted as ~/Downloads/VST\ Plugins):
https://archive.org/download/trance-gate-2-x-32/VST%20Plugins.zip

To reproduce (with a fresh and so clean ~/.wine):
1. yabridge prep (vst handler)
   1. Extract as ~/.local/share/yabridge:
https://github.com/robbert-vdh/yabridge/releases/download/5.1.1/yabridge-5.1...
   2. ~/.local/share/yabridge/yabridgectl add ~/Downloads/VST\ Plugins/VST\
Plugins/
   3. /home/any/.local/share/yabridge/yabridgectl sync

2. carla prep (audio/music studio that uses yabridge to handle vst plugins)
   1. Extract as ~/Downloads/Carla_2.2.0-linux64:
https://github.com/falkTX/Carla/releases/download/v2.2.0/Carla_2.2.0-linux64...
   2. ~/Downloads/Carla_2.2.0-linux64/Carla

Step 2.2 launches Carla.

3. Add yabridge to carla
   1. Click "Add Plugin" button to open "Add New" popup window
   2. Click "Refresh" button in "Add new" popup window to open "Refresh" popup
window
   3. Click "Scan" button in "Refresh" popup window to scan/import
~/.vst/yabridge
   4. Click "Close" button in "Refresh" popup window to return to "Add New"
popup window
   5. Uncheck all except "VST2" checkboxes in "Format" panel at top right side
of "Add New" popup window
   6. Check mark VST lists in the center panel including the VST named "Future"
   7. Select the VST named "Future" in the center panel and click "Add Plugin"

Step 3.7 adds the VST via yabridge via wine represented in Carla as a rack on
the default Rack tab.

4. Open VST GUI to reproduce offset issue:
   1. Click the button represented by a gear icon for VST Rack added to the
Rack tab (gear button located between the buttons with power and wrench-tool
icons at the top left of the VST Rack)
   2. Move the mouse over the large top right most knob in the VST window and
try to click and drag to turn the knob

Step 4.2 failed due to the GUI offset issue because the large topright most
knob is outside the offset space.

[Bug 58552] Yabridge plugins GUI is not located on the exact location of the GUI element (WINE 10.12)

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58552

--- Comment #3 from Stian Low  ---
Partial workaround for Wine 10.12 on Debian 12:
1. Run `wine winecfg` to open wine configuration
2. Click "Graphics Tab"
3. Click "Emulate a virtual desktop"
4. Click OK
5. Retest yabridge and confirm GUI offset resolved

This workaround fixes the GUI offset.  VST still appear in their own separate
windows and the mouse aligns with the buttons and properly.  However the
combobox controls although clickable, their options popup appears in the Wine
virtual window rather than in the dedicated VST window.

[Bug 58552] Yabridge plugins GUI is not located on the exact location of the GUI element (WINE 10.12)

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58552

--- Comment #4 from Stian Low  ---
Created attachment 79086
  --> http://bugs.winehq.org/attachment.cgi?id=79086
Screenshot partial workaround with winecfg virtual desktop

Attached is a snapshot of 2 instances of the "Future" VST described in the
reproduce steps loaded into Carla with winecfg virtual desktop enabled.

The virtual desktop window at the left side was brought from the background to
the forefront but doesn't showcase the combobox options described by the
workaround because for some reason Debian 12 snapshot tool won't trigger via
the PrintScreen button while combobox is active with options shown.  As soon as
the combobox is unfocused and options are hidden the snapshot tool is triggered
by the Printscreen button again.

Oddities.

[Bug 58552] Yabridge plugins GUI is not located on the exact location of the GUI element (WINE 10.12)

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58552

--- Comment #5 from Stian Low  ---
Created attachment 79087
  --> http://bugs.winehq.org/attachment.cgi?id=79087
Screenshot of VST working for Wine 8.0 (Debian 12)

Attached is a screenshot showcasing the expected VST functionality working for
wine-8.0 (Debian 8.0~repack-4).

The combobox dropdown options appear with the button which is aligned and
clickable via the mouse.

This 8.0 test reinforces the yabridge bug that reports issues around Wine 9.22:
https://github.com/robbert-vdh/yabridge/issues/382

Regarding the prevoius Wine 10.12 tests, the GUI offset issue was reproduced
for both Wayand and X11.

[Bug 58552] Yabridge plugins GUI is not located on the exact location of the GUI element (WINE 10.12)

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58552

--- Comment #6 from Stian Low  ---
(In reply to Stian Low from comment #5)
> The combobox dropdown options appear with the button which is aligned and
> clickable via the mouse.

For clarity, the 8.0 test was run with a fresh ~/.wine and without the winecfg
virtual desktop enabled mentioned as a partial workaround for 10.12.

[Bug 58552] Yabridge plugins GUI is not located on the exact location of the GUI element (WINE 10.12)

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58552

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 58552] Yabridge plugins GUI is not located on the exact location of the GUI element

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58552

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Yabridge plugins GUI is not |Yabridge plugins GUI is not
                   |located on the exact        |located on the exact
                   |location of the GUI element |location of the GUI element
                   |(WINE 10.12)                |

[Bug 58552] Yabridge plugins GUI is not located on the exact location of the GUI element

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58552

--- Comment #7 from Stian Low  ---
Related: https://bugs.winehq.org/show_bug.cgi?id=57754

[Bug 58552] Yabridge plugins GUI is not located on the exact location of the GUI element

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58552

--- Comment #8 from Stian Low  ---
Also related: https://bugs.winehq.org/show_bug.cgi?id=58506

[Bug 58552] Yabridge plugins GUI is not located on the exact location of the GUI element

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58552

--- Comment #9 from Stian Low  ---
See yabridge dev Robbert van der Helm responses for further details regarding
this issue:
https://gitlab.winehq.org/wine/wine/-/merge_requests/6569

[Bug 58552] Yabridge plugins GUI is not located on the exact location of the GUI element

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58552

--- Comment #10 from Stian Low  ---
Created attachment 79097
  --> http://bugs.winehq.org/attachment.cgi?id=79097
Patch to commit 8fa114fae34 (wine-10.11)

Via the glory of
https://gitlab.winehq.org/wine/wine/-/wikis/Regression-Testing#running-the-b...:

Bisect Rest (2)
d8b5a3ae129 * @ winex11: Update the window client config on window state
changes.
03738c3f22f * winex11: Wait for pending ConfigureNotify before updating the
client state.

Commit d8b5a3ae129 to dlls/winex11.drv/window.c involving
"data->wm_state_serial" introduced the bug.

The patch simply comments a line added for wm_state_serial which fixs the GUI
offset issues described in the reproduce steps.

This may not be a proper fix based on discussions at:
https://gitlab.winehq.org/wine/wine/-/merge_requests/6569#05752921556c31c592...

This patch is a temp workaround for now until further review and updates focus
to the underlying issue involving wm_state_serial at dlls/winex11.drv/window.c.

[Bug 58552] Yabridge plugins GUI is not located on the exact location of the GUI element

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58552

--- Comment #11 from Stian Low  ---
Created attachment 79098
  --> http://bugs.winehq.org/attachment.cgi?id=79098
Improved patch to commit 8fa114fae34 (wine-10.11)

This patch overrides the previous patch with improvements.

The previous patch still had GUI offset issues once a VST window was moved. 
Also, when multiple VST windows were open only the last one that was open was
properly aligned with the mouse.

This patch keeps the mouse aligned even if the VST window is moved and supports
multiple VST windows which can also be moved.

[Bug 58552] Yabridge plugins GUI is not located on the exact location of the GUI element

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58552

--- Comment #12 from Stian Low  ---
Created attachment 79099
  --> http://bugs.winehq.org/attachment.cgi?id=79099
Screenshot showcasing latest patch

This screenshot showcases the latest patch improvements.

All VST window controls were aligned with the mouse and all windows could be
moved anywhere and the controls remained aligned to the mouse.

It doesn't showcase the dropdown menu open because for some reason the Debian
snapshot tool is disabed again when its open.

[Bug 58552] Yabridge plugins GUI is not located on the exact location of the GUI element

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58552

Patrick  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick+winehq.org@laimbock
                   |                            |.com

--- Comment #13 from Patrick  ---
Thank you for your efforts to bisect the issue. I just tested your latest patch
(and MR 8669 from https://gitlab.winehq.org/wine/wine/-/merge_requests/8669) in
a wine-tkg 10.12 build and Bitwig 5.3.12. It works in Bitwig when the VST
window initially appears. But once you hide the VST window in Bitwig and make
it appear again then it stops working. I'll test again with just your latest
patch (so without MR 8669).

In case you use Fedora 42 x86_64 then you can find my wine build here:
https://copr.fedorainfracloud.org/coprs/patrickl/wine-tkg-dev/

[Bug 58552] Yabridge plugins GUI is not located on the exact location of the GUI element

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58552

--- Comment #14 from Stian Low  ---
(In reply to Patrick from comment #13)
> Thank you for your efforts to bisect the issue. I just tested your latest
> patch (and MR 8669 from
> https://gitlab.winehq.org/wine/wine/-/merge_requests/8669) in a wine-tkg
> 10.12 build and Bitwig 5.3.12. It works in Bitwig when the VST window
> initially appears. But once you hide the VST window in Bitwig and make it
> appear again then it stops working. I'll test again with just your latest
> patch (so without MR 8669).
>
> In case you use Fedora 42 x86_64 then you can find my wine build here:
> https://copr.fedorainfracloud.org/coprs/patrickl/wine-tkg-dev/

Thanks for testing and the links.  I'm Debian 12 but Fedora ref still
appreciated.

I retested opening and closing VST windows against Carla and it worked fine
with the latest patch against latest commit 8fa114fae34 pulled today.

I'll try to reproduce on Bitwig (assuming  the Linux version and not Windows).

[Bug 58552] Yabridge plugins GUI is not located on the exact location of the GUI element

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58552

--- Comment #15 from Stian Low  ---
Created attachment 79103
  --> http://bugs.winehq.org/attachment.cgi?id=79103
Snapshot of Bitwig error when trying to load yabridge *.so

(In reply to Stian Low from comment #14)
> (In reply to Patrick from comment #13)
> I'll try to reproduce on Bitwig (assuming  the Linux version and not
> Windows).

I will need help to reproduce Bitwig issues reported.

Windows Bigwig allow VST dlls to be loaded directly but VST dlls don't appear
for Linux Bitwig.

The ~/.vst/yabridge *.so files from the VST dlls appear but upon loading one
produces the error shown in the top right corner of the window.

[Bug 58552] Yabridge plugins GUI is not located on the exact location of the GUI element

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58552

--- Comment #16 from Patrick  ---
I built wine WoW64 HEAD (no staging) from commit
https://gitlab.winehq.org/wine/wine/-/commit/91d3874b6528cb71b346c1d114914bc...
+ your latest patch + https://gitlab.winehq.org/wine/wine/-/merge_requests/8669
and I tried Blamsoft VK-1 Viking synth and Voxengo SPAN (both free) in Bitwig
(on Linux).

Blamsoft VK-1 Viking
--------------------
When it first appears:
The mouse offset is present

When I move the VK-1 window:
I can use the knobs
Selecting presets works

When I close the VK-1 window in Bitwig and make it appear again:
The mouse offset is back

When I move the VK-1 window to the topleft:
I can use the knobs

When I move the VK-1 window:
I can still use the knobs

Voxengo Span
------------
When it first appears:
I can use the knobs
Sometimes the mouse pointer was not visible in the Span window and I had to
move the Span window so the cursor appears. Then I could use the knobs

When I move the Span window:
I can still use the knobs

When I close the Span window in Bitwig and make it appear again:
The mouse offset is back

When I move the Span window to the topleft:
I can use the knobs

When I move the Span window:
I can still use the knobs

[Bug 58552] Yabridge plugins GUI is not located on the exact location of the GUI element

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58552

--- Comment #17 from Stian Low  ---
Created attachment 79105
  --> http://bugs.winehq.org/attachment.cgi?id=79105
Screenshot of VK-1 Viking Synth and Voxengo SPAN in Carla via yabridge

Thanks for feedback.

Attached is a screenshot of 2 instances each of "Blamsoft VK-1 Viking" and
"Voxengo Span" VSTs running in Carla via yabridge.

Regarding the GUI offset issue, the mouse aligns with all controls and still
works when moving windows around arbitrarily.

The only misbehavior (minor and may be outside the scope of GUI offset fixes)
is child windows always appear on top in the order in which they were opened. 
This is showcased by the screenshot of "Voxengo Span" Routing child windows
open for both instances.

Otherwise everything seems to work as expected.

I still need guidance on how to load the VSTs for Linux Bitwig.  Linux Bitwig
still throws the error shown in the top right corner of the previous screenshot
when loading yabridge *.so files for these latest 2 VSTs.

Does Linux Bitwig load VSTs differently than yabrige *.so files?  Still seeking
Bitwig docs that describe how to load VSTs for Linux.

[Bug 58552] Yabridge plugins GUI is not located on the exact location of the GUI element

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58552

--- Comment #18 from Stian Low  ---
(In reply to Patrick from comment #16)
> When I close the Span window in Bitwig and make it appear again:
> The mouse offset is back

Also, for clarity, all VST windows opened without the GUI offset for
Carla/yabridge and could be closed and reopened without the issues described
for Linux Bitwig.