http://bugs.winehq.org/show_bug.cgi?id=18214
Summary: winboard 4.2.7b -- ICS client doesn't have horizontal scrollbars Product: Wine Version: 1.1.20 Platform: PC URL: http://ftp.gnu.org/gnu/winboard/winboard-4_2_7b.exe OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: richedit AssignedTo: wine-bugs@winehq.org ReportedBy: emwine@earthlink.net CC: dylan.ah.smith@gmail.com
Created an attachment (id=20712) --> (http://bugs.winehq.org/attachment.cgi?id=20712) Screenshots
The following patch caused winboard to get horizontal scrollbars in ICS mode. These uglify the application, particularly in the data entry area where you can no longer see what you're typing. Neither the data entry nor data output windows should have horizontal scrollbars. (see attachment jpg)
The URL includes the app only, the source is here: http://ftp.gnu.org/gnu/xboard/xboard-4.2.7.tar.gz
Attached is an image with 2 screenshots: the upper being after the patch, the lower being before the patch or with native riched20.
Patch information: e6fedf879c0666f1646b013d920fa7752f4ea42d is first bad commit commit e6fedf879c0666f1646b013d920fa7752f4ea42d Author: Dylan Smith dylan.ah.smith@gmail.com Date: Wed Jan 14 13:24:02 2009 -0500
richedit: Implemented the horizontal scrollbar.
:040000 040000 b54de2b08db494650224da24659b7adad1ffc89f 298b34f2d6df7d5b3743c4c706c64269661f6597 M dlls
http://bugs.winehq.org/show_bug.cgi?id=18214
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression
http://bugs.winehq.org/show_bug.cgi?id=18214
--- Comment #1 from Eric Mullins emwine@earthlink.net 2009-04-29 12:20:20 --- Created an attachment (id=20816) --> (http://bugs.winehq.org/attachment.cgi?id=20816) Testcase
Added a testcase. Built with VC++ 6.0, prebuilt app is wbtest.exe.
http://bugs.winehq.org/show_bug.cgi?id=18214
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |testcase
http://bugs.winehq.org/show_bug.cgi?id=18214
Dylan Smith dylan.ah.smith@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |ASSIGNED AssignedTo|wine-bugs@winehq.org |dylan.ah.smith@gmail.com Ever Confirmed|0 |1
--- Comment #2 from Dylan Smith dylan.ah.smith@gmail.com 2009-07-16 17:47:48 --- Created an attachment (id=22405) --> (http://bugs.winehq.org/attachment.cgi?id=22405) Tests that I used to create my patch
The problem was mostly that the richedit controls weren't paying attention to the WS_VSCROLL or WS_HSCROLL window styles. I also noticed that the vertical scrollbar wasn't correctly disabled on initialization.
I created the attached set of tests to figure out the correct behaviour, however, I wrote these tests based on the bugs in user32, so they break in windows (See wine_todo statements in user32/tests/scroll.c). Instead I tested using native riched20 override, or using builtin richedit control with the crosstests on windows. It seemed too complicated to fix up the tests to send them in, since it would involve breaking up the macros to add wine_todo statements, and conditions for the different behaviour for win9x, all to deal with the user32 bugs with existing tests for them.
I sent in the following to wine-patches to fix this bug: http://www.winehq.org/pipermail/wine-patches/2009-July/076030.html http://www.winehq.org/pipermail/wine-patches/2009-July/076031.html
http://bugs.winehq.org/show_bug.cgi?id=18214
--- Comment #3 from Dylan Smith dylan.ah.smith@gmail.com 2009-07-17 15:38:11 --- (In reply to comment #2)
I sent in the following to wine-patches to fix this bug: http://www.winehq.org/pipermail/wine-patches/2009-July/076030.html http://www.winehq.org/pipermail/wine-patches/2009-July/076031.html
Patches have been accepted and are now in the latest release (wine-1.1.26).
Please test to make sure the bug has been fixed.
http://bugs.winehq.org/show_bug.cgi?id=18214
--- Comment #4 from Eric Mullins emwine@earthlink.net 2009-07-17 18:10:39 --- (In reply to comment #3)
Please test to make sure the bug has been fixed.
Both the testcase and the app appear to be free of this bug.
http://bugs.winehq.org/show_bug.cgi?id=18214
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED
--- Comment #5 from Ken Sharp kennybobs@o2.co.uk 2009-07-17 18:14:31 --- Fixed.
http://bugs.winehq.org/show_bug.cgi?id=18214
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #6 from Alexandre Julliard julliard@winehq.org 2009-08-07 12:43:22 --- Closing bugs fixed in 1.1.27.
-
wine-bugs＠winehq.org