http://bugs.winehq.org/show_bug.cgi?id=29712
Bug #: 29712 Summary: DInput doesn't support INFINITE effect iterations Product: Wine Version: 1.3.37 Platform: x86-64 OS/Version: Linux Status: UNCONFIRMED Severity: minor Priority: P2 Component: directx-dinput AssignedTo: wine-bugs@winehq.org ReportedBy: mahasler@gmail.com Classification: Unclassified
Created attachment 38559 --> http://bugs.winehq.org/attachment.cgi?id=38559 Patch to make dinput effects support INFINITE.
According to the DirectX reference, IDirectInputEffect::Start accepts INFINITE (aka -1) for the number of iterations. Some games actually use this. However, passing -1 to Linux via input_event results in no effect being played at all (at least for me).
I've made a simple patch that sets the number of iterations to the maximum signed value allowed when INFINITE is passed. I think this should work in practically every case.
Tested to work with Metal Gear Solid 2.
http://bugs.winehq.org/show_bug.cgi?id=29712
Marcel Hasler mahasler@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #38559|0 |1 is obsolete| |
--- Comment #1 from Marcel Hasler mahasler@gmail.com 2012-01-26 10:56:29 CST --- Created attachment 38560 --> http://bugs.winehq.org/attachment.cgi?id=38560 Same as before but compare to #define'd INFINITE
http://bugs.winehq.org/show_bug.cgi?id=29712
Marcel Hasler mahasler@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mahasler@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=29712
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
--- Comment #2 from Austin English austinenglish@gmail.com 2012-01-26 13:36:08 CST --- Patches should be sent to wine-patches@winehq.org. See http://wiki.winehq.org/SubmittingPatches
http://bugs.winehq.org/show_bug.cgi?id=29712
--- Comment #3 from Marcel Hasler mahasler@gmail.com 2012-01-26 14:04:51 CST --- Done. I can't check out the entire git tree right now only to create a patch. Hope they accept it as is.
http://bugs.winehq.org/show_bug.cgi?id=29712
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |c47677fee50b4f3c5a3844d9cfb | |8ea200b83c472 Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #4 from Austin English austinenglish@gmail.com 2012-02-02 13:32:22 CST --- http://source.winehq.org/git/wine.git/commitdiff/c47677fee50b4f3c5a3844d9cfb...
http://bugs.winehq.org/show_bug.cgi?id=29712
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #5 from Alexandre Julliard julliard@winehq.org 2012-02-11 13:53:01 CST --- Closing bugs fixed in 1.4-rc3.
-
wine-bugs＠winehq.org