[Bug 9728] New: Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

Summary: Image and icons corrupts in ShutterFly 2.2
           Product: Wine
           Version: 0.9.44.
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: wine-directx
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=8161)
 --> (http://bugs.winehq.org/attachment.cgi?id=8161)
Screenshot of the intro window

Hi,

This bug relates to ShutterFly SmartUpload 2.2 under wine.
     Quick description of SHutterFly :
http://appdb.winehq.org/objectManager.php?sClass=application&iId=5595

The major problem is that all the images and icons are corrupted. It
looks that apart from that, the application is usable, but clicking blind on
icons is not very productive.
      The first attachement is how the intro window looks like. The corruption
is quite obvious. The middle icon leads to the main upload window, the
screenshot in the second attachement also shows the corruption.
      The third attachement is the start of log of running the app.
      I got exactly the same results with 0.9.42 and 0.9.44.
      The ShutterFly app is free, send me an e-mail and I'll send you a copy
(3MB).

Thanks...

Jean

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

--- Comment #1 from Jean Tourrilhes   2007-09-21 00:10:55 ---
Created an attachment (id=8162)
 --> (http://bugs.winehq.org/attachment.cgi?id=8162)
Screenshot of the upload window

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

--- Comment #2 from Jean Tourrilhes   2007-09-21 00:11:26 ---
Created an attachment (id=8163)
 --> (http://bugs.winehq.org/attachment.cgi?id=8163)
Start of the rlog running Shutterfly

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

Jean Tourrilhes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://web1.shutterfly.com/d
                   |                            |ownloads/ShutterflySmartUplo
                   |                            |ad22.exe

--- Comment #3 from Jean Tourrilhes   2007-09-21 00:43:54 ---
The URL to download this version is :
http://web1.shutterfly.com/downloads/ShutterflySmartUpload22.exe

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
          Component|wine-directx                |wine-misc
     Ever Confirmed|0                           |1
           Keywords|                            |download

--- Comment #4 from Austin English   2007-09-21 10:01:37 ---
Confirming in wine 0.9.45.

Can you please try with native comctl32?

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

--- Comment #5 from Jean Tourrilhes   2007-09-21 11:30:57 ---
    Hi,

Thanks for fixing and confirming this bug so fast ;-)
> Can you please try with native comctl32?

I tried a quick google, but came empty. Do you have a quick pointer ? Also,
I blew up my Windows 2000 install a few weeks ago, and I guess I'll need to
find this dll somewhere. I may be able to get a WinXP version, would that work
?
    Thanks...

Jean

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

--- Comment #6 from Austin English   2007-09-21 12:18:45 ---
2K is preferable, but try XP if that's what you have. Make sure to set Windows
version to XP in winecfg. As for downloading it, that's legally questionable
depending on jurisdiction, and not always trustworthy.

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

--- Comment #7 from Jean Tourrilhes   2007-09-22 01:07:21 ---
> 2K is preferable, but try XP if that's what you have. Make sure to set Windows
> version to XP in winecfg.

I finally managed to find Win2k on an old drive.
> > I tried a quick google, but came empty. Do you have a quick pointer ?
>
> As for downloading it, that's legally questionable
> depending on jurisdiction, and not always trustworthy.

You misunderstood. I was just trying to find info on how to use the native
dll and configure stuff.
    Well, I finally found the info I was looking for :
http://www.winehq.org/site/docs/wineusr-guide/config-wine-main#WINECFG-DLL-O...
http://www.winehq.org/site/docs/wineusr-guide/x543
    But I must be dumb because it does not work. I installed my comctl32.dll in
the windows directory with the right permissions. I tried winecfg, but when I
select the dll, the add button remains gray, so I can not add the override. I
tried to use WINEDLLOVERRIDES, but it complained that it can not find the dll.

Regards,

Jean

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

--- Comment #8 from Jean Tourrilhes   2007-10-14 00:41:44 ---
    Hi,

I tried again with 0.9.46. Same results.

By the way, does anybody know what this means :
--------------------------------------
fixme:shell:IExtractIconW_fnExtract (0x13e0e88) (file=0x7da7ce44 index=-4
0x7da7c6e8 0x7da7c708 size=00100020) semi-stub
--------------------------------------
    I really have a ton of those...

Thanks in advance...

Jean

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

Henrik Steffen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Henrik Steffen   2007-11-22 05:03:20 ---
Hello!

Did anyone solve the problem? I run the app with native comctl32.dll, but no
success. I try to run with crossover and it works! But what's the difference?
Why does it work in Crossover, not in wine? I think both using the same code,
only the installer in Crossover is proprietary? My wine version is 0.9.49 and
crossover's cxoffice-6.2.0rc1-2-g024be42.

Best regards!

Stef

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

--- Comment #10 from Henrik Steffen   2007-11-22 10:22:02 ---
Sorry,I forgot to mention its a Debian system with a 2.6.24-rc2 kernel and wine
was installed out of a .deb build, downloaded from your apt-repository at
winehq.org.

Kind regards

Henrik

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|wine-misc                   |wine-x11driver

--- Comment #11 from Lei Zhang   2007-11-24 18:16:27 ---
crossover wine has some changes in dlls/winex11.drv/dib.c that fixes this
problem.

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

--- Comment #12 from Henrik Steffen   2007-11-25 08:18:06 ---
Great! Thanks! I compiled wine-0.9.34 with dib.c out of the crossover sources (
simply copied it in the wine-0.9.34 source tree) and it works! Nice!
 Why isn't this patch in the actual git-repository? Are there any other
negative successions?

Many,many thankS and best regards!

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

--- Comment #13 from Austin English   2007-11-25 14:32:50 ---
Crossover sometimes uses hacks and other improper implementations so that
programs will run, even though it isn't 'right'. These implementations are not
allowed in pure wine, so unless someone implements it properly, it won't get
in.

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

--- Comment #14 from Dmitry Timoshkov   2007-11-26 03:47:38 ---
(In reply to comment #11)
> crossover wine has some changes in dlls/winex11.drv/dib.c that fixes this
> problem.

How do you know that? Can you point to a particular change set?

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

--- Comment #15 from Lei Zhang   2007-11-26 12:24:10 ---
(In reply to comment #14)
> How do you know that? Can you point to a particular change set?

I looked at the differences between the crossover source and wine 0.9.34 and
eventually narrowed it down.

I can't point it to a particular change set because I don't have access to the
crossover git tree.

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

--- Comment #16 from Henrik Steffen   2007-11-26 14:22:21 ---
(In reply to comment #15)

Yes!Great work from Lei! I don't want to be annoying (please tell me if I do
so),  Why is the implemantation of how crossover handles bitmaps not a proper
one? If it works...

Okay, guys! Thanks for the last replies!

Best regards

Henrik

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

--- Comment #17 from Vitaliy Margolen   2007-11-26 15:37:51 ---
(In reply to comment #16)
> Yes!Great work from Lei! I don't want to be annoying (please tell me if I do
> so),  Why is the implemantation of how crossover handles bitmaps not a proper

You do.

Learn C, win32 API, and write some amount of code. Then you can tell anyone
what is correct and what is not.

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

--- Comment #18 from Dmitry Timoshkov   2007-11-27 00:01:06 ---
(In reply to comment #15)
> (In reply to comment #14)
> > How do you know that? Can you point to a particular change set?
>
> I looked at the differences between the crossover source and wine 0.9.34 and
> eventually narrowed it down.
> I can't point it to a particular change set because I don't have access to the
> crossover git tree.

There is no need to have an access to a crossover git tree. If you really
have idea what is causing the improvement show a diff or code snippet which
you believe makes the difference.

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

--- Comment #19 from Lei Zhang   2007-12-29 13:41:23 ---
Created an attachment (id=9883)
 --> (http://bugs.winehq.org/attachment.cgi?id=9883)
code from codeweaver's dib.c

Finally got around to it. This is the bit of code that fixes the bug.

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

--- Comment #20 from Henrik Steffen   2008-01-28 09:36:48 ---
Didn't have the time to say thanks to Lei. This patch works for me. In the
later versions of wine you have to change dib.c manually, but doesn't matter!
It works, though it might be not the right way as mentioned above.

Thanks!

Henrik

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Keywords|                            |patch

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

Petr Dlouhý  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #21 from Petr Dlouhý   2008-05-05 09:03:49 ---
Icons in plugin menu in Altap Salamander 2.51
(http://appdb.winehq.org/objectManager.php?sClass=version&iId=8311) are also
affected by this. It works after aplying the patch.

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #22 from Jeff Zaroyko   2008-10-04 22:01:22 ---
*** Bug 15511 has been marked as a duplicate of this bug. ***

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

Vincent Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

--- Comment #23 from Vincent Povirk   2009-03-23 17:48:20 ---
Huw, I've CC'd you because you made the change in CrossOver that Lei attached.
It's crossover wine commit 81e21fc4.

Is this a correct fix? Can it be sent to winehq?

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

--- Comment #24 from Andrew Nguyen   2010-05-31 05:35:56 ---
The condition persists in wine-1.2-rc2.

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

--- Comment #25 from Petr Dlouhý  2010-12-15 07:50:02 CST ---
The issue is fixed in Servant Salamander with Wine 1.3.9. Please retest with
ShutterFly.

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #26 from GyB  2012-02-12 04:18:34 CST ---
As for ShutterFly v2.2 the problem was fixed a long time ago (Wine-1.1.44 ->
1.2.3).

As for Altap Salamander the problem with the black icons is still present as of
Wine-1.4rc3 (if this is indeed the same problem that affected Shutterfly).

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #27 from Alexandre Julliard  2012-02-13 06:21:51 CST ---
If it works in Shutterfly then this is fixed. Please file new bugs for
remaining problems.

[Bug 9728] Image and icons corrupts in ShutterFly 2.2

http://bugs.winehq.org/show_bug.cgi?id=9728

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #28 from Alexandre Julliard  2012-02-17 13:51:05 CST ---
Closing bugs fixed in 1.4-rc4.