[Bug 48671] New: Some patches may require forcing a wineprefix update

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48671

Bug ID: 48671
           Summary: Some patches may require forcing a wineprefix update
           Product: Wine-Testbot
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

The TestBot updates the wineprefixes when it updates its base Wine source from
the daily Wine commits. The rest of the time it lets Wine deal with updating
the wineprefix is necessary. Furthermore Wine only updates the wineprefix when
wine.inf changes, which is the case for every Wine release.

The problem is that the wineprefix should also be updated when a patchset adds
a WINE_REGISTRY resource to an existing dll. Failing to do so may cause the
patchset tests to fail because the wineprefix is out of date.

See:
https://www.winehq.org/pipermail/wine-devel/2019-December/156914.html

WinePrefix updates are relatively slow compared to the execution time of most
tests (about 30s vs. < 1s) so it would be good not to have to do that for every
task. An alternative would be to force a wineprefix update when a task has
failures and gets rerun as a result (pass an option to the relevant VM-side
scripts).

Note: Shared Gecko and Mono install issues should be discussed on bug 48354.

[Bug 48671] Some patches may require forcing a wineprefix update

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48671

--- Comment #1 from François Gouget  ---
Would detecting changes to .rgs files and/or to WINE_REGISTRY lines catch most
of these issues? Because that's totally something that GetPatchImpacts() can
do.

[Bug 48671] Some patches may require forcing a wineprefix update

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48671

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P2                          |P3

[Bug 48671] Some patches may require forcing a wineprefix update

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48671

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from François Gouget  ---
Now that the TestBot supports shared Gecko and Mono installations, creating
wineprefixes is fast enough for it to not be necessary to create them in
advance.
This solves the wineprefix update issue.

commit e2888e5b253fee41bb4d77bdac3c61335050870b
Author: Francois Gouget 
Date:   Wed Jan 6 23:29:46 2021 +0100

testbot/WineReconfig: Do not prepare wineprefixes in advance.

This avoids test failures when the patch changes the initial Wine
    registry. Call CleanupWinePrefixes() after successful builds to ensure
    a clean transition and remove any stray wineprefix.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48671
    Signed-off-by: Francois Gouget 
    Signed-off-by: Alexandre Julliard

[Bug 48671] Some patches may require forcing a wineprefix update

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48671

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from François Gouget  ---
The wtbsuite has a test for this too.

Closing.