[Bug 55193] New: user32:sysparams - test_WM_DISPLAYCHANGE() fails on Windows 8

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55193

Bug ID: 55193
           Summary: user32:sysparams - test_WM_DISPLAYCHANGE() fails on
                    Windows 8
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: user32
          Assignee: [e-mail]
          Reporter: [e-mail]

user32:sysparams - test_WM_DISPLAYCHANGE() fails on Windows 8:

sysparams.c:2473: Test failed: ChangeDisplaySettingsExW returned -1
sysparams.c:2504: Tests skipped: bpp 8: ChangeDisplaySettingsExW returned -1
sysparams.c:2504: Tests skipped: bpp 16: ChangeDisplaySettingsExW returned -1
sysparams.c:2505: Test failed: bpp 16: ChangeDisplaySettingsExW returned -1
sysparams.c:2504: Tests skipped: bpp 24: ChangeDisplaySettingsExW returned -1
sysparams.c:2505: Test failed: bpp 24: ChangeDisplaySettingsExW returned -1
sysparams.c:2523: Test failed: ChangeDisplaySettingsExW returned -1

See https://test.winehq.org/data/patterns.html#user32:sysparams

Where -1 == DISP_CHANGE_FAILED (so not very helpful)

This is systematic and impacts the two TestBot Windows 8 VMs.

Also this check does not make sense: broken( DISP_CHANGE_FAILED && bpp == 8 )
and given that we get this res value for all bpps, maybe it should be:
broken( res == DISP_CHANGE_FAILED )

[Bug 55193] user32:sysparams - test_WM_DISPLAYCHANGE() fails on Windows 8

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55193

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source, testcase

[Bug 55193] user32:sysparams - test_WM_DISPLAYCHANGE() fails on Windows 8

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55193

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]

[Bug 55193] user32:monitor causes test_WM_DISPLAYCHANGE() to fail in user32:sysparams on Windows 8

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55193

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|user32:sysparams -          |user32:monitor causes
                   |test_WM_DISPLAYCHANGE()     |test_WM_DISPLAYCHANGE() to
                   |fails on Windows 8          |fail in user32:sysparams on
                   |                            |Windows 8
           Assignee|[e-mail]     |[e-mail]

--- Comment #1 from François Gouget  ---
These failures only happen if user32:monitor is run before user32:sysparams so
I updated the summary accordingly.

This also means there may be hope for figuring out why the failure happens and
avoiding the broken() case. In the meantime I sent a patch to add the missing
'res =='.