[Bug 55797] New: Max Payne (2001) has no sound

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55797

Bug ID: 55797
           Summary: Max Payne (2001) has no sound
           Product: Wine
           Version: 8.18
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 75284
  --> https://bugs.winehq.org/attachment.cgi?id=75284
terminal output

No sound in Max Payne. The issue appeared with the 8.17 update and still
persists in 8.18. Applies to both PulseAudio and plain ALSA. "winetricks dsound
d3dx9 directmusic directplay" used to solve the problem on 8.17, but not
anymore.

[Bug 55797] Max Payne (2001) has no sound

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55797

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://archive.org/details
                   |                            |/MaxPayneDemo
                 CC|                            |[e-mail]
           Keywords|                            |download, regression

--- Comment #1 from Béla Gyebrószki  ---
As far as I can see, the demo version also has this bug with the small addition
on my part that it appears for the first time in Wine-8.16.
In any case, could you please do the regression test to find out which commit
is causing the error? 
https://wiki.winehq.org/Regression_Testing

Ah, and please don't install native dsound, directmusic etc. dlls while doing
the regression test. They can only confuse the test result. By the way the game
should work properly without them.

MaxPayneDemo.exe (131 MB)
md5sum: d47bc877b1348aa8dd0df18a38392809

[Bug 55797] Max Payne (2001) has no sound

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55797

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |e1f0318ec4fe83fdc86407303d5
                   |                            |5f4ee5ba3d2e7
                 CC|                            |[e-mail]
            Version|8.18                        |8.16
          Component|-unknown                    |dsound

--- Comment #2 from Béla Gyebrószki  ---
I did the bisect myself because this bug affects multiple titles.
In addition to Max Payne 1 and 2, lots if not all the games made with Adventure
Game Studio also have no audio (e.g. King's Quest 1 Remake, Whispers of a
Machine).

Bisecting resulted in
commit e1f0318ec4fe83fdc86407303d55f4ee5ba3d2e7
dsound: Get rid of the global device GUID arrays.

They are not used for anything anymore and just impose limit of 10
    devices of a given type (capturer / renderer) without doing bound
    checking.

Reverting the patch on top of current git fixes the problem for me.

See also bug #55608 with the same commit ID.

Tested with wine-8.18-155-g9afcf7c8e0c

[Bug 55797] Max Payne (2001) has no sound

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55797

--- Comment #3 from Arek Hiler  ---
https://gitlab.winehq.org/wine/wine/-/merge_requests/4147

[Bug 55797] Max Payne (2001) has no sound

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55797

--- Comment #4 from Béla Gyebrószki  ---
(In reply to Arek Hiler from comment #3)
> https://gitlab.winehq.org/wine/wine/-/merge_requests/4147

The patch fixes the problem for me.

[Bug 55797] Max Payne (2001) has no sound

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55797

--- Comment #5 from Béla Gyebrószki  ---
Sounds work again for me in the affected games including Max Payne.
Tested with current git master: wine-8.19-362-g01d7780a0f7

https://source.winehq.org/git/wine.git/commit/73654470abd9dc3094e3270df592c2...

@heshkn: care to retest? The upcoming Wine-8.20 would contain the fix.

[Bug 55797] Max Payne (2001) has no sound

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55797

Alex Henrie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
           See Also|                            |https://bugs.winehq.org/sho
                   |                            |w_bug.cgi?id=55608
                 CC|                            |[e-mail]
             Status|UNCONFIRMED                 |RESOLVED
      Fixed by SHA1|                            |73654470abd9dc3094e3270df59
                   |                            |2c214be4c7c15

--- Comment #6 from Alex Henrie  ---
Fixed by:

https://gitlab.winehq.org/wine/wine/-/commit/73654470abd9dc3094e3270df592c21...
https://gitlab.winehq.org/wine/wine/-/commit/5a81b6ac43e1057c0c6f9953fd5cbb1...

[Bug 55797] Max Payne (2001) has no sound

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55797

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 8.20.