[Bug 41228] New: Rendering is messed up on WineD3D8 for Windows

https://bugs.winehq.org/show_bug.cgi?id=41228

Bug ID: 41228
           Summary: Rendering is messed up on WineD3D8 for Windows
           Product: Wine
           Version: 1.9.17
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 55501
  --> https://bugs.winehq.org/attachment.cgi?id=55501
Screenshot of the problem

Right before the commit leading to bug 41224 there was another commit:

commit c92451f295242110bf016facf0e80564f3643d94
Author: Henri Verbeet 
Date:   Wed Nov 4 00:02:48 2015 +0100

wined3d: Always use the same formats in context_create() when
"always_offscreen" is enabled.

Signed-off-by: Henri Verbeet 
    Signed-off-by: Alexandre Julliard

This commit leads to broken rendering in GTAVC when run in Windows.
I've not tested any later version for whether it's fixed, since bug 41224
blocks testing.

[Bug 41228] Rendering is messed up on WineD3D8 for Windows

https://bugs.winehq.org/show_bug.cgi?id=41228

--- Comment #1 from Ruslan Kabatsayev  ---
Created attachment 55502
  --> https://bugs.winehq.org/attachment.cgi?id=55502
How it should look

[Bug 41228] Rendering is messed up on WineD3D8 for Windows

https://bugs.winehq.org/show_bug.cgi?id=41228

Ruslan Kabatsayev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
    Regression SHA1|                            |c92451f295242110bf016facf0e
                   |                            |80564f3643d94
           Keywords|                            |regression

[Bug 41228] Rendering is messed up on WineD3D8 for Windows

https://bugs.winehq.org/show_bug.cgi?id=41228

Ruslan Kabatsayev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #2 from Ruslan Kabatsayev  ---
OK, this appears fixed in current git+reverted commit
b53256b8b752855576252cc2290dfbc9cb0f1280 from bug 41224.

[Bug 41228] Rendering is messed up on WineD3D8 for Windows

https://bugs.winehq.org/show_bug.cgi?id=41228

Ruslan Kabatsayev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|Linux                       |Windows

[Bug 41228] Rendering is messed up on WineD3D8 for Windows

https://bugs.winehq.org/show_bug.cgi?id=41228

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from [e-mail] ---
(In reply to Ruslan Kabatsayev from comment #2)
> OK, this appears fixed in current git+reverted commit
> b53256b8b752855576252cc2290dfbc9cb0f1280 from bug 41224.

Call me crazy but having to revert a commit doesn't really fix things, no?

[Bug 41228] Rendering is messed up on WineD3D8 for Windows

https://bugs.winehq.org/show_bug.cgi?id=41228

--- Comment #4 from Ruslan Kabatsayev  ---
(In reply to fjfrackiewicz from comment #3)
> Call me crazy but having to revert a commit doesn't really fix things, no?

I reverted the commit which blocked testing, not the one which introduced this
bug. I didn't touch the commit which introduced this bug.

[Bug 41228] Rendering is messed up on WineD3D8 for Windows

https://bugs.winehq.org/show_bug.cgi?id=41228

--- Comment #5 from Bruno Jesus  ---
Sorry, I don't understand why do you say the bug is fixed. Is the problem
present in wine-git without any patch reversions?

[Bug 41228] Rendering is messed up on WineD3D8 for Windows

https://bugs.winehq.org/show_bug.cgi?id=41228

--- Comment #6 from Ruslan Kabatsayev  ---
(In reply to Bruno Jesus from comment #5)
> Sorry, I don't understand why do you say the bug is fixed. Is the problem
> present in wine-git without any patch reversions?

Without reversions, the problem is untestable: the app crashes before even
showing anything on screen. But the commit which leads to the bug blocking
testing is unrelated. Here's how the changes go:

1. Commit A breaks rendering (this bug)
2. Commit B causes crashes (bug 41224)
3. ... some development ...
4. Commit C fixes rendering (but this is untestable due to 2.)
5. ... some development ...
6. I revert commit B and see that A is no longer reproducible — concluding that
this bug is fixed.

[Bug 41228] Rendering is messed up on WineD3D8 for Windows

https://bugs.winehq.org/show_bug.cgi?id=41228

--- Comment #7 from Bruno Jesus  ---
Ok, thanks for the detailed explanation =)

[Bug 41228] Rendering is messed up on WineD3D8 for Windows

https://bugs.winehq.org/show_bug.cgi?id=41228

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.18.