[Bug 20806] New: Civilization II crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=20806

Summary: Civilization II crashes on startup
           Product: Wine
           Version: 1.1.33
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: gdi32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=24919)
 --> (http://bugs.winehq.org/attachment.cgi?id=24919)
Civilization II backtrace

With wine-1.1.33-301-gd963e97, Civilization II crashes with:

fixme:wing:WinGGetDIBPointer16 6b8, (nil): not supported
wine: Unhandled page fault on read access to 0xffffffff at address
0x1417:0x0000021a (thread 001c), starting debugger...
Unhandled exception: page fault on read access to 0xffffffff in 16-bit code
(1417:021a).
...

Since this did not occur in 1.1.29, a regression test was performed, which
showed:

6ad951804a2188dc0614ae0b9bd18e843937e8d3 is the first bad commit
commit 6ad951804a2188dc0614ae0b9bd18e843937e8d3
Author: Alexandre Julliard 
Date:   Sat Sep 26 13:32:25 2009 +0200

gdi32: Make wing.dll into a stand-alone 16-bit module.

:100644 100644 418244e96b0cb9af6c7df68bb9672fdba2f22057
f439b356d3dfcd102c2c57bfdd305aec7e51e08d M    .gitignore
:100755 100755 6a76027b8696730d320ef676e0b9b0d791457953
5372518cf20852bddda590c6616c1a303dbb232e M    configure
:100644 100644 175b051bad723f1f5b14afabc57d6038c448b75f
faf891df33ba999eacd591a57f0a6e3475381e55 M    configure.ac
:040000 040000 7037a30347a8adf0775b3158c964cf213bb48aeb
156c989d78f1343a55d0b07e80f071d0e0db131c M    dlls

It looks like the removal of the WinGGetDIBPointer16 implementation makes
Civilization II unhappy. Full output is attached.

[Bug 20806] Civilization II crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=20806

Andrew Nguyen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 20806] Civilization II crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=20806

--- Comment #1 from Alexandre Julliard   2009-11-23 08:13:12 ---
Created an attachment (id=24920)
 --> (http://bugs.winehq.org/attachment.cgi?id=24920)
Reimplement WinGGetDIBPointer16.

Great, so we still need to support that broken dll. Give this a try.

[Bug 20806] Civilization II crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=20806

--- Comment #2 from Andrew Nguyen   2009-11-23 21:24:06 ---
Thanks, the patch works when applied directly on top of the "bad" commit. With
the current Git (wine-1.1.33-358-gddaf238), Civilization II runs into an
unrelated winmm regression, the subject of a new bug.

[Bug 20806] Civilization II crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=20806

--- Comment #3 from Nikolay Sivov   2009-12-11 05:25:28 ---
(In reply to comment #1)
> Created an attachment (id=24920)

--> (http://bugs.winehq.org/attachment.cgi?id=24920) [details]
> Reimplement WinGGetDIBPointer16.

This patch is in as commit 92cd5a5c6bae3cd018187f6b1df01eeb74e6e152.
Is this fixed?

[Bug 20806] Civilization II crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=20806

--- Comment #4 from Wylda   2009-12-11 18:27:41 ---
Created an attachment (id=25174)
 --> (http://bugs.winehq.org/attachment.cgi?id=25174)
Sid Mayer's civilization 2

(In reply to comment #3)
> This patch is in as commit 92cd5a5c6bae3cd018187f6b1df01eeb74e6e152.
> Is this fixed?

I'm not able to get this game running. Winecfg set to 3.1 and latest git
(1.1.34-309-g9352509) and also 1.1.29 crash during the startup.

AppDB also says quality = garbage in this case.

During an install process i got message (probably should be separate bug
report):

fixme:edit:EditWndProc_common undocumented message 0x40f, please report

[Bug 20806] Civilization II crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=20806

Andrew Nguyen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Andrew Nguyen   2009-12-11 19:58:12 ---
You're probably running into bug 20816. This particular bug is indeed fixed;
thanks for reminding me.

[Bug 20806] Civilization II crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=20806

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard   2009-12-18 13:07:58 ---
Closing bugs fixed in 1.1.35.