[Bug 46885] New: Regression in Office 2007 install after msi change in current master

https://bugs.winehq.org/show_bug.cgi?id=46885

Bug ID: 46885
           Summary: Regression in Office 2007 install after msi change in
                    current master
           Product: Wine
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: msi
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 63961
  --> https://bugs.winehq.org/attachment.cgi?id=63961
wine log with +msi

Installation of Office 2007 aborts shortly after start without a meaningful
error message in current master

A bisect shows this patch as bad:

15f852015a0332313821804cc1fbad79216408c6 is the first bad commit
commit 15f852015a0332313821804cc1fbad79216408c6
Author: Hans Leidekker 
Date:   Wed Mar 20 09:43:44 2019 +0100

msi: Disable filesystem redirection only when really needed.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46846
    Signed-off-by: Hans Leidekker 
    Signed-off-by: Alexandre Julliard

Reverting this patch fixes the issue for me.

[Bug 46885] Regression in Office 2007 install after msi change in current master

https://bugs.winehq.org/show_bug.cgi?id=46885

Ulrich Gemkow  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
    Regression SHA1|                            |15f852015a0332313821804cc1f
                   |                            |bad79216408c6

[Bug 46885] Regression in Office 2007 install after msi change in current master

https://bugs.winehq.org/show_bug.cgi?id=46885

--- Comment #1 from Hans Leidekker  ---
Created attachment 63966
  --> https://bugs.winehq.org/attachment.cgi?id=63966
patch

This patch should fix it.

[Bug 46885] Regression in Office 2007 install after msi change in current master

https://bugs.winehq.org/show_bug.cgi?id=46885

--- Comment #2 from Ulrich Gemkow  ---
This patch fixes the problem. Thank you very much!

[Bug 46885] Multiple applications fail to install with wine-4.4-114-g15f852015a+, reporting err:msi:ITERATE_Actions Execution halted, action L"BindImage" returned 1615 (MS Office 2007, AstroToaster 2.x)

https://bugs.winehq.org/show_bug.cgi?id=46885

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Regression in Office 2007   |Multiple applications fail
                   |install after msi change in |to install with
                   |current master              |wine-4.4-114-g15f852015a+,
                   |                            |reporting
                   |                            |err:msi:ITERATE_Actions
                   |                            |Execution halted, action
                   |                            |L"BindImage" returned 1615
                   |                            |(MS Office 2007,
                   |                            |AstroToaster 2.x)
                 CC|                            |[e-mail]
                URL|                            |http://www.astrotoaster.com
                   |                            |/download/SetupAstroToaster
                   |                            |_205a.msi?attredirects=0
           Keywords|                            |download, Installer
             Status|UNCONFIRMED                 |NEW
            Version|unspecified                 |4.4
     Ever confirmed|0                           |1

--- Comment #3 from Anastasius Focht  ---
Hello folks,

confirming, found a couple of installers that are affected as well.

http://www.astrotoaster.com/download/SetupAstroToaster_205a.msi?attredirects...

--- snip ---
$ WINEDEBUG=+seh,+relay,+msi wine msiexec -i SetupAstroToaster_205a.msi
> > log.txt 2>&1

002a:trace:msi:ACTION_PerformAction Performing action (L"BindImage") 
...
002a:Call KERNEL32.WideCharToMultiByte(00000000,00000000,0020a1b0 L"Action
start 12:47:22: BindImage.",ffffffff,00212268,00000022,00000000,00000000)
ret=7e941b7d 
...
002a:trace:msi:MSI_DatabaseOpenViewW L"SELECT * FROM BindImage" 0x33f388 
...
002a:trace:msi:MSI_ParseSQL Parse returned 1
...
002a:trace:msi:MSI_DatabaseOpenViewW L"SELECT `Message` FROM `Error` WHERE
`Error` = 15" 0x33f318 
...
002a:Call KERNEL32.WideCharToMultiByte(00000000,00000000,0020a1b0 L"Action
ended 12:47:22: BindImage. Return value
0.",ffffffff,00000000,00000000,00000000,00000000) ret=7e941b4f
002a:Ret  KERNEL32.WideCharToMultiByte() retval=00000032 ret=7e941b4f 
...
002a:err:msi:ITERATE_Actions Execution halted, action L"BindImage" returned
1615 
...
--- snip --

Refining the summary to reflect this, including the exact git version that
started it.

$ sha1sum SetupAstroToaster_205a.msi 
668be4420c4bf3ea809de043f5453998a082df87  SetupAstroToaster_205a.msi

$ du -sh SetupAstroToaster_205a.msi 
8.7M    SetupAstroToaster_205a.msi

$ wine --version
wine-4.4-188-gc988910cae

Regards

[Bug 46885] Multiple applications fail to install with wine-4.4-114-g15f852015a+, reporting err:msi:ITERATE_Actions Execution halted, action L"BindImage" returned 1615 (MS Office 2007, AstroToaster 2.x. MS .NET Framework 4.x)

https://bugs.winehq.org/show_bug.cgi?id=46885

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Multiple applications fail  |Multiple applications fail
                   |to install with             |to install with
                   |wine-4.4-114-g15f852015a+,  |wine-4.4-114-g15f852015a+,
                   |reporting                   |reporting
                   |err:msi:ITERATE_Actions     |err:msi:ITERATE_Actions
                   |Execution halted, action    |Execution halted, action
                   |L"BindImage" returned 1615  |L"BindImage" returned 1615
                   |(MS Office 2007,            |(MS Office 2007,
                   |AstroToaster 2.x)           |AstroToaster 2.x. MS .NET
                   |                            |Framework 4.x)

[Bug 46885] Multiple applications fail to install with wine-4.4-114-g15f852015a+, reporting err:msi:ITERATE_Actions Execution halted, action L"BindImage" returned 1615 (MS Office 2007, AstroToaster 2.x. MS .NET Framework 4.x)

https://bugs.winehq.org/show_bug.cgi?id=46885

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |a3dfd2f251f336f1cc570863edb
                   |                            |60251227cdf5d
             Status|NEW                         |RESOLVED

--- Comment #4 from Anastasius Focht  ---
Hello folks,

this is fixed by commit
https://source.winehq.org/git/wine.git/commitdiff/a3dfd2f251f336f1cc570863ed...
("msi: Don't fail the BindImage action if the BindImage table is absent.")

Tested with 'winetricks -q dotnet472' (which includes several .NET 4.x
recipes).

Thanks Zebediah

Regards

[Bug 46885] Multiple applications fail to install with wine-4.4-114-g15f852015a+, reporting err:msi:ITERATE_Actions Execution halted, action L"BindImage" returned 1615 (MS Office 2007, AstroToaster 2.x. MS .NET Framework 4.x)

https://bugs.winehq.org/show_bug.cgi?id=46885

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 4.5.