[Bug 48739] New: ConEmu fails to set IGNORE_OFFLINE and shows error dialog at startup

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48739

Bug ID: 48739
           Summary: ConEmu fails to set IGNORE_OFFLINE and shows error
                    dialog at startup
           Product: Wine
           Version: 5.3
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: wininet
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

ConEmu shows error dialog at startup indicating that setting
INTERNET_OPTION_IGNORE_OFFLINE with InternetSetOptionW() was unsuccessful. The
option is unsupported yet. Silently ignore that flag would help. It is a minor
issue.

[Bug 48739] ConEmu fails to set IGNORE_OFFLINE and shows error dialog at startup

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48739

Roman Pišl  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://conemu.github.io/
           Keywords|                            |download
                 CC|                            |[e-mail]

[Bug 48739] ConEmu fails to set IGNORE_OFFLINE and shows error dialog at startup

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48739

--- Comment #1 from Roman Pišl  ---
Patch sent: https://source.winehq.org/patches/data/180724. ConEmu is still
evolving, so this is needed for version 191012.

[Bug 48739] ConEmu fails to set IGNORE_OFFLINE and shows error dialog at startup

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48739

Roman Pišl  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |6fcd1378b2516165468bcbd7126
                   |                            |3c1b18c6be491
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #2 from Roman Pišl  ---
Confirming fixed by
https://source.winehq.org/git/wine.git/commit/6fcd1378b2516165468bcbd71263c1...,
thanks!

[Bug 48739] ConEmu (Windows console emulator) v19.10.12 fails to set Wininet's INTERNET_OPTION_IGNORE_OFFLINE and shows error dialog at startup

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48739

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                URL|https://conemu.github.io/   |https://github.com/Maximus5
                   |                            |/ConEmu/releases/download/v
                   |                            |19.10.12/ConEmuSetup.191012
                   |                            |.exe
            Summary|ConEmu fails to set         |ConEmu (Windows console
                   |IGNORE_OFFLINE and shows    |emulator) v19.10.12 fails
                   |error dialog at startup     |to set Wininet's
                   |                            |INTERNET_OPTION_IGNORE_OFFL
                   |                            |INE and shows error dialog
                   |                            |at startup
           Keywords|                            |source

--- Comment #3 from Anastasius Focht  ---
Hello Roman,

good work! I've added the app version you've tested with to the summary line.
This is in case they change that piece of code at some point.

Link to the source snippet as of v19.10.12:

https://github.com/Maximus5/ConEmu/blob/v19.10.12/src/ConEmuC/Downloader.cpp...

--- snip ---
            // Force Online
            ReportMessage(dc_LogCallback, L"Set IGNORE_OFFLINE option",
at_None);
            nFlags = TRUE; _ASSERTE(sizeof(nFlags)==4);
            if (!wi->_InternetSetOptionW(mh_Internet,
INTERNET_OPTION_IGNORE_OFFLINE, &nFlags, sizeof(nFlags)))
            {
                ReportMessage(dc_ErrCallback,
                    L"Set IGNORE_OFFLINE option, code=%u", at_Uint,
GetLastError(), at_None);
                //goto wrap;
}
--- snip ---

Regards

[Bug 48739] ConEmu (Windows console emulator) v19.10.12 fails to set Wininet's INTERNET_OPTION_IGNORE_OFFLINE and shows error dialog at startup

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48739

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 5.5.

[Bug 48739] ConEmu (Windows console emulator) v19.10.12 fails to set Wininet's INTERNET_OPTION_IGNORE_OFFLINE and shows error dialog at startup

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48739

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |5.0.x

[Bug 48739] ConEmu (Windows console emulator) v19.10.12 fails to set Wininet's INTERNET_OPTION_IGNORE_OFFLINE and shows error dialog at startup

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48739

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|5.0.x                       |---

--- Comment #5 from Michael Stefaniuc  ---
Removing the 5.0.x milestone from bug fixes included in 5.0.2.