[Bug 57810] New: ITextStream::WriteBlankLines() needs to be implemented for libxml2's configure.js to work

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57810

Bug ID: 57810
           Summary: ITextStream::WriteBlankLines() needs to be implemented
                    for libxml2's configure.js to work
           Product: Wine
           Version: unspecified
          Hardware: x86-64
               URL: https://github.com/GNOME/libxml2
                OS: FreeBSD
            Status: NEW
          Keywords: download, source
          Severity: normal
          Priority: P2
         Component: scrrun
          Assignee: [e-mail]
          Reporter: [e-mail]

In libxml2's win32 subdirectory, running "wine cscript configure.js" fails
with:

0330:fixme:scrrun:textstream_WriteBlankLines 008EF44C, 1 stub
0330:trace:jscript:handle_dispatch_exception 80004001 (null) (null)
0330:warn:jscript:unwind_exception Exception 80020009 undefined in:
0330:warn:jscript:print_backtrace 0    L"discoverVersion"() context 1 line 207
char 1
0330:warn:jscript:print_backtrace 1    [unnamed]([detached frame]) context 1
line 606 char 0
0330:warn:jscript:print_backtrace 2    [native code]

because in that "discoverVersion()" function called from configure.js line 207
here:

https://github.com/GNOME/libxml2/blob/3dcde736d012a191cca60e5d5dbd80ef971768...

---snip---
        vf.WriteBlankLines(1);
---snip---

which is implemented in dlls/scrrun/filesystem.c function
textstream_WriteBlankLines(), which is indeed a stub returning E_NOTIMPL.

Patching textstream_WriteBlankLines() to write newlines and return S_OK fixes
the bug, and "wine cscript configure.js" runs to successful completion.

I will make a merge request soon.

This is why dog food bugs rule - when all the code is open source, debugging is
so easy ;-).

[Bug 57810] ITextStream::WriteBlankLines() needs to be implemented for libxml2's configure.js to work

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57810

--- Comment #1 from Nikolay Sivov  ---
Is there a practical use case for this? Is this useful for building libxml2
with msvc, running under wine?

[Bug 57810] ITextStream::WriteBlankLines() needs to be implemented for libxml2's configure.js to work

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57810

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |10.1

[Bug 57810] ITextStream::WriteBlankLines() needs to be implemented for libxml2's configure.js to work

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57810

--- Comment #2 from Damjan Jovanovic  ---
(In reply to Nikolay Sivov from comment #1)
> Is there a practical use case for this? Is this useful for building libxml2
> with msvc, running under wine?

I am trying to compile the Windows build of Apache OpenOffice under Wine +
Cygwin + MS Platform SDK, and libxml2 is one of the dependencies compiled as
part of that build, and this is one of the bugs that breaks it. Bug 57795 is
another.

[Bug 57810] ITextStream::WriteBlankLines() needs to be implemented for libxml2's configure.js to work

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57810

--- Comment #3 from Nikolay Sivov  ---
I see, thanks for the fix.

[Bug 57810] ITextStream::WriteBlankLines() needs to be implemented for libxml2's configure.js to work

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57810

Damjan Jovanovic  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |64e3fc2d7dd9303d61525f0e4e4
                   |                            |28a7691e9bf98
             Status|NEW                         |RESOLVED

--- Comment #4 from Damjan Jovanovic  ---
https://gitlab.winehq.org/wine/wine/-/merge_requests/7289 has been merged,
resolving fixed.

[Bug 57810] ITextStream::WriteBlankLines() needs to be implemented for libxml2's configure.js to work

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57810

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 10.2.