[Bug 28767] New: shell32: uninitialized memory used during TRASH_EnumItems, triggered by "make recyclebin.ok"

http://bugs.winehq.org/show_bug.cgi?id=28767

Bug #: 28767
           Summary: shell32: uninitialized memory used during
                    TRASH_EnumItems, triggered by "make recyclebin.ok"
           Product: Wine
           Version: 1.3.30
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: shell32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Running "make recyclebin.ok" in shell32/tests, valgrind complains

Conditional jump or move depends on uninitialised value(s)
   at __mktime_internal (mktime.c:428)
   by mktime (mktime.c:518)
   by TRASH_EnumItems (trash.c:444)
   by SHQueryRecycleBinW (recyclebin.c:859)
   by SHQueryRecycleBinA (recyclebin.c:848)
   by test_query_recyclebin (recyclebin.c:74)
   by func_recyclebin (recyclebin.c:106)
   by run_test (test.h:556)
   by main (test.h:624)
 Uninitialised value was created by a stack allocation
   at TRASH_EnumItems (trash.c:506)

Looks like not all the fields of del_time got initialized?

47b40c58 (Mikołaj Zalewski   2006-08-17 18:29:58 +0200 444)         del_secs =
mktime(&del_time);

[Bug 28767] shell32: uninitialized memory used during TRASH_EnumItems, triggered by "make recyclebin.ok"

https://bugs.winehq.org/show_bug.cgi?id=28767

--- Comment #1 from Austin English  ---
 Conditional jump or move depends on uninitialised value(s)
    at  __mktime_internal (mktime.c:185)
    by  mktime (mktime.c:591)
    by  TRASH_GetDetails (trash.c:518)
    by  TRASH_EnumItems (trash.c:597)
    by  SHQueryRecycleBinW (recyclebin.c:866)
    by  SHQueryRecycleBinA (recyclebin.c:855)
    by  test_query_recyclebin (recyclebin.c:74)
    by  func_recyclebin (recyclebin.c:106)
    by  run_test (test.h:584)
    by  main (test.h:654)
  Uninitialised value was created by a stack allocation
    at  TRASH_GetDetails (trash.c:441)

and a few similar ones, still in git.

[Bug 28767] shell32: uninitialized memory used during TRASH_EnumItems, triggered by "make recyclebin.ok"

https://bugs.winehq.org/show_bug.cgi?id=28767

--- Comment #2 from Austin English  ---
That's bug 28824, this one is fixed.

[Bug 28767] shell32: uninitialized memory used during TRASH_EnumItems, triggered by "make recyclebin.ok"

https://bugs.winehq.org/show_bug.cgi?id=28767

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Austin English  ---
That's bug 28824, this one is fixed.

[Bug 28767] shell32: uninitialized memory used during TRASH_EnumItems, triggered by "make recyclebin.ok"

https://bugs.winehq.org/show_bug.cgi?id=28767

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.18.