[Bug 53003] New: XM6 TypeG: some MIDI note-on messages aren't sent to MIDI devices (MIDI running status isn't supported in the MIDI mapper)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53003

Bug ID: 53003
           Summary: XM6 TypeG: some MIDI note-on messages aren't sent to
                    MIDI devices (MIDI running status isn't supported in
                    the MIDI mapper)
           Product: Wine
           Version: 7.8
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: winmm&mci
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: Ubuntu

Created attachment 72371
  --> https://bugs.winehq.org/attachment.cgi?id=72371
minimal reproducible example

XM6 TypeG[1] is a SHARP X68000 Emulator.
When I use STed2[2] inside XM6 TypeG, some MIDI note-on messages aren't sent to
MIDI devices (e.g. Timidity++).

@honda_ken, an original reporter on Twitter, tweeted XM6 TypeG sounds strange
on Wine. He also informed me that Wine outputs the following message on his
console:
0338:fixme:midi:modData ooch 3c
0338:fixme:midi:modData ooch 403e
0338:fixme:midi:modData ooch 3e
0338:fixme:midi:modData ooch 4040
0338:fixme:midi:modData ooch 40
0338:fixme:midi:modData ooch 4041
0338:fixme:midi:modData ooch 41
0338:fixme:midi:modData ooch 4043
0338:fixme:midi:modData ooch 43

I setup XM6 TypeG environment on my PC and I can reproduce the issue.
Preparing the environment is a bit difficult, I wrote a minimal reproducible
example (shortmsg.c).

Steps to reproduce:
1. Compile the source code.
   % i686-w64-mingw32-gcc -o shortmsg.exe shortmsg.c -lwinmm
2. Setup your favorite MIDI device, e.g. Timidity++.
   % timidity -iA &
3. Run the executable (argument -1 means we use the MIDI mapper).
   % wine shortmsg.exe -1

Expected result:
We can hear the piano voice, C, D, E and F.

Actual result:
We can hear the piano voice, only C.

[1] http://retropc.net/pi/xm6/index.html
[2] http://retropc.net/x68000/software/sound/rc/sted2/

[Bug 53003] XM6 TypeG: some MIDI note-on messages aren't sent to MIDI devices (MIDI running status isn't supported in the MIDI mapper)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53003

Sagawa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

--- Comment #1 from Sagawa  ---
I'm working on this issue.
These fixme messages come from midiOutShortMsg() and it should support the
running status.
See midiOutShortMsg's document[1] for details.

[1]
https://docs.microsoft.com/en-us/windows/win32/api/mmeapi/nf-mmeapi-midiouts...

[Bug 53003] XM6 TypeG: some MIDI note-on messages aren't sent to MIDI devices (MIDI running status isn't supported in the MIDI mapper)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53003

Sagawa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |testcase

[Bug 53003] XM6 TypeG: some MIDI note-on messages aren't sent to MIDI devices (MIDI running status isn't supported in the MIDI mapper)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53003

--- Comment #2 from Sagawa  ---
I sent a patch, https://source.winehq.org/patches/data/236912 .

[Bug 53003] XM6 TypeG: some MIDI note-on messages aren't sent to MIDI devices (MIDI running status isn't supported in the MIDI mapper)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53003

Sagawa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
      Fixed by SHA1|                            |4c535a7f7546f2dfe504c47dfc4
                   |                            |16d3cdd0a5ab0
         Resolution|---                         |FIXED

--- Comment #3 from Sagawa  ---
It fixed by 4c535a7f7546f2dfe504c47dfc416d3cdd0a5ab0 .

Another MIDI driver, e.g. winealsa.drv, couldn't handle the running status,
too. They also fixed recently.

[Bug 53003] XM6 TypeG: some MIDI note-on messages aren't sent to MIDI devices (MIDI running status isn't supported in the MIDI mapper)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53003

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 7.10.

[Bug 53003] XM6 TypeG: some MIDI note-on messages aren't sent to MIDI devices (MIDI running status isn't supported in the MIDI mapper)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53003

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |7.0.x

[Bug 53003] XM6 TypeG: some MIDI note-on messages aren't sent to MIDI devices (MIDI running status isn't supported in the MIDI mapper)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53003

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|7.0.x                       |---

--- Comment #5 from Michael Stefaniuc  ---
Removing the 7.0.x milestone from bug fixes included in 7.0.2.