[Bug 40344] New: shell32:assoc regression (privilege issue)

https://bugs.winehq.org/show_bug.cgi?id=40344

Bug ID: 40344
           Summary: shell32:assoc regression (privilege issue)
           Product: Wine
           Version: 1.9.3
          Hardware: x86
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: shell32
          Assignee: [e-mail]
          Reporter: [e-mail]

The commit below introduces new failures / crashes when it is run without
elevated privileges.

For instance the fg-win7u64-1spie9adm (Widnows 7 Ultimate, administrator
account without elevated privileges) and fg-win7u64-1spie9usr VMs (same but in
regular user account) gets 4 new failures and a crash:
assoc.c:153: Test failed: RegCreateKeyExW(HKCR, ".test") failed: 0x5
assoc.c:155: Test failed: RegSetValueExW(HKCR.test, NULL, "testfile") failed:
0x6
assoc.c:159: Test failed: RegCreateKeyExW(HKCR, "testfile") failed: 0x5
assoc.c:113: Test failed: line 162: IQueryAssociations::Init failed, 0x80070057
assoc.c:113: this is the last test seen before the exception
assoc: unhandled exception c0000005 at 75EFE3E6
test failed: crash

While the fg-winxp-lusr VM (Windows XP SP3+Limited user account) gets 17 new
failures:
assoc.c:153: Test failed: RegCreateKeyExW(HKCR, ".test") failed: 0x5
assoc.c:155: Test failed: RegSetValueExW(HKCR.test, NULL, "testfile") failed:
0x6
assoc.c:159: Test failed: RegCreateKeyExW(HKCR, "testfile") failed: 0x5
assoc.c:113: Test failed: line 160: IQueryAssociations::Init failed, 0x1
assoc.c:113: Test failed: line 161: IQueryAssociations::Init failed, 0x1
assoc.c:113: Test failed: line 162: IQueryAssociations::Init failed, 0x80070057
assoc.c:166: Test failed: RegCreateKeyExW(HKCR\testfile\DefaultIcon) failed:
0x6
assoc.c:168: Test failed: RegSetValueExW(HKCR\testfile\DefaultIcon, NULL,
"folder.ico") failed: 0x6
assoc.c:113: Test failed: line 169: IQueryAssociations::Init failed, 0x1
assoc.c:118: Test failed: line 169: GetString returned 0x80004005, expected
success
assoc.c:129: Test failed: line 169: GetString returned L"", expected
L"shell32.dll,1"
assoc.c:113: Test failed: line 170: IQueryAssociations::Init failed, 0x1
assoc.c:118: Test failed: line 170: GetString returned 0x80004005, expected
success
assoc.c:129: Test failed: line 170: GetString returned L"", expected
L"shell32.dll,1"
assoc.c:113: Test failed: line 171: IQueryAssociations::Init failed, 0x80070057
assoc.c:118: Test failed: line 171: GetString returned 0x80004005, expected
success
assoc.c:129: Test failed: line 171: GetString returned L"", expected
L"shell32.dll,1"

shell32:assoc results on test.winehq.org:
https://test.winehq.org/data/tests/shell32:assoc.html

commit 9e05c66c03cfa6df33fea0c13b944684bca9999f
Author: Theodore Dubois 
Date:   Wed Mar 16 13:19:51 2016 -0700

shell32/tests: Additional tests for IQueryAssociations.

Signed-off-by: Theodore Dubois 
    Signed-off-by: Alexandre Julliard

[Bug 40344] shell32:assoc regression (privilege issue)

https://bugs.winehq.org/show_bug.cgi?id=40344

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |9e05c66c03cfa6df33fea0c13b9
                   |                            |44684bca9999f
                URL|                            |https://test.winehq.org/dat
                   |                            |a/tests/shell32:assoc.html
           Keywords|                            |download, regression,
                   |                            |source, testcase

[Bug 40344] shell32:assoc regression (privilege issue)

https://bugs.winehq.org/show_bug.cgi?id=40344

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

[Bug 40344] shell32:assoc regression (privilege issue)

https://bugs.winehq.org/show_bug.cgi?id=40344

--- Comment #1 from [e-mail] ---
This test creates registry keys in HKEY_CLASSES_ROOT and tests the code that
retrieves values from those keys, and it fails because HKEY_CLASSES_ROOT is not
writable without elevated privileges.

It could instead put the keys in HKCU/Software/Classes, which is writable
without elevated privileges, but then the tests would fail on Wine because
IQueryAssociations doesn't check there. That's a different bug. I plan to send
a patch to fix it and another patch to make the tests run without elevated
privileges.

[Bug 40344] shell32:assoc regression (privilege issue)

https://bugs.winehq.org/show_bug.cgi?id=40344

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |e89a7735c3a9fce670648fbf0bd
                   |                            |fb221171172d0
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from Hans Leidekker  ---
Fixed with e89a7735c3a9fce670648fbf0bdfb221171172d0.

[Bug 40344] shell32:assoc regression (privilege issue)

https://bugs.winehq.org/show_bug.cgi?id=40344

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  ---
Closing bugs fixed in 2.0-rc2.