[Bug 36250] New: valgrind shows an uninitialized value in ddraw/tests/ddraw{1,2}.c

https://bugs.winehq.org/show_bug.cgi?id=36250

Bug ID: 36250
           Summary: valgrind shows an uninitialized value in
                    ddraw/tests/ddraw{1,2}.c
           Product: Wine
           Version: 1.7.18
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]

==28116== Conditional jump or move depends on uninitialised value(s)
==28116==    at 0x579FF6C: GetRegionData (region.c:889)
==28116==    by 0x498BE85: ddraw_clipper_GetClipList (clipper.c:213)
==28116==    by 0x49B6590: ddraw_surface_blt_clipped (surface.c:1429)
==28116==    by 0x49B6C1E: ddraw_surface7_Blt (surface.c:1537)
==28116==    by 0x49B7073: ddraw_surface1_Blt (surface.c:1597)
==28116==    by 0x4C6AD8E: test_clipper_blt (ddraw1.c:714)
==28116==    by 0x4C83531: func_ddraw1 (ddraw1.c:5330)
==28116==    by 0x4D1E890: run_test (test.h:584)
==28116==    by 0x4D1EC7F: main (test.h:654)
==28116==  Uninitialised value was created by a stack allocation
==28116==    at 0x49B6315: ddraw_surface_blt_clipped (surface.c:1366)
==28116==

[Bug 36250] valgrind shows an uninitialized value in ddraw/tests/ddraw{1,2}.c

https://bugs.winehq.org/show_bug.cgi?id=36250

--- Comment #1 from Henri Verbeet  ---
Created attachment 48420
  --> https://bugs.winehq.org/attachment.cgi?id=48420
patch

Does the attached patch help?

[Bug 36250] valgrind shows an uninitialized value in ddraw/tests/ddraw{1,2}.c

https://bugs.winehq.org/show_bug.cgi?id=36250

--- Comment #2 from Austin English  ---
(In reply to Henri Verbeet from comment #1)
> Created attachment 48420 [details]
> patch
>
> Does the attached patch help?

Yep, thanks.

[Bug 36250] valgrind shows an uninitialized value in ddraw/tests/ddraw{1,2}.c

https://bugs.winehq.org/show_bug.cgi?id=36250

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |9016d1eda0cec04606fd3996559
                   |                            |dabcee6e493b9
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Austin English  ---
Fixed by 9016d1eda0cec04606fd3996559dabcee6e493b9. There are some leaks in
ddraw_surface1_Blt / related code, see bug 36343.

[Bug 36250] valgrind shows an uninitialized value in ddraw/tests/ddraw{1,2}.c

https://bugs.winehq.org/show_bug.cgi?id=36250

--- Comment #4 from Austin English  ---
*** Bug 36342 has been marked as a duplicate of this bug. ***

[Bug 36250] valgrind shows an uninitialized value in ddraw/tests/ddraw{1,2}.c

https://bugs.winehq.org/show_bug.cgi?id=36250

--- Comment #5 from Austin English  ---
*** Bug 36344 has been marked as a duplicate of this bug. ***

[Bug 36250] valgrind shows an uninitialized value in ddraw/tests/ddraw{1,2}.c

https://bugs.winehq.org/show_bug.cgi?id=36250

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.19.