[Bug 54522] New: SM1: source swizzles for dp* instructions are using destination writemask

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54522

Bug ID: 54522
           Summary: SM1: source swizzles for dp* instructions are using
                    destination writemask
           Product: vkd3d
           Version: 1.6
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: hlsl
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

I noticed that doing some unrelated testing. DP4 instructions are written out
as:

dp4 r2.x, r1.x, r0.x

after
https://source.winehq.org/git/vkd3d.git/commit/d01729921c18912708ac3fb754136...

Commenting out sm1_map_src_swizzle() in write_sm1_binary_op() for D3DSIO_DP4
produces expected:

dp4 r2.x, r1, r0

and fixes tests for me.

Francisco, could you take a look?

[Bug 54522] SM1: source swizzles for dp* instructions are using destination writemask

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54522

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 54522] SM1: source swizzles for dp* instructions are using destination writemask

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54522

Francisco Casas  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Francisco Casas  ---
This should be solved by
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/107

[Bug 54522] SM1: source swizzles for dp* instructions are using destination writemask

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54522

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |af25d5bf9688c8f633456d8709f
                   |                            |642c4f3049e64

--- Comment #2 from Nikolay Sivov  ---
This should be fixed now, af25d5bf9688c8f633456d8709f642c4f3049e64.

[Bug 54522] SM1: source swizzles for dp* instructions are using destination writemask

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54522

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Nikolay Sivov  ---
Closing bugs fixed win 1.7.