[Bug 35971] New: dsound resampler causing clicks in StarCraft when resampling to 48000

http://bugs.winehq.org/show_bug.cgi?id=35971

Bug ID: 35971
           Summary: dsound resampler causing clicks in StarCraft when
                    resampling to 48000
           Product: Wine
           Version: 1.7.16
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-dsound
          Assignee: [e-mail]
          Reporter: [e-mail]

Something is still not perfect with the resampler in Wine.

I tested Starcraft (Starcraft is using 22050 and 11025 freq buffers), and it
seems when the primary buffer sample rate is 48000, there are noticable clicks
on the sound output. On the other hand, if the primary buffer sample rate is
44100, the sound is fine.

In order to test this I hacked winealsa.drv to force the max sample rate to
44100 insetad of 48000, and this resolved the issue, that is why I think that
the resampler is handling badly resampling from 22050 or 11025 to 48000.

[Bug 35971] dsound resampler causing clicks in StarCraft when resampling to 48000

http://bugs.winehq.org/show_bug.cgi?id=35971

--- Comment #1 from Marton Balint  ---
Created attachment 48085
  --> http://bugs.winehq.org/attachment.cgi?id=48085
winedebug output with original 48000 sample rate

[Bug 35971] dsound resampler causing clicks in StarCraft when resampling to 48000

http://bugs.winehq.org/show_bug.cgi?id=35971

--- Comment #2 from Marton Balint  ---
Created attachment 48086
  --> http://bugs.winehq.org/attachment.cgi?id=48086
winedebug output with hacked 44100 sample rate

[Bug 35971] dsound resampler causing clicks in StarCraft when resampling to 48000

https://bugs.winehq.org/show_bug.cgi?id=35971

Marton Balint  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |6d009b988b22212fabcc34711c4
                   |                            |0ec776fecaec5
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |[e-mail]
         Resolution|---                         |FIXED

--- Comment #3 from Marton Balint  ---
Fixed in git master.

[Bug 35971] dsound resampler causing clicks in StarCraft when resampling to 48000

https://bugs.winehq.org/show_bug.cgi?id=35971

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.34.