[Bug 22441] New: DNSBench cannot save to file an image

http://bugs.winehq.org/show_bug.cgi?id=22441

Summary: DNSBench cannot save to file an image
           Product: Wine
           Version: unspecified
          Platform: x86
               URL: http://www.grc.com/dns/benchmark.htm
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: gdiplus
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

GRC's DNSBench.exe (a tiny 150kb download written in assembler) cannot save an
image. This app works well in wine with only a few small issues:

fixme:gdiplus:GdipCreateBitmapFromGdiDib don't know how to handle 32 bpp

To see this, start DNSBench, it briefly checks for internet access and shows 4
main tabs. Click on the Nameservers tab, and it displays a list of IP addresses
and names. Right click on this and the menu shows the 8th option as "Save all
as image to file" This is shown in the attachment (a closeup from a
screenshot).

http://source.winehq.org/source/dlls/gdiplus/image.c#L1215
line 1215 GpStatus WINGDIPAPI GdipCreateBitmapFromGdiDib shows 32bpp not
handled yet.

winetricks gdiplus works around this problem.

[Bug 22441] DNSBench cannot save to file an image

http://bugs.winehq.org/show_bug.cgi?id=22441

--- Comment #1 from [e-mail]  2010-04-20 19:18:53 ---
Created an attachment (id=27483)
 --> (http://bugs.winehq.org/attachment.cgi?id=27483)
screenshot

screenshot to show how to find and reproduce in wine-1.1.32

[Bug 22441] DNSBench cannot save to file an image

http://bugs.winehq.org/show_bug.cgi?id=22441

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
            Version|unspecified                 |1.1.32

[Bug 22441] DNSBench cannot save to file an image

http://bugs.winehq.org/show_bug.cgi?id=22441

--- Comment #2 from Vitaliy Margolen   2010-04-20 21:03:53 ---
Please try with latest wine-1.1.43.

[Bug 22441] DNSBench cannot save to file an image

http://bugs.winehq.org/show_bug.cgi?id=22441

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.1.32                      |unspecified

--- Comment #3 from [e-mail]  2010-04-21 06:51:33 ---
no change in git wine 1.1.43
fixme:gdiplus:GdipCreateBitmapFromGdiDib (0xebe138, 0xfc0020, 0x32fb28) -
partially implemented
fixme:gdiplus:GdipCreateBitmapFromGdiDib don't know how to handle 32 bpp

[Bug 22441] DNSBench cannot save to file an image

http://bugs.winehq.org/show_bug.cgi?id=22441

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |1.1.32

--- Comment #4 from Nikolay Sivov   2010-04-21 06:53:18 ---
(In reply to comment #3)
> no change in git wine 1.1.43

Don't reset version field please.

[Bug 22441] DNSBench cannot save to file an image

http://bugs.winehq.org/show_bug.cgi?id=22441

--- Comment #5 from [e-mail]  2010-04-21 07:10:07 ---
This seems to make it work:

git diff
diff --git a/dlls/gdiplus/image.c b/dlls/gdiplus/image.c
index 0a73dcf..3086410 100644
--- a/dlls/gdiplus/image.c
+++ b/dlls/gdiplus/image.c
@@ -1242,6 +1242,9 @@ GpStatus WINGDIPAPI GdipCreateBitmapFromGdiDib(GDIPCONST
B
     case 24:
         format = PixelFormat24bppRGB;
         break;
+    case 32:
+        format = PixelFormat32bppRGB;
+        break;
     default:
         FIXME("don't know how to handle %d bpp\n",
info->bmiHeader.biBitCount);
         *bitmap = NULL;

[Bug 22441] DNSBench cannot save to file an image

http://bugs.winehq.org/show_bug.cgi?id=22441

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.1.32                      |1.1.43

[Bug 22441] DNSBench cannot save to file an image

http://bugs.winehq.org/show_bug.cgi?id=22441

Vincent Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 22441] DNSBench cannot save to file an image

http://bugs.winehq.org/show_bug.cgi?id=22441

--- Comment #6 from Vincent Povirk   2010-04-24 09:42:53 ---
Patch sent: http://www.winehq.org/pipermail/wine-patches/2010-April/087737.html

[Bug 22441] DNSBench cannot save to file an image

http://bugs.winehq.org/show_bug.cgi?id=22441

--- Comment #7 from [e-mail]  2010-04-27 07:41:30 ---
Patch committed. DNSBench.exe successfully saves image with
wine-1.1.43-321-g94a3c09 . Thank you Vincent.

[Bug 22441] DNSBench cannot save to file an image

http://bugs.winehq.org/show_bug.cgi?id=22441

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Vitaliy Margolen   2010-04-27 08:40:46 ---
Reported fixed.

[Bug 22441] DNSBench cannot save to file an image

http://bugs.winehq.org/show_bug.cgi?id=22441

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard   2010-05-07 13:30:28 ---
Closing bugs fixed in 1.1.44.