http://bugs.winehq.org/show_bug.cgi?id=34647
Bug #: 34647 Summary: Test Results table missing Product: WineHQ Apps Database Version: unspecified Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: appdb-unknown AssignedTo: wine-bugs@winehq.org ReportedBy: wine@placesthroughtime.com Classification: Unclassified
Not sure what caused it but for a few months now the Test Results table has been missing. The selected test result is not the most recent test result either. Here is a link to the effected version of Terraria, 1.1.*:
http://appdb.winehq.org/objectManager.php?sClass=version&iId=24915
http://bugs.winehq.org/show_bug.cgi?id=34647
Rosanne DiMesio dimesio@earthlink.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Summary|Test Results table missing |Test Results table missing | |in the Terreria 1.1.* entry Ever Confirmed|0 |1
--- Comment #1 from Rosanne DiMesio dimesio@earthlink.net 2013-10-03 09:21:35 CDT --- Confirming. It's also impossible to submit new test reports to that entry, because the button for that is missing, too. The text displayed in the test report window looks like a maintainer howto.
http://bugs.winehq.org/show_bug.cgi?id=34647
--- Comment #2 from Rosanne DiMesio dimesio@earthlink.net 2013-10-03 09:49:34 CDT --- I tried editing the maintainer note (Installation guide with winetricks) that was appearing incorrectly in the test report frame, but it disappeared altogether when I saved it. A second note that was previously appearing in right place (Installation guide without winetricks) is now appearing in the test report space.
I did manage to retrieve the contents of the lost note from Google cache, and I added it back as a new note.
http://bugs.winehq.org/show_bug.cgi?id=34647
--- Comment #3 from Rosanne DiMesio dimesio@earthlink.net 2013-10-03 10:18:34 CDT --- I managed to get the page straightened out.
The problem first appeared with the test report submitted on Aug 3 by Michael Pelchat. I was able to see and open his test report in edit via Google cache, and found that when I toggled the html source, each section had a large block of code that was marked as being inserted by AdBlock. The next test report, submitted on on Aug. 14 by CannedNinja, had the same problem. Once I deleted all the AdBlock-inserted code in the two test reports, the page displayed properly.
The question now is, how did this code get inserted into two unrelated test reports? It's certainly possible the two users were both coincidentally using AdBlock, but it seems more likely to have come from whoever processed the test reports.
http://bugs.winehq.org/show_bug.cgi?id=34647
--- Comment #4 from Rosanne DiMesio dimesio@earthlink.net 2013-10-03 10:33:08 CDT --- Created attachment 46180 --> http://bugs.winehq.org/attachment.cgi?id=46180 Example of what AdBlock inserts
Attaching a copy of what I deleted from each section of the two test reports.
http://bugs.winehq.org/show_bug.cgi?id=34647
Rosanne DiMesio dimesio@earthlink.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Test Results table missing |AdBlock inserts style rules |in the Terreria 1.1.* entry |into test report forms that | |prevent the page from | |rendering properly
--- Comment #5 from Rosanne DiMesio dimesio@earthlink.net 2013-10-03 10:42:17 CDT --- Editing the summary to reflect the underlying issue with AdBlock. Even though the Terreria page is now fixed, I'm going to leave this bug open, as it has the potential to affect other AppDB pages. (Not sure what can be done about it here.)
http://bugs.winehq.org/show_bug.cgi?id=34647
--- Comment #6 from Ken Sharp imwellcushtymelike@gmail.com --- Shouldn't this be sent to Adblock as it's hardly the AppDB's fault?
http://bugs.winehq.org/show_bug.cgi?id=34647
--- Comment #7 from Rosanne DiMesio dimesio@earthlink.net --- AdBlock shouldn't be doing it, but the fact that the AppDB allows it to happen seems like an AppDB bug to me.
http://bugs.winehq.org/show_bug.cgi?id=34647
--- Comment #8 from Rosanne DiMesio dimesio@earthlink.net --- AdBlock did have a bug filed for this behavior, but it was marked fixed almost two years ago; http://code.google.com/p/adblockforchrome/issues/detail?id=4965.
http://bugs.winehq.org/show_bug.cgi?id=34647
Alexander Nicolaysen Sørnes alexsornes@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |alexsornes@gmail.com
--- Comment #9 from Alexander Nicolaysen Sørnes alexsornes@gmail.com --- The way I see it, the proper way to protect against this is to not allow HTML to be used for formatting test reports.
Allowing HTML in user input allows users great control over how the content is displayed, which is some cases can have undesired consequences. If we go for that option, then there should be a check to make sure that old test reports can maintain their HTML, while it is not allowed for new reports.
Another alternative is to simply limit the length of a report, but that would not really solve the problem.
http://bugs.winehq.org/show_bug.cgi?id=34647
--- Comment #10 from Rosanne DiMesio dimesio@earthlink.net --- I'm fine with not allowing HTML from users.
I wouldn't want to restrict the length of the reports; more detailed reports are usually better ones.
http://bugs.winehq.org/show_bug.cgi?id=34647
--- Comment #11 from Ken Sharp imwellcushtymelike@gmail.com --- I use HTML (well, rich text) in test reports a great deal, and the formatting does make the test results a lot better, specifically: bulletpoints/list items, bold, italic and URL links are all very useful, even in test reports.
I guess a more restrictive HTML could be useful (BB code?) but that might be a nightmare to implement.
Even so, the AppDB shouldn't be allowing "invisible" code - that's probably something to do with the editor part though: choosing "HTML source" really should show the source. No idea why it doesn't.
http://bugs.winehq.org/show_bug.cgi?id=34647
--- Comment #12 from Rosanne DiMesio dimesio@earthlink.net --- We've had another incident of hidden junk being inserted into test reports; in this case it happened to a report submitted by Wylda, who mentioned it here: http://bugs.winehq.org/show_bug.cgi?id=35599#c5.
I cleaned up that report, but something needs to be done to prevent this from happening in the first place.
http://bugs.winehq.org/show_bug.cgi?id=34647
Rosanne DiMesio dimesio@earthlink.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dimesio@earthlink.net
--- Comment #13 from Rosanne DiMesio dimesio@earthlink.net --- Created attachment 47878 --> http://bugs.winehq.org/attachment.cgi?id=47878 Code injected by gleebox
It's not just Adblock that injects unwanted code; attaching a copy of what I found today in a test report, injected by something called "gleebox."
http://bugs.winehq.org/show_bug.cgi?id=34647
Rosanne DiMesio dimesio@earthlink.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|AdBlock inserts style rules |Browser plugins are able to |into test report forms that |inject unwanted css code |prevent the page from |into test report forms |rendering properly |
https://bugs.winehq.org/show_bug.cgi?id=34647
Jason Palmer jalanpalmer@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jalanpalmer@gmail.com
--- Comment #14 from Jason Palmer jalanpalmer@gmail.com --- Created attachment 49993 --> https://bugs.winehq.org/attachment.cgi?id=49993 SmartVideo For YouTube injection example
I'm seeing injections of CSS and HTML elements from the SmartVideo For YouTube extension.
https://bugs.winehq.org/show_bug.cgi?id=34647
--- Comment #15 from Rosanne DiMesio dimesio@earthlink.net --- A user reported on wine-devel that QupZilla also does this: https://www.winehq.org/pipermail/wine-devel/2016-May/113346.html
https://bugs.winehq.org/show_bug.cgi?id=34647
Chiitoo escomk3@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |escomk3@hotmail.com
--- Comment #16 from Chiitoo escomk3@hotmail.com --- (In reply to Rosanne DiMesio from comment #15)
A user reported on wine-devel that QupZilla also does this: https://www.winehq.org/pipermail/wine-devel/2016-May/113346.html
With regards to QupZilla, this should be fixed in its next release (2.0.1; the fixes are already in for “live builds”).
https://bugs.winehq.org/show_bug.cgi?id=34647
Rosanne DiMesio dimesio@earthlink.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fjfrackiewicz@gmail.com
--- Comment #17 from Rosanne DiMesio dimesio@earthlink.net --- *** Bug 41860 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=34647
--- Comment #18 from Rosanne DiMesio dimesio@earthlink.net --- *** Bug 41920 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=34647
--- Comment #19 from Rosanne DiMesio dimesio@earthlink.net --- Created attachment 56298 --> https://bugs.winehq.org/attachment.cgi?id=56298 Code injected by Grammarly
Attaching code injected by Grammarly into a Fallout New Vegas test report (duplicate bug 41920). This is apparently a known issue with Grammarly: http://daviseford.com/node/72.
https://bugs.winehq.org/show_bug.cgi?id=34647
--- Comment #20 from fjfrackiewicz@gmail.com --- (In reply to Rosanne DiMesio from comment #19)
Created attachment 56298 [details] Code injected by Grammarly
Attaching code injected by Grammarly into a Fallout New Vegas test report (duplicate bug 41920). This is apparently a known issue with Grammarly: http://daviseford.com/node/72.
Hi Rosanne,
Sorry to bother you about this but The Sims 3 is also missing all of its test results: https://appdb.winehq.org/objectManager.php?sClass=version&iId=16664 Is this another case of browser plug-ins injecting unwanted css code?
https://bugs.winehq.org/show_bug.cgi?id=34647
--- Comment #21 from Rosanne DiMesio dimesio@earthlink.net --- Yes, it is. Thanks for letting me know. I've deleted the offending test report.
https://bugs.winehq.org/show_bug.cgi?id=34647
Robert Walker bob.mt.wya@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bob.mt.wya@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=34647
--- Comment #22 from fjfrackiewicz@gmail.com --- (In reply to Rosanne DiMesio from comment #21)
Yes, it is. Thanks for letting me know. I've deleted the offending test report.
Hi Roseanne,
I am trying to submit this test report: https://appdb.winehq.org/objectManager.php?bIsQueue=false&bIsRejected=fa...
but when I go to preview it, the test data doesn't show and I am not sure which of my plug-ins is interfering. NoScript is set allow everything from Wine HQ, I've disabled ProxTube, and the only other plug-ins or extensions I have active are uBlock Origin, FireFTP, e-Pub Catalog, a Google translate plug-in, and Nimbus screenshot.
https://bugs.winehq.org/show_bug.cgi?id=34647
--- Comment #23 from Rosanne DiMesio dimesio@earthlink.net --- (In reply to fjfrackiewicz from comment #22)
I am trying to submit this test report: https://appdb.winehq.org/objectManager. php?bIsQueue=false&bIsRejected=false&sClass=version_queue&iId=35008&sAction=e dit&sReturnTo=%2Fqueueditems.php&sTitle=Edit+entry
but when I go to preview it, the test data doesn't show and I am not sure which of my plug-ins is interfering. NoScript is set allow everything from Wine HQ, I've disabled ProxTube, and the only other plug-ins or extensions I have active are uBlock Origin, FireFTP, e-Pub Catalog, a Google translate plug-in, and Nimbus screenshot.
I can see the problem, but it's not this bug; you can tell by toggling the HTML icon in the edit box--there is no extra code. File a new bug.
https://bugs.winehq.org/show_bug.cgi?id=34647
--- Comment #24 from fjfrackiewicz@gmail.com --- (In reply to Rosanne DiMesio from comment #23)
(In reply to fjfrackiewicz from comment #22)
I am trying to submit this test report: https://appdb.winehq.org/objectManager. php?bIsQueue=false&bIsRejected=false&sClass=version_queue&iId=35008&sAction=e dit&sReturnTo=%2Fqueueditems.php&sTitle=Edit+entry
but when I go to preview it, the test data doesn't show and I am not sure which of my plug-ins is interfering. NoScript is set allow everything from Wine HQ, I've disabled ProxTube, and the only other plug-ins or extensions I have active are uBlock Origin, FireFTP, e-Pub Catalog, a Google translate plug-in, and Nimbus screenshot.
I can see the problem, but it's not this bug; you can tell by toggling the HTML icon in the edit box--there is no extra code. File a new bug.
Thank you and here's bug 42630 as per your request.