http://bugs.winehq.org/show_bug.cgi?id=18664
Summary: Merging an application with itself causes all child objects to be deleted Product: WineHQ Apps Database Version: unspecified Platform: Other URL: http://appdb.winehq.org/objectManager.php?sClass=appli cation&iId=9759 OS/Version: other Status: NEW Keywords: source Severity: normal Priority: P2 Component: appdb-unknown AssignedTo: wine-bugs@winehq.org ReportedBy: kennybobs@o2.co.uk
Just happened with this app: http://appdb.winehq.org/objectManager.php?sClass=application&iId=9759
Rosanne had processed this app just before I opened it to process. The result being that the appdb found a duplicate entry: but it was the same app. (Carelessly) I merged the app with itself, this deleted all versions and test data.
A number of possible solution: 1. Apps shouldn't find themselves as duplicates (identifiable by their numeric ID). 2. An error message should appear when attempting to merge an app with itself. 3. It certainly shouldn't delete all objects at a bare minimum.
Better yet of course: Once an app is processed, attempting to process it again should report an error and fail, e.g. "App already processed."
http://bugs.winehq.org/show_bug.cgi?id=18664
Alexander Nicolaysen Sørnes alex@thehandofagony.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |alex@thehandofagony.com Resolution| |FIXED
--- Comment #1 from Alexander Nicolaysen Sørnes alex@thehandofagony.com 2009-06-28 08:47:15 --- I've fixed the Duplicates table to not include the app that's currently being viewed. This happened because the code always assumed the processed app would be queued.
We should probably add a locking mechanism so that only one user can process or edit an entry at a time. This requires modifying the MySQL database, which I currently don't have access to.
I think this bug can be closed, but you can open another one for the locking stuff if you wish.
http://bugs.winehq.org/show_bug.cgi?id=18664
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #2 from Ken Sharp kennybobs@o2.co.uk 2009-06-29 05:46:39 --- Thanks again Alexander, great work as always.
Closing.