[Bug 38286] New: SpinTires has error with ARB shaders enabled

https://bugs.winehq.org/show_bug.cgi?id=38286

Bug ID: 38286
           Summary: SpinTires has error with ARB shaders enabled
           Product: Wine
           Version: 1.7.39
          Hardware: x86-64
               URL: http://oovee.chicsystems.net/SpinTiresInstall_060613.z
                    ip
                OS: Linux
            Status: NEW
          Keywords: download
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
      Distribution: ---

Strings during playing:

err:d3d:state_undefined Undefined state.
err:d3d:wined3d_debug_callback 0x1ad5f00: "GL_INVALID_OPERATION error
generated. State(s) are invalid: fragment program.".
err:d3d:wined3d_debug_callback 0x1ad5f00: "GL_INVALID_OPERATION error
generated. Calling glEnd from the current immediate mode state is invalid.
Check glBegin() / glEnd() pairs.".
err:d3d_draw:drawStridedSlow >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502)
from glEnd and previous calls @ drawprim.c / 332

[Bug 38286] SpinTires has error with ARB shaders enabled

https://bugs.winehq.org/show_bug.cgi?id=38286

--- Comment #1 from Stefan Dösinger  ---
Can you record a +d3d_shader log and extract the full program with the syntax
error from it?

[Bug 38286] SpinTires has error with ARB shaders enabled

https://bugs.winehq.org/show_bug.cgi?id=38286

--- Comment #2 from Andrey Gusev  ---
Created attachment 51119
  --> https://bugs.winehq.org/attachment.cgi?id=51119
+d3d_shader

[Bug 38286] SpinTires has error with ARB shaders enabled

https://bugs.winehq.org/show_bug.cgi?id=38286

--- Comment #3 from Stefan Dösinger  ---
fixme:d3d_shader:get_argreg Implement perstage constants

That says all.

This issue should be fixable. Do you want to take a shot at it? Have a look at
how WINED3DTA_CONSTANT is handled in glsl_shader.c and how WINED3DTA_TFACTOR is
handled in the arb fixed function pipeline.

[Bug 38286] SpinTires has error with ARB shaders enabled

https://bugs.winehq.org/show_bug.cgi?id=38286

--- Comment #4 from Andrey Gusev  ---
Reproducible in 1.7.48

[Bug 38286] SpinTires has error with ARB shaders enabled

https://bugs.winehq.org/show_bug.cgi?id=38286

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]      |[e-mail]

[Bug 38286] SpinTires has error with ARB shaders enabled

https://bugs.winehq.org/show_bug.cgi?id=38286

Andrey Gusev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://oovee.chicsystems.ne |http://www.chip.de/download
                   |t/SpinTiresInstall_060613.z |s/Demo-Spintires_63302360.h
                   |ip                          |tml

[Bug 38286] SpinTires has error with ARB shaders enabled

https://bugs.winehq.org/show_bug.cgi?id=38286

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Józef Kucia  ---
Created attachment 53385
  --> https://bugs.winehq.org/attachment.cgi?id=53385
Implement texture stage constants in ARB program shader backend

[Bug 38286] SpinTires has error with ARB shaders enabled

https://bugs.winehq.org/show_bug.cgi?id=38286

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 38286] SpinTires has error with ARB shaders enabled

https://bugs.winehq.org/show_bug.cgi?id=38286

--- Comment #6 from Andrey Gusev  ---
It works. Thanks, Józef.

[Bug 38286] SpinTires has error with ARB shaders enabled

https://bugs.winehq.org/show_bug.cgi?id=38286

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]

[Bug 38286] SpinTires has error with ARB shaders enabled

https://bugs.winehq.org/show_bug.cgi?id=38286

Sergey Isakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Sergey Isakov  ---
The site forces download mac-version for me. I can't get windows version to
test.

[Bug 38286] SpinTires has error with ARB shaders enabled

https://bugs.winehq.org/show_bug.cgi?id=38286

--- Comment #8 from Sergey Isakov  ---
I got other mistakes
~~~~
fixme:qtsplitter:QT_QueryInterface No interface for
{37d84f60-42cb-11ce-8135-00aa004bb851}!
fixme:qtdatahandler:myComponentRoutineProc unhandled select 0x3e
fixme:qtdatahandler:myComponentRoutineProc unhandled select 0x21
fixme:qtdatahandler:myComponentRoutineProc unhandled select 0x111
fixme:qtdatahandler:myComponentRoutineProc unhandled select 0x27
fixme:qtdatahandler:myComponentRoutineProc unhandled select 0x4c
fixme:qtdatahandler:myComponentRoutineProc unhandled select 0x27
fixme:qtdatahandler:myComponentRoutineProc unhandled select 0x4c
fixme:qtdatahandler:myComponentRoutineProc unhandled select 0x42
fixme:qtdatahandler:myComponentRoutineProc unhandled select 0x28
fixme:qtdatahandler:myComponentRoutineProc unhandled select 0xfffffff4
fixme:qtdatahandler:myComponentRoutineProc unhandled select 0x111
fixme:qtdatahandler:myComponentRoutineProc unhandled select 0x27
fixme:qtdatahandler:myComponentRoutineProc unhandled select 0x4c
fixme:qtdatahandler:myComponentRoutineProc unhandled select 0x111
fixme:qtdatahandler:myComponentRoutineProc unhandled select 0x27
fixme:qtdatahandler:myComponentRoutineProc unhandled select 0x28
fixme:qtsplitter:QT_Process_Movie QuickTime cannot handle media type(-2048)
fixme:quartz:VMR9Inner_QueryInterface No interface for
{56a86897-0ad4-11ce-b03a-0020af0ba770}
fixme:d3d:state_lastpixel Last Pixel Drawing Disabled, not handled yet
~~~
and crash

[Bug 38286] SpinTires has error with ARB shaders enabled

https://bugs.winehq.org/show_bug.cgi?id=38286

--- Comment #9 from Sergey Isakov  ---
Tested on new prefix. All looks fine.
May be I didn't understand what we expected to see?

[Bug 38286] SpinTires has error with ARB shaders enabled

https://bugs.winehq.org/show_bug.cgi?id=38286

Andrey Gusev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |e62763972eded04e60370e00ba6
                   |                            |1d00e14404db3
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Andrey Gusev  ---
Fixed by commit
http://source.winehq.org/git/wine.git/commit/e62763972eded04e60370e00ba61d00...

[Bug 38286] SpinTires has error with ARB shaders enabled

https://bugs.winehq.org/show_bug.cgi?id=38286

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]      |[e-mail]

[Bug 38286] SpinTires has error with ARB shaders enabled

https://bugs.winehq.org/show_bug.cgi?id=38286

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #11 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.11.