[Bug 10211] New: gmax installer does not allow changing of installation directory, fails to install

http://bugs.winehq.org/show_bug.cgi?id=10211

Summary: gmax installer does not allow changing of installation
                    directory, fails to install
           Product: Wine
           Version: CVS/GIT
          Platform: PC
               URL: http://www.turbosquid.com/gmax
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: wine-misc
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

When trying to install gmax the application fails to continue stating it will
be installing over existing installation and prompts you to choose a new
location, choosing a new location through the browse dialog does not change the
install path, and does not allow you to continue the installation.

[Bug 10211] gmax installer does not allow changing of installation directory, fails to install

http://bugs.winehq.org/show_bug.cgi?id=10211

EA Durbin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, Installer

[Bug 10211] gmax installer does not allow changing of installation directory, fails to install

http://bugs.winehq.org/show_bug.cgi?id=10211

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #1 from Austin English   2007-10-28 15:58:55 ---
http://files.turbosquid.com/Products/L567271/XFM83W83US/gmax12.exe

Confirming in wine 0.9.47. Won't let you change install directory, and for that
matter doesn't install even on the first try in the directory it wants to
install (C:\gmax).

Note that winetricks fakeie6 is required to attempt install.

[Bug 10211] gmax installer does not allow changing of installation directory, fails to install

http://bugs.winehq.org/show_bug.cgi?id=10211

EA Durbin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from EA Durbin   2008-06-20 22:06:54 ---
this appears to be fixed as of wine 1.0, but now theres a new installation
error, will open a new bug

[Bug 10211] gmax installer does not allow changing of installation directory, fails to install

http://bugs.winehq.org/show_bug.cgi?id=10211

EA Durbin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from EA Durbin   2008-06-20 22:07:10 ---
closing

[Bug 10211] gmax installer does not allow changing of installation directory, fails to install

http://bugs.winehq.org/show_bug.cgi?id=10211

EA Durbin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |REOPENED
         Resolution|FIXED                       |

--- Comment #4 from EA Durbin   2008-06-20 22:08:28 ---
still can not change installation directory, closed prematurely

[Bug 10211] gmax installer does not allow changing of installation directory, fails to install

http://bugs.winehq.org/show_bug.cgi?id=10211

--- Comment #5 from Austin English   2008-12-19 12:15:49 ---
Still present in git.

[Bug 10211] gmax installer does not allow changing of installation directory, fails to install

http://bugs.winehq.org/show_bug.cgi?id=10211

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |unspecified

--- Comment #6 from Austin English   2009-01-18 03:46:40 ---
Removing deprecated CVS/GIT version tag. Please retest in current git. If the
bug is still present in today's wine, but was not present in some earlier
version of wine, please update version field to earliest known version of wine
that had the bug. Thanks!

[Bug 10211] gmax installer does not allow changing of installation directory, fails to install

http://bugs.winehq.org/show_bug.cgi?id=10211

Niko Sandschneider  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Niko Sandschneider   2010-06-02 17:09:28 ---
This is almost fixed in wine-1.2-rc2. After you change the install directory,
e.g. from c:\gmax to c:\foobar, the setup program still claims to install to
c:\gmax. However, after performing the installation the app was actually
installed in c:\foobar. So the problem seems to be a missing "refresh" of the
setup dialog.

[Bug 10211] gmax 1.2 installer doesn't update dialog controls subscribed to SelectionPath event when the INSTALLDIR property has changed

http://bugs.winehq.org/show_bug.cgi?id=10211

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEW
                 CC|                            |[e-mail]
          Component|-unknown                    |msi
            Version|unspecified                 |0.9.48.
            Summary|gmax installer does not     |gmax 1.2 installer doesn't
                   |allow changing of           |update dialog controls
                   |installation directory,     |subscribed to SelectionPath
                   |fails to install            |event when the INSTALLDIR
                   |                            |property has changed

--- Comment #8 from Anastasius Focht  2011-07-22 15:31:01 CDT ---
Hello,

confirming, still present.

--- snip ---
...
0021:Call user32.CreateWindowExW(00000000,683a7440 L"Static",0063e346
L"C:\gmax\",50020000,00000033,000000c8,00000130,00000017,00040022,00000000,00000000,00000000)
ret=68338857
0021:trace:win:WIN_CreateWindowEx L"C:\gmax\" L"Static" ex=00000000
style=50020000 51,200 304x23 parent=0x40022 menu=(nil) inst=(nil) params=(nil)
0021:trace:win:dump_window_styles style: WS_CHILD WS_VISIBLE WS_GROUP
0021:trace:win:dump_window_styles exstyle:
0021:trace:win:WIN_SetWindowLong 0x20094 -12 0 W 
...
0021:trace:win:WIN_CreateWindowEx created window 0x20094
0021:Ret  user32.CreateWindowExW() retval=00020094 ret=68338857
0021:trace:msi:msi_dialog_create_window Dialog L"Single_Feature_Destination"
control L"[_WiseDialogFontDefault][INSTALLDIR]" hwnd 0x20094 
...
0021:Call user32.SetPropW(00020094,683a745c L"MSIDATA",00185b20) ret=6833996f
0021:Ret  user32.SetPropW() retval=00000001 ret=6833996f
0021:trace:msi:ControlEvent_SubscribeToEvent event L"SelectionPath" control
L"Text43" attribute L"SelectionPath" 
...
0021:trace:msi:msi_get_property returning L"C:\gmax\yyy\" for property
L"INSTALLDIR"
...
0021:trace:msi:ControlEvent_FireSubscribedEvent Firing event L"SelectionPath" 
...
0021:trace:msi:msi_get_property property L"C:\gmax\yyy\" not found
0021:Call user32.SetWindowTextW(00020094,00000000) ret=683392c9
0021:Call window proc 0x683395e0
(hwnd=0x20094,msg=WM_SETTEXT,wp=00000000,lp=00000000)
0021:trace:msi:MSIText_WndProc 0x20094 000c 00000000 00000000
0021:Call user32.GetPropW(00020094,683a745c L"MSIDATA") ret=68339673
0021:Ret  user32.GetPropW() retval=00185b20 ret=68339673
0021:Call user32.CallWindowProcW(68712a33,00020094,0000000c,00000000,00000000)
ret=683396e5
0021:Call window proc 0x68712a33
(hwnd=0x20094,msg=WM_SETTEXT,wp=00000000,lp=00000000)
0021:Ret  window proc 0x68712a33
(hwnd=0x20094,msg=WM_SETTEXT,wp=00000000,lp=00000000) retval=00000000
0021:Ret  user32.CallWindowProcW() retval=00000000 ret=683396e5
...
0021:Ret  window proc 0x683395e0
(hwnd=0x20094,msg=WM_SETTEXT,wp=00000000,lp=00000000) retval=00000000
0021:Ret  user32.SetWindowTextW() retval=00000000 ret=683392c9
...
0021:trace:msi:MSI_SetTargetPathW 0x1658a0 L"INSTALLDIR" L"C:\gmax\yyy\"
...
0021:trace:msi:msi_set_property 0x1468d8 L"INSTALLDIR" L"C:\gmax\yyy\" 
--- snip ---

The dialog controls correctly subscribe the "SelectionPath" event.
The event is fired after the folder selection is done (browse dialog).
Unfortunately there is a bug when retrieving the property value.

See "msi_dialog_handle_event":
http://source.winehq.org/git/wine.git/blob/e601ef55a9ce9c0d3e52da48846cfa3ff...

--- snip ---
...
    else if ( !strcmpW( attribute, szSelectionPath ) )
    {
        LPWSTR prop = msi_dialog_dup_property( dialog, ctrl->property, TRUE );
        LPWSTR path;
        if (!prop) return;
        path = msi_dup_property( dialog->package->db, prop );
        SetWindowTextW( ctrl->hwnd, path );
        msi_free(prop);
        msi_free(path);
    }
--- snip ---

Due to "indirect == TRUE" passed to msi_dialog_dup_property(), the returned
string which ought to be the property name _is_ the property value (path value
of the INSTALLDIR property).
The following msi_dup_property() fails due to that mishap, returning NULL.

Either pass FALSE to msi_dialog_dup_property() or get rid following
msi_dup_property().

With that fixed, the installation directory name will be properly updated for
controls that are subscribed to SelectionPath event.

$ sha1sum gmax12.exe 
197b049ab1eda1b26061520e18ae43cf55b97e92  gmax12.exe

$ wine --version
wine-1.3.25-1-gdf65f3e

Regards

[Bug 10211] gmax 1.2 installer doesn't update dialog controls subscribed to SelectionPath event when the INSTALLDIR property has changed

http://bugs.winehq.org/show_bug.cgi?id=10211

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Hans Leidekker  2011-07-25 12:22:22 CDT ---
Should be fixed by b085b23b298927ea69be9c3ecb7bb3bb24249e5c.

[Bug 10211] gmax 1.2 installer doesn't update dialog controls subscribed to SelectionPath event when the INSTALLDIR property has changed

http://bugs.winehq.org/show_bug.cgi?id=10211

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Alexandre Julliard  2011-08-05 12:39:47 CDT ---
Closing bugs fixed in 1.3.26.

[Bug 10211] gmax 1.2 installer doesn't update dialog controls subscribed to SelectionPath event when the INSTALLDIR property has changed

http://bugs.winehq.org/show_bug.cgi?id=10211

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |b085b23b298927ea69be9c3ecb7
                   |                            |bb3bb24249e5c