[Bug 36518] New: Selecting character mission crashes Star Wars Rebellion 1.00

https://bugs.winehq.org/show_bug.cgi?id=36518

Bug ID: 36518
           Summary: Selecting character mission crashes Star Wars
                    Rebellion 1.00
           Product: Wine
           Version: 1.7.16
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: user32
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: 1cf3d8caa4df59490343ef9427ea5c6bc2af44c9

Created attachment 48591
  --> https://bugs.winehq.org/attachment.cgi?id=48591
Log with 1.7.16 no flags

After starting a game, choosing any character, trying to send him in a mission,
then clicking on the desired mission type will crash the game. Music will still
play, the game will seem to be still running, but only the desktop background
with the game icon on the lower left can be seen.

Running on windows 95 compatibility (what the game is supposed to be for),
WINEARCH=win32 (apparently a requisite for running in win95 compatibility, and
on a virtual desktop.

[Bug 36518] Selecting character mission crashes Star Wars Rebellion 1.00

https://bugs.winehq.org/show_bug.cgi?id=36518

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 36518] Selecting character mission crashes Star Wars Rebellion 1.00

http://bugs.winehq.org/show_bug.cgi?id=36518

Christopher May  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Christopher May  ---
Can confirm this behaviour on 1.7.19

[Bug 36518] Selecting character mission crashes Star Wars Rebellion 1.00

https://bugs.winehq.org/show_bug.cgi?id=36518

Piotr Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Piotr Caban  ---
Created attachment 48634
  --> https://bugs.winehq.org/attachment.cgi?id=48634
Try to activate parent window in WINPOS_ActivateOtherWindow

Wine is activating other window than windows when active window is destroyed.
The patch pointed by regression test is correct in this case. Probably
WINPOS_ActivateOtherWindow needs to be changed.

Could you please check if attached patch fixes the issue for you?

Note: according to my testing the patch is incorrect, I don't know yet how it
should be fixed.

[Bug 36518] Selecting character mission crashes Star Wars Rebellion 1.00

https://bugs.winehq.org/show_bug.cgi?id=36518

--- Comment #3 from [e-mail] ---
Works properly with the patch and wine-1.7.19-70-gd6a59f7

On a slightly related note, apparently the latest kernels break 16 bits
programs, such as this.

[Bug 36518] Selecting character mission crashes Star Wars Rebellion 1.00

http://bugs.winehq.org/show_bug.cgi?id=36518

Piotr Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |7257b62bd1b95438c651716b48b
                   |                            |f3d7438eb235a
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Piotr Caban  ---
Fixed by 7257b62bd1b95438c651716b48bf3d7438eb235a.

[Bug 36518] Selecting character mission crashes Star Wars Rebellion 1.00

https://bugs.winehq.org/show_bug.cgi?id=36518

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.20.