[Bug 21065] New: Up-Down Controls appearance is broken since 1.1.34

http://bugs.winehq.org/show_bug.cgi?id=21065

Summary: Up-Down Controls appearance is broken since 1.1.34
           Product: Wine
           Version: 1.1.34
          Platform: x86
               URL: http://miranda.googlecode.com/files/miranda-im-v0.8.11
                    -unicode.exe
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: comctl32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=25263)
 --> (http://bugs.winehq.org/attachment.cgi?id=25263)
Miranda 0.8.10 options in Wine 1.1.35

Wine 1.1.33 didn't have this problem, it was first introduced in wine 1.1.34
and still observable in wine 1.1.35.

[Bug 21065] [regression] Up-Down Controls appearance is broken since 1.1.34

http://bugs.winehq.org/show_bug.cgi?id=21065

Artem S. Tashkinov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression,
                   |                            |source
            Summary|Up-Down Controls appearance |[regression] Up-Down
                   |is broken since 1.1.34      |Controls appearance is
                   |                            |broken since 1.1.34

[Bug 21065] Up-Down Controls appearance is broken

http://bugs.winehq.org/show_bug.cgi?id=21065

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[regression] Up-Down        |Up-Down Controls appearance
                   |Controls appearance is      |is broken
                   |broken since 1.1.34         |
           Severity|normal                      |minor

--- Comment #1 from Nikolay Sivov   2009-12-18 14:56:52 ---
Reverting commit eaee84f4dbf086fe185532a59f879690fec5a5a9 should help.
You probably could operate input fields with up/down keys without any problems,
so this is of minor importance.

Please attach +updown,+message trace, I'll take a look.

[Bug 21065] Up-Down Controls appearance is broken

http://bugs.winehq.org/show_bug.cgi?id=21065

--- Comment #2 from Artem S. Tashkinov   2009-12-18 15:27:54 ---
Created an attachment (id=25264)
 --> (http://bugs.winehq.org/attachment.cgi?id=25264)
requested trace

Up and down keyboard buttons also don't work for up-down controls, instead of
changing the value, the text cursor moves forward or backward.

So pretty much Up-Down controls are all broken.

[Bug 21065] Up-Down controls malfunction

http://bugs.winehq.org/show_bug.cgi?id=21065

Artem S. Tashkinov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Up-Down Controls appearance |Up-Down controls
                   |is broken                   |malfunction
           Severity|minor                       |major

[Bug 21065] Up-Down Controls appearance is broken

http://bugs.winehq.org/show_bug.cgi?id=21065

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Up-Down controls            |Up-Down Controls appearance
                   |malfunction                 |is broken
           Severity|major                       |minor

--- Comment #3 from Nikolay Sivov   2009-12-18 15:30:29 ---
(In reply to comment #2)
> So pretty much Up-Down controls are all broken.

This isn't a subject of this regression. Did try to revert a specified commit?

[Bug 21065] Up-Down Controls appearance is broken

http://bugs.winehq.org/show_bug.cgi?id=21065

--- Comment #4 from Artem S. Tashkinov   2009-12-18 15:47:23 ---
Reverting this commit has solved the issue.

[Bug 21065] Up-Down Controls appearance is broken

http://bugs.winehq.org/show_bug.cgi?id=21065

--- Comment #5 from Artem S. Tashkinov   2009-12-18 15:51:17 ---
Since miranda's source code is available, I suppose there has to be a test case
for this issue.

[Bug 21065] Up-Down Controls appearance is broken

http://bugs.winehq.org/show_bug.cgi?id=21065

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25264|requested trace             |+updown,+message trace
        description|                            |

[Bug 21065] Up-Down Controls appearance is broken

http://bugs.winehq.org/show_bug.cgi?id=21065

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #6 from Nikolay Sivov   2009-12-21 17:38:08 ---
(In reply to comment #3)
> (In reply to comment #2)
> > So pretty much Up-Down controls are all broken.
>
> This isn't a subject of this regression. Did try to revert a specified commit?

I was wrong here, some controls (not all) are really broken - buddy failed to
attach in auto mode due wrong Z-order, I'll try to solve this starting with
tests.

[Bug 21065] Up-Down Controls appearance is broken

http://bugs.winehq.org/show_bug.cgi?id=21065

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Nikolay Sivov   2009-12-23 10:17:31 ---
This is fixed by commit 9ef90f480aac68e296c9d42be3ca03a2bd684af8.

[Bug 21065] Up-Down Controls appearance is broken

http://bugs.winehq.org/show_bug.cgi?id=21065

--- Comment #8 from Artem S. Tashkinov   2009-12-23 13:17:45 ---
Thank you!

(However I will still test the patches when wine 1.1.36 is released).

[Bug 21065] Up-Down Controls appearance is broken

http://bugs.winehq.org/show_bug.cgi?id=21065

Artem S. Tashkinov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Artem S. Tashkinov   2010-01-08 15:45:10 ---
Resolved in 1.1.36.

[Bug 21065] Up-Down Controls appearance is broken

http://bugs.winehq.org/show_bug.cgi?id=21065

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |9ef90f480aac68e296c9d42be3c
                   |                            |a03a2bd684af8

[Bug 21065] Up-Down Controls appearance is broken

http://bugs.winehq.org/show_bug.cgi?id=21065

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |eaee84f4dbf086fe185532a59f8
                   |                            |79690fec5a5a9