https://bugs.winehq.org/show_bug.cgi?id=53038
Bug ID: 53038 Summary: Epic Launcher Crash at Start: Unhandled exception: divide by zero in 64-bit code Product: Wine Version: 7.9 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: user32 Assignee: wine-bugs@winehq.org Reporter: ozan.turkyilmaz@gmail.com Distribution: ---
Created attachment 72411 --> https://bugs.winehq.org/attachment.cgi?id=72411 Backtrace
I updated wine from 7.8 to 7.9 and Epic Launcher started crashing at the start. The crashreportclient causes the crash as far as I can understand. The backtrace is attached.
I compile and package my wine using build scripts from wine-git repo. I compiled it at tag 7.9 this time. I also compile both 32 bit and 64 bit versions together.
I think it is a regression and will try doing regression analysis to see if it is true.
https://bugs.winehq.org/show_bug.cgi?id=53038
--- Comment #1 from Jactry Zeng jactry92@gmail.com --- Hi Ozan,
Could you upload a log with +loaddll channel?
https://bugs.winehq.org/show_bug.cgi?id=53038
--- Comment #2 from Ozan Türkyılmaz ozan.turkyilmaz@gmail.com --- Created attachment 72412 --> https://bugs.winehq.org/attachment.cgi?id=72412 Log for +loaddll channel
I'm attaching log for +loaddll channel
https://bugs.winehq.org/show_bug.cgi?id=53038
Ozan Türkyılmaz ozan.turkyilmaz@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |182feddd4b02e83f3c69863bc2e | |6e63945eb2df1 Distribution|--- |Slackware
--- Comment #3 from Ozan Türkyılmaz ozan.turkyilmaz@gmail.com --- I finished git bisect finally. 182feddd4b02e83f3c69863bc2e6e63945eb2df1 is the first bad commit commit 182feddd4b02e83f3c69863bc2e6e63945eb2df1 Author: Jactry Zeng jzeng@codeweavers.com Date: Wed May 11 02:44:21 2022 -0500
dwmapi: Partially implement DwmGetCompositionTimingInfo().
This makes Tencent START cloud game client happy.
Signed-off-by: Jactry Zeng jzeng@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
dlls/dwmapi/dwmapi_main.c | 8 +++++++- dlls/dwmapi/tests/dwmapi.c | 29 +++++++++++++++++++++++++++++ 2 files changed, 36 insertions(+), 1 deletion(-)
https://bugs.winehq.org/show_bug.cgi?id=53038
--- Comment #4 from Jactry Zeng jactry92@gmail.com --- (In reply to Ozan Türkyılmaz from comment #3)
I finished git bisect finally. 182feddd4b02e83f3c69863bc2e6e63945eb2df1 is the first bad commit commit 182feddd4b02e83f3c69863bc2e6e63945eb2df1 Author: Jactry Zeng jzeng@codeweavers.com Date: Wed May 11 02:44:21 2022 -0500
dwmapi: Partially implement DwmGetCompositionTimingInfo(). This makes Tencent START cloud game client happy. Signed-off-by: Jactry Zeng <jzeng@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>
dlls/dwmapi/dwmapi_main.c | 8 +++++++- dlls/dwmapi/tests/dwmapi.c | 29 +++++++++++++++++++++++++++++ 2 files changed, 36 insertions(+), 1 deletion(-)
Thanks for the bisect test! Could you give it a try with the hack in bug 53035 to see if that help?
https://bugs.winehq.org/show_bug.cgi?id=53038
Maxime berillions@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |berillions@gmail.com
--- Comment #5 from Maxime berillions@gmail.com --- (In reply to Jactry Zeng from comment #4)
(In reply to Ozan Türkyılmaz from comment #3)
I finished git bisect finally. 182feddd4b02e83f3c69863bc2e6e63945eb2df1 is the first bad commit commit 182feddd4b02e83f3c69863bc2e6e63945eb2df1 Author: Jactry Zeng jzeng@codeweavers.com Date: Wed May 11 02:44:21 2022 -0500
dwmapi: Partially implement DwmGetCompositionTimingInfo(). This makes Tencent START cloud game client happy. Signed-off-by: Jactry Zeng <jzeng@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>
dlls/dwmapi/dwmapi_main.c | 8 +++++++- dlls/dwmapi/tests/dwmapi.c | 29 +++++++++++++++++++++++++++++ 2 files changed, 36 insertions(+), 1 deletion(-)
Thanks for the bisect test! Could you give it a try with the hack in bug 53035 to see if that help?
Hi Jactry,
For me the app crashes after : 020c:fixme:dwmapi:DwmSetWindowAttribute (00070054, 2, 0166F9C4, 4) stub 020c:fixme:dwmapi:DwmGetCompositionTimingInfo (00000000 0166EDE0) wine: Unhandled division by zero at address 00D8D92B (thread 020c), starting debugger..
I tried your hack in 53035, unfortunatly, it does not fix the issue.
https://bugs.winehq.org/show_bug.cgi?id=53038
Olivier F. R. Dierick o.dierick@piezo-forte.be changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |o.dierick@piezo-forte.be Ever confirmed|0 |1 Status|UNCONFIRMED |NEW
--- Comment #6 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- Hello,
Confirming Epic Games Launcher is affected by a regression introduced by the commit.
Hack v2 from bug 53035 doesn't fix the issue.
I also tried setting info->rateRefresh to 1:64 but the issue persists.
I sent a modified dwmapi test to the Wine Testbot to check which values are non-zero on actual Windows machines: https://testbot.winehq.org/JobDetails.pl?Key=115303
The DWM_TIMING_INFO members that don't show in the failed result have the value '1'.
Regards.
https://bugs.winehq.org/show_bug.cgi?id=53038
Olivier F. R. Dierick o.dierick@piezo-forte.be changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|user32 |dwmapi
https://bugs.winehq.org/show_bug.cgi?id=53038
--- Comment #7 from Jactry Zeng jactry92@gmail.com --- Created attachment 72420 --> https://bugs.winehq.org/attachment.cgi?id=72420 hack
Thanks Olivier! Epic also needs qpcRefreshPeriod to be filled. The attached hack should make it work again.
I will try to fix it in upstream.
https://bugs.winehq.org/show_bug.cgi?id=53038
--- Comment #8 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- (In reply to Jactry Zeng from comment #7)
Created attachment 72420 [details] hack
Thanks Olivier! Epic also needs qpcRefreshPeriod to be filled. The attached hack should make it work again.
I will try to fix it in upstream.
Hello,
It fixes the issue for me. Thanks.
Regards.
https://bugs.winehq.org/show_bug.cgi?id=53038
--- Comment #9 from Ozan Türkyılmaz ozan.turkyilmaz@gmail.com --- The attached hack worked for me as well. Epic now starts fine.
https://bugs.winehq.org/show_bug.cgi?id=53038
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Epic Launcher Crash at |Epic Games Launcher crashes |Start: Unhandled exception: |on start |divide by zero in 64-bit | |code | Keywords| |download, patch, regression URL| |https://launcher-public-ser | |vice-prod06.ol.epicgames.co | |m/launcher/api/installer/do | |wnload/EpicGamesLauncherIns | |taller.msi
https://bugs.winehq.org/show_bug.cgi?id=53038
Jactry Zeng jactry92@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|wine-bugs@winehq.org |jactry92@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=53038
winetaste@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |winetaste@gmx.net
https://bugs.winehq.org/show_bug.cgi?id=53038
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |leslie_alistair@hotmail.com Staged patchset| |https://github.com/wine-sta | |ging/wine-staging/tree/mast | |er/patches/dwmapi-DwmGetCom | |positionTimingInfo Status|NEW |STAGED
https://bugs.winehq.org/show_bug.cgi?id=53038
--- Comment #10 from Ozan Türkyılmaz ozan.turkyilmaz@gmail.com --- I tested staging patches now. WOrks fine.
https://bugs.winehq.org/show_bug.cgi?id=53038
Jactry Zeng jactry92@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|STAGED |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |5f680a1e1cecc8a3d1e875bb333 | |9acdec8139cd3
--- Comment #11 from Jactry Zeng jactry92@gmail.com --- Fixed by https://source.winehq.org/git/wine.git/?a=commit;h=5f680a1e1cecc8a3d1e875bb3339acdec8139cd3.
https://bugs.winehq.org/show_bug.cgi?id=53038
Jactry Zeng jactry92@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|jactry92@gmail.com |wine-bugs@winehq.org
https://bugs.winehq.org/show_bug.cgi?id=53038
Ozan Türkyılmaz ozan.turkyilmaz@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #12 from Ozan Türkyılmaz ozan.turkyilmaz@gmail.com --- I confirm it is fixed now. Epic starts fine.
https://bugs.winehq.org/show_bug.cgi?id=53038
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |RESOLVED
--- Comment #13 from Gijs Vermeulen gijsvrm@gmail.com --- The bug will be automatically closed when the next release goes live.
https://bugs.winehq.org/show_bug.cgi?id=53038
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #14 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 7.11.