[Bug 49676] New: winetricks galliumnine02 no longer installs

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49676

Bug ID: 49676
           Summary: winetricks galliumnine02 no longer installs
           Product: Wine
           Version: 5.13
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, regression, source
          Severity: normal
          Priority: P2
         Component: ntdll
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: 368e3a93b8da3641c53f260bb4c96d03d00d1080
      Distribution: Gentoo

Noticed while running winetricks-test against wine-5.14-132-g1ec8bf9b73. Bisect
shows it was:
368e3a93b8da3641c53f260bb4c96d03d00d1080 is the first bad commit
commit 368e3a93b8da3641c53f260bb4c96d03d00d1080
Author: Alexandre Julliard 
Date:   Thu Jul 9 09:59:08 2020 +0200

ntdll: Allocate the return buffer in the caller for
wine_nt_to_unix_file_name().

Signed-off-by: Alexandre Julliard

dlls/kernel32/path.c   | 18 +++++++++++++++---
 dlls/ntdll/directory.c |  4 ++--
 dlls/ntdll/ntdll.spec  |  2 +-
 dlls/ntdll/unix/file.c | 11 +++++++++--
 dlls/ntdll/unixlib.h   |  2 +-
 include/winternl.h     |  2 +-
 6 files changed, 29 insertions(+), 10 deletions(-)

interestingly, this affects galliumnine02/galliumnine03/galliumnine04, but not
galliumnine05 or galliumnine (which gets the latest release upstream, currently
05).

/home/austin/wine-git/wine ninewinecfg -e
wine: Unhandled page fault on read access to 00000000 at address F7AB823A
(thread 019c), starting debugger...
couldn't load main module (0)
Unhandled exception: page fault on read access to 0x00000000 in 32-bit code
(0xf7ab823a).
Register dump:
 CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b
 EIP:f7ab823a ESP:0031fa90 EBP:0031fac8 EFLAGS:00010206(  R- --  I   - -P- )
 EAX:0000003a EBX:00000000 ECX:00000028 EDX:00000002
 ESI:00824428 EDI:00000000
Stack dump:
0x0031fa90:  0000001c 7eb85000 0031fad8 0031fb14
0x0031faa0:  7eb86754 00823960 0031fac8 00824428
0x0031fab0:  0031fb0c 00823960 0031fae0 7eb85000
0x0031fac0:  0031fb0c 00823960 0031fb38 7eb8023c
0x0031fad0:  00000003 7eb86754 7eb800a5 7eb8023c
0x0031fae0:  0031fb0c 0031fb14 00000000 00000000
Backtrace:
=>0 0xf7ab823a (0x0031fac8)
  1 0x7eb8023c (0x0031fb38)
0xf7ab823a: cmpl    %eax,0x0(%ebx)

[Bug 49676] winetricks galliumnine02 no longer installs

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49676

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Zebediah Figura  ---
The calling convention for wine_nt_to_unix_file_name changed; presumably the
caller will need to update their code to account for this.

[Bug 49676] winetricks galliumnine02 no longer installs

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49676

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|NEW                         |RESOLVED

--- Comment #2 from Austin English  ---
Ah, thanks. Looks like 0.5 changed to use wine_get_unix_file_name() instead:
https://github.com/iXit/wine-nine-standalone/commit/72c2f487746fccfc57bdfe48...

given that it works in newer versions and it's broken because it's calling a
wine internal function, I'd say this is a WONTFIX.

[Bug 49676] winetricks galliumnine02 no longer installs

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49676

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Gijs Vermeulen  ---
Closing wontfix.