https://bugs.winehq.org/show_bug.cgi?id=52969
Bug ID: 52969 Summary: mshtml:script fails on up-to-date Windows 8.1 machines Product: Wine Version: unspecified Hardware: x86-64 OS: Windows Status: NEW Severity: normal Priority: P2 Component: mshtml Assignee: wine-bugs@winehq.org Reporter: fgouget@codeweavers.com
mshtml:script fails on up-to-date Windows 8.1 machines:
script.c:644: Test failed: L"/index.html?es5.js:Number toLocaleString: [0] got 0.00" script.c:644: Test failed: L"/index.html?es5.js:Number toLocaleString: [1] got 1,234.50" script.c:644: Test failed: L"/index.html?es5.js:Number toLocaleString: [2] got -1,337.73" script.c:644: Test failed: L"/index.html?es5.js:Number toLocaleString: [3] got -0.01" script.c:644: Test failed: L"/index.html?es5.js:Number toLocaleString: [5] got 0.00" script.c:644: Test failed: L"/index.html?es5.js:Number toLocaleString: [6] got 99.00" script.c:644: Test failed: L"/index.html?es5.js:Number toLocaleString: [7] got 99.00" script.c:644: Test failed: L"/index.html?es5.js:Number toLocaleString: [8] got 65,536.50" script.c:644: Test failed: L"/index.html?es5.js:Number toLocaleString: called on string threw 2148144009" script.c:644: Test failed: L"/index.html?es5.js:Number toLocaleString: called on undefined threw 2148144009" script.c:644: Test failed: L"/index.html?es5.js:Number toLocaleString: called on nullDisp threw 2148144009"
https://test.winehq.org/data/patterns.html#mshtml:script
These failures only happen on the cw-gtx560 and cw-rx460 Windows 8.1 machines. I suspect this is because these have more recent Windows updates than the TestBot's w8 and w864 machines (see bug 52858). More specifically cw-rx460 has had more recent updates than cw-gtx560 for quite some time and I further updated both on 2022-05-02.
I further plan to update the TestBot's VM (the rationale being that Windows 8.1 is old and we really only care about the latest version) which should make it easier to debug. In the meantime this does seem like a regression.
commit 8aefdf48f9846e05aeef3c7ce2374401982b98b4 Author: Gabriel Ivăncescu gabrielopcode@gmail.com Date: Tue May 3 18:17:06 2022 +0300
jscript: Implement Number.prototype.toLocaleString.
Signed-off-by: Gabriel Ivăncescu gabrielopcode@gmail.com Signed-off-by: Jacek Caban jacek@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
https://bugs.winehq.org/show_bug.cgi?id=52969
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |8aefdf48f9846e05aeef3c7ce23 | |74401982b98b4 Keywords| |regression, source, | |testcase
https://bugs.winehq.org/show_bug.cgi?id=52969
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |gabrielopcode@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=52969
--- Comment #1 from Gabriel Ivăncescu gabrielopcode@gmail.com --- This looks like it uses jscript behavior for some reason. It might be a bug in the updated Win8, but since it's locale stuff, which doesn't have to be consistent, who knows.
I think the best fix is to simply skip the tests in such case, I'll send a patch.
https://bugs.winehq.org/show_bug.cgi?id=52969
Gabriel Ivăncescu gabrielopcode@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |83651996dbe146d09481409b564 | |045d09194b805 Resolution|--- |FIXED Status|NEW |RESOLVED
--- Comment #2 from Gabriel Ivăncescu gabrielopcode@gmail.com --- Should be fixed by 83651996dbe146d09481409b564045d09194b805.
https://bugs.winehq.org/show_bug.cgi?id=52969
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #3 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 7.9.