[Bug 55205] New: Fixed scancodes patchset partially breaks keyboard input in NFS Underground

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55205

Bug ID: 55205
           Summary: Fixed scancodes patchset partially breaks keyboard
                    input in NFS Underground
           Product: Wine-staging
           Version: 8.11
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail], [e-mail]
      Distribution: ArchLinux

Created attachment 74801
  --> https://bugs.winehq.org/attachment.cgi?id=74801
x11drv,+dinput,+keyboard,+key log with autodetection disabled

Hello,

So NFS Underground (and likely Underground 2 considering it also uses ActionMap
stuff) has partially broken keyboard input with wine-staging if the fixed
scancodes patchset is enabled

The first thing you notice in the main menu is that the arrow keys don't work
at all

Also the mappings you set in vanilla Wine/wine-staging without the patchset
have slightly changed if you can actually get into the mapping menu (this is
with a standard US QWERTY layout by the way)

What's interesting is if you enable scancode autodetection in winecfg things go
back to normal

I have attached a +x11drv,+dinput,+keyboard,+key log with scancode
autodetection disabled (I'll send another log with that option enabled after
submitting this bug because of Bugzilla limitations)

[Bug 55205] Fixed scancodes patchset partially breaks keyboard input in NFS Underground

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55205

--- Comment #1 from Aida Jonikienė  ---
Created attachment 74802
  --> https://bugs.winehq.org/attachment.cgi?id=74802
x11drv,+dinput,+keyboard,+key log with autodetection enabled

[Bug 55205] Fixed scancodes patchset partially breaks keyboard input in NFS Underground

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55205

Rémi Bernon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Rémi Bernon  ---
Created attachment 74803
  --> https://bugs.winehq.org/attachment.cgi?id=74803
Possible fix

I believe this may fix the issue.

[Bug 55205] Fixed scancodes patchset partially breaks keyboard input in NFS Underground

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55205

Rémi Bernon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74803|0                           |1
        is obsolete|                            |

--- Comment #3 from Rémi Bernon  ---
Created attachment 74804
  --> https://bugs.winehq.org/attachment.cgi?id=74804
Updated fix

Sorry, this one's better

[Bug 55205] Fixed scancodes patchset partially breaks keyboard input in NFS Underground

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55205

--- Comment #4 from Rémi Bernon  ---
Created attachment 74805
  --> https://bugs.winehq.org/attachment.cgi?id=74805
Updated fix

Having duplicated scancodes may be causing some issues too, what about this?

[Bug 55205] Fixed scancodes patchset partially breaks keyboard input in NFS Underground

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55205

--- Comment #5 from Aida Jonikienė  ---
With the latest version of Remi's dinput patch both of my issues have been
resolved (waiting for the patch to be upstreamed now)

[Bug 55205] Fixed scancodes patchset partially breaks keyboard input in NFS Underground

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55205

Aida Jonikienė  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |a6448966cfed4cd9ad0eceffc2b
                   |                            |4c51ea60356ad
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #6 from Aida Jonikienė  ---
With the fix landing as a staging patchset which appeared in the 8.12 release
it should be safe to close this now

[Bug 55205] Fixed scancodes patchset partially breaks keyboard input in NFS Underground

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55205

Aida Jonikienė  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Aida Jonikienė  ---
Someone forgot to close this so I'll do it myself