[Bug 55108] New: xaudio2_8:xaudio2 fails on Windows 10+

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55108

Bug ID: 55108
           Summary: xaudio2_8:xaudio2 fails on Windows 10+
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: xaudio2
          Assignee: [e-mail]
          Reporter: [e-mail]

xaudio2_8:xaudio2 fails on Windows 10+:

xaudio2.c:1218: Test failed: Got hr 0x80004002.

See https://test.winehq.org/data/patterns.html#xaudio2_8:xaudio2

Note that this is the same failure as what happened on Windows 8 in the late
stages described in bug 55016.

A bisect shows that this failure started with the commit below:

commit e8b0e7c1fcf090ba80c543f68b0bdae185316327
Author: Zebediah Figura 
Date:   Fri Jun 16 15:13:14 2023 -0500

xaudio2/tests: Fix the IID_IXAudio28 declaration.

This was accidentally copied from the 2.9 version instead in 14c44d0b0.

[Bug 55108] xaudio2_8:xaudio2 fails on Windows 10+

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55108

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |e8b0e7c1fcf090ba80c543f68b0
                   |                            |bdae185316327
           Keywords|                            |regression, source,
                   |                            |testcase

[Bug 55108] xaudio2_8:xaudio2 fails on Windows 10+

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55108

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 55108] xaudio2_8:xaudio2 fails on Windows 10+

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55108

Jeff Smith  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Jeff Smith  ---
Note that on Win 10, xaudio2_8.dll is <4KB, so it probably just forwards
everything to xaudio2_9.dll, and thus we get the same result with either. 
So...

On Windows 8, XAudio2Create() returns an 'IID_IXAudio28' interface.
On Windows 10, XAudio2Create() returns an 'IID_IXAudio29' interface.

I created a fix that accepts both IID_IXAudio28 and IID_IXAudio29 as valid.
https://gitlab.winehq.org/wine/wine/-/merge_requests/3716

[Bug 55108] xaudio2_8:xaudio2 fails on Windows 10+

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55108

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |5c1f9012947bd38b733fcbbaf5d
                   |                            |6cda0c9b58cbe
             Status|NEW                         |RESOLVED

--- Comment #2 from François Gouget  ---
This was fixed by the commit below:

commit 5c1f9012947bd38b733fcbbaf5d6cda0c9b58cbe
Author: Jeff Smith 
Date:   Sat Sep 2 21:21:03 2023 -0500

xaudio2/tests: Improve IID_IXAudio2 interface version checking.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55108

Thanks Jeff!

[Bug 55108] xaudio2_8:xaudio2 fails on Windows 10+

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55108

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  ---
Closing bugs fixed in 8.18.