[Bug 54377] New: Rayman Origins has messed up rendering due to missing 'tan' handling

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54377

Bug ID: 54377
           Summary: Rayman Origins has messed up rendering due to missing
                    'tan' handling
           Product: vkd3d
           Version: 1.6
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: hlsl
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

0218:err:d3dcompiler:D3DCompile2 Shader log:
0218:err:d3dcompiler:D3DCompile2     <anonymous>:166:18: E5005: Function "tan"
is not defined.
0218:err:d3dcompiler:D3DCompile2

[Bug 54377] Rayman Origins has messed up rendering due to missing 'tan' handling

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54377

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |976fd67f5192d4922e24a7830f5
                   |                            |9fcb936fa50cc

--- Comment #1 from Gijs Vermeulen  ---
This seems to be fixed by:
https://gitlab.winehq.org/wine/vkd3d/-/commit/976fd67f5192d4922e24a7830f59fc...

[Bug 54377] Rayman Origins has messed up rendering due to missing 'tan' handling

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54377

--- Comment #2 from Nikolay Sivov  ---
This isn't really fixed. It won't work for SM3 shaders.

[Bug 54377] Rayman Origins has messed up rendering due to missing 'tan' handling

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54377

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #3 from Gijs Vermeulen  ---
In that case, reopening.

[Bug 54377] Rayman Origins has messed up rendering due to missing 'tan' handling

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54377

--- Comment #4 from Nikolay Sivov  ---
The "tan" function seems to compile for ps_2_0/ps_3_0. Please retest when
you'll have a moment.

[Bug 54377] Rayman Origins has messed up rendering due to missing 'tan' handling

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54377

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

--- Comment #5 from Gijs Vermeulen  ---
I can't see anything in the logs that refers to this issue anymore. Rendering
issues are still there, but the following failures are still present:

) E5017: Aborting due to not yet implemented feature: SM1 non-float expression.

-> bug 54778

) E5017: Aborting due to not yet implemented feature: Flatten "if" conditionals
branches.

-> bug 55080 (I think)

I'll go ahead and mark this one fixed.

[Bug 54377] Rayman Origins has messed up rendering due to missing 'tan' handling

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54377

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Nikolay Sivov  ---
Fixed with vkd3d 1.15.