http://bugs.winehq.org/show_bug.cgi?id=9664
Summary: Missing icon during MS Office 2000 installation Product: Wine Version: 0.9.45. Platform: Other OS/Version: other Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: wine-misc AssignedTo: wine-bugs@winehq.org ReportedBy: Ronny.Standtke@gmx.net
Created an attachment (id=8078) --> (http://bugs.winehq.org/attachment.cgi?id=8078) Screenshot showing the missing icon
When installing MS Office 2000 with wine 0.9.45 there is a missing icon. I will attach a screenshot.
http://bugs.winehq.org/show_bug.cgi?id=9664
Ronny Standtke Ronny.Standtke@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial
http://bugs.winehq.org/show_bug.cgi?id=9664
--- Comment #1 from Ronny Standtke Ronny.Standtke@gmx.net 2007-10-08 05:02:33 --- I tested with 0.9.46 and the bug is still there.
http://bugs.winehq.org/show_bug.cgi?id=9664
--- Comment #2 from Ronny Standtke Ronny.Standtke@gmx.net 2007-10-13 15:30:11 --- I tested with 0.9.47 and the bug is still there.
http://bugs.winehq.org/show_bug.cgi?id=9664
--- Comment #3 from Ronny Standtke Ronny.Standtke@gmx.net 2007-10-29 12:16:05 --- I tested with wine 0.9.48 and the bug is still there.
http://bugs.winehq.org/show_bug.cgi?id=9664
--- Comment #4 from Ronny Standtke Ronny.Standtke@gmx.net 2007-11-12 06:53:10 --- I tested with wine 0.9.49 and the bug is still there.
http://bugs.winehq.org/show_bug.cgi?id=9664
--- Comment #5 from Ronny Standtke Ronny.Standtke@gmx.net 2007-12-03 09:43:11 --- The icon is still missing when using wine 0.9.50.
http://bugs.winehq.org/show_bug.cgi?id=9664
--- Comment #6 from Ronny Standtke Ronny.Standtke@gmx.net 2007-12-16 11:27:15 --- Same bug in 0.9.51
http://bugs.winehq.org/show_bug.cgi?id=9664
--- Comment #7 from Ronny Standtke Ronny.Standtke@gmx.net 2007-12-30 15:56:57 --- The same bug is still in wine 0.9.52.
http://bugs.winehq.org/show_bug.cgi?id=9664
--- Comment #8 from Ronny Standtke Ronny.Standtke@gmx.net 2008-01-13 07:32:33 --- I tested with wine 0.9.53 and the bug is still there.
http://bugs.winehq.org/show_bug.cgi?id=9664
--- Comment #9 from Ronny Standtke Ronny.Standtke@gmx.net 2008-01-28 12:05:07 --- Same bug in 0.9.54.
http://bugs.winehq.org/show_bug.cgi?id=9664
--- Comment #10 from Austin English austinenglish@gmail.com 2008-06-16 13:03:33 --- Is this still an issue in current (1.0-rc5 or newer) wine?
http://bugs.winehq.org/show_bug.cgi?id=9664
--- Comment #11 from Ronny Standtke Ronny.Standtke@gmx.net 2008-06-16 14:22:32 --- Yes, I tested with 1.0rc5 and the bug is still there.
http://bugs.winehq.org/show_bug.cgi?id=9664
--- Comment #12 from Austin English austinenglish@gmail.com 2008-12-15 13:41:53 --- Is this still an issue in current (1.1.10 or newer) wine?
http://bugs.winehq.org/show_bug.cgi?id=9664
--- Comment #13 from Ronny Standtke Ronny.Standtke@gmx.net 2008-12-16 04:42:04 --- Yes, I just tested with 1.1.10 and the bug is still there.
http://bugs.winehq.org/show_bug.cgi?id=9664
--- Comment #14 from Austin English austinenglish@gmail.com 2009-06-16 14:21:17 --- Is this still an issue in current (1.1.23 or newer) wine?
http://bugs.winehq.org/show_bug.cgi?id=9664
--- Comment #15 from Ronny Standtke Ronny.Standtke@gmx.net 2009-06-16 16:12:42 --- Yes, I just tested with 1.1.23 and the bug is still there.
http://bugs.winehq.org/show_bug.cgi?id=9664
--- Comment #16 from Austin English austinenglish@gmail.com 2009-12-31 11:14:30 --- Probably still present.
http://bugs.winehq.org/show_bug.cgi?id=9664
--- Comment #17 from Wylda wylda@volny.cz 2010-01-01 10:08:52 --- Created an attachment (id=25484) --> (http://bugs.winehq.org/attachment.cgi?id=25484) No such problem here
Chmmm... Somewhat questionable, because i don't have such problem. All the following versions work for me:
* 0.9.60, 1.0.1, 1.1.22, wine-1.1.35-364-g9dc584d
Tested on "Microsoft Office 2000 SR-1 Premium (Czech Edition)".
http://bugs.winehq.org/show_bug.cgi?id=9664
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wylda@volny.cz
http://bugs.winehq.org/show_bug.cgi?id=9664
--- Comment #18 from Ronny Standtke Ronny.Standtke@gmx.net 2010-01-16 09:51:34 --- Looks like this bug is specific to the German Office version. I just tested with wine 1.1.36 and the issue is still there.
http://bugs.winehq.org/show_bug.cgi?id=9664
--- Comment #19 from Wylda wylda@volny.cz 2010-01-16 13:20:42 --- (In reply to comment #18)
Looks like this bug is specific to the German Office version. I just tested with wine 1.1.36 and the issue is still there.
And isn't this a MS Office bug? I mean did you test the setup under real Windows?
http://bugs.winehq.org/show_bug.cgi?id=9664
--- Comment #20 from Ronny Standtke Ronny.Standtke@gmx.net 2010-01-17 11:05:46 --- Created an attachment (id=25774) --> (http://bugs.winehq.org/attachment.cgi?id=25774) screenshot of German MS Office 2000 installation in XP
Here is a screenshot of the same installation taking place in XP. All the icons are there...
http://bugs.winehq.org/show_bug.cgi?id=9664
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |focht@gmx.net
--- Comment #21 from Anastasius Focht focht@gmx.net 2010-01-17 12:02:22 --- Hello,
you could provide a +tid,+seh,+relay,+msi,+resource log up to the point where this install dialog appears (wineserver -k it in console without going further). But I doubt one can find this missing resource display problem by looking at logs alone.
If you can provide a (compressed) dump of install media of this specific Office 2k version to a private location (download addr by email) I could look into it. Otherwise you're pretty much out of luck.
Regards
http://bugs.winehq.org/show_bug.cgi?id=9664
--- Comment #22 from Wylda wylda@volny.cz 2010-02-27 07:23:11 ---
Hi Ronny, could you provide traces as requested in comment #21?
BTW: Czech edition still works even in wine-1.1.39-163-g583f0f0. End of ping ;)
http://bugs.winehq.org/show_bug.cgi?id=9664
--- Comment #23 from Ronny Standtke Ronny.Standtke@gmx.net 2010-03-01 13:22:51 --- OK, private mail sent to Anastasius & Wylda.
http://bugs.winehq.org/show_bug.cgi?id=9664
--- Comment #24 from Anastasius Focht focht@gmx.net 2010-03-02 15:31:41 --- Hello,
thanks for the german Office2K installation package, it was a matter of minutes to track it down ;-)
Fortunately Microsoft installer swiss army knife "ORCA" came once again to help.
Using ORCA's dialog preview feature one can quickly reproduce the problem (missing image on pushbutton control):
Load DATA1.MSI with ORCA. Menu: Tools -> Dialog Preview -> choose "ReadyToInstall" Dialog
You see the second "Customize" pushbutton image is indeed missing.
NOTE: If you choose "done" in dialog preview, the dialog gets ghosted (never closes). This seems to be another wine bug.
---
Dumping the "Control" table for "ReadyToInstall" dialog reveals the following:
--- snip --- ... Dialog_ Control Type X Y Width Height Attributes Property Text Control_Next Help s0 s0 s0 i2 i2 i2 i2 I4 S0 L0 S0 L0
ReadyToInstall BlackBar Bitmap 1 1 449 4 262145 BlackBar ReadyToInstall CornerGraphic Bitmap 1 4 126 48 262145 CornerGraphic InstallNowText ReadyToInstall WhiteBar Bitmap 1 1 126 280 262145 WhiteBar CornerGraphic ReadyToInstall Back PushButton 317 285 62 18 3 << &Zurück Cancel ReadyToInstall Cancel PushButton 204 285 62 18 3 Abbrechen HelpButton ReadyToInstall BarLabelSetup Text 4 57 121 18 65539 {\Tahoma8BlackBold}SETUP ReadyToInstall BLCollecting Text 4 75 121 25 65539 {\Tahoma8Black}Kundeninformationen ReadyToInstall BLEULA Text 4 100 121 25 65539 {\Tahoma8Black}Lizenzierung und Support ReadyToInstall BLInstalling Text 4 150 121 25 65539 {\Tahoma8Black}[ProductNameBase] wird installiert ReadyToInstall BLReady Text 4 125 121 25 65539 {\Tahoma8BlackBold}Zur Installation bereit ReadyToInstall BottomLine Line 1 279 449 2 1 line ReadyToInstall HelpButton PushButton 138 285 62 18 3 &Hilfe WhiteBar ReadyToInstall Next PushButton 383 285 62 18 1 &Weiter >> Back ReadyToInstall Label4 Text 139 12 305 25 65539 {\TahomaBold8}Das Setup-Programm ist bereit, [ProductName] zu installieren. ReadyToInstall Label25 Text 139 143 305 24 2 {\Tahoma8Black}...oder klicken Sie auf "Benutzerdefiniert" und machen Sie weitere Angaben zu Ihrer [ProductNameBase]-Installation. ReadyToInstall Label8 Text 139 38 305 22 2 {\Tahoma8Black}Klicken Sie auf "Jetzt installieren", um mit der Installation von [ProductNameBase] zu beginnen. ReadyToInstall InstallNowText Text 192 60 252 12 65539 {\TahomaBold8}[TYPICALINSTALLTEXT] InstallNow ReadyToInstall CustomInstallText Text 192 179 252 37 65539 {\Tahoma8Black}[CUSTOMINSTALLDESCRIPTION] ReadyToInstall Customize PushButton 139 167 45 45 7864323 {\Tahoma8Black}CustomIcon Next Benutzerdefiniert| ReadyToInstall CustomizeText Text 192 167 252 12 65539 {\TahomaBold8}[CUSTOMINSTALLTEXT] Customize ReadyToInstall IEInstallNoPrevText Text 192 72 252 13 65539 {\Tahoma8Black}[IEInstallNowText] ReadyToInstall IEInstallText Text 192 83 252 13 65539 {\Tahoma8Black}[IEInstallNowText] ReadyToInstall InstallNow PushButton 139 60 45 45 7864323 TypicalIcon CustomizeText Typisch| ReadyToInstall Label25Prop Text 139 143 305 24 2 {\Tahoma8Black}[CUSTOMINSTALLHEADER] ReadyToInstall Label8c Text 139 38 305 22 2 {\Tahoma8Black}Klicken Sie auf "Jetzt aktualisieren", um mit der Installation von [ProductNameBase] zu beginnen. ReadyToInstall Label8cProp Text 139 38 305 22 2 {\Tahoma8Black}[TYPICALUPGRADEHEADER] ReadyToInstall Label8Prop Text 139 38 305 22 2 {\Tahoma8Black}[TYPICALINSTALLHEADER] ReadyToInstall TypicalInstallText Text 192 72 252 37 65539 {\Tahoma8Black}[ProductNameNonQualifiedShort] nach [DefaultInstallLocation] installieren ReadyToInstall TypicalInstallText2 Text 192 83 252 37 65539 [ProductNameNonQualifiedShort] nach [DefaultInstallLocation] installieren ReadyToInstall TypicalInstallText3 Text 192 94 252 37 65539 [ProductNameNonQualifiedShort] nach [DefaultInstallLocation] installieren ReadyToInstall TypicalInstallTextProp Text 192 72 252 37 65539 {\Tahoma8Black}[TYPICALINSTALLDESCRIPTION] ReadyToInstall TypicalRemovePreviousText Text 192 72 252 12 65539 {\Tahoma8Black}Ältere Versionen von [ProductNameBase] entfernen ReadyToInstall UpgradeNowText Text 192 60 252 12 65539 {\TahomaBold8}[TYPICALUPGRADETEXT] ... --- snip ---
Tracing the "good" case for "InstallNow" pushbutton control:
--- snip --- ... 0045:trace:msi:msi_dialog_button_control 0x610d30 0x615f40 0045:trace:msi:msi_dialog_add_control L"BUTTON", L"InstallNow", 00780003, L"TypicalIcon", 00010040 ... 0045:Call user32.CreateWindowExW(00000000,686c31ee L"BUTTON",00619f98 L"TypicalIcon",50010040,000000b9,00000050,0000003c,0000003c,000903e6,00000000,00000000,00000000) ret=686622d8 ... 0045:trace:msi:msi_dialog_create_window Dialog L"ReadyToInstall" control L"TypicalIcon" hwnd 0x3032c ... 0045:trace:msi:msi_load_image 0x19b098 L"TypicalIcon" 48 48 00000010 ... 0045:trace:msi:MSI_DatabaseOpenViewW L"select * from Binary where `Name` = 'TypicalIcon'" 0x32e298 ... 0045:Call KERNEL32.lstrlenW(0061a3d8 L"Binary.TypicalIcon") ret=686a4d79 ... 0045:trace:msi:db_get_raw_stream L"\430b\4131\4735\3f7e\44fc\41ac\43e4\4192\4472" ... 0045:Call shlwapi.SHCreateStreamOnFileW(0061a108 L"C:\users\focht\Temp\msi7230.tmp",00000012,0032e274) ret=686906ea ... 0045:Call user32.LoadImageW(00000000,0061a108 L"C:\users\focht\Temp\msi7230.tmp",00000001,00000030,00000030,00000010) ret=68662622 ... 0045:Ret user32.LoadImageW() retval=00060328 ret=68662622 ... 0045:Call KERNEL32.DeleteFileW(0061a108 L"C:\users\focht\Temp\msi7230.tmp") ret=6866263e ... 0045:Call window proc 0x685c0e41 (hwnd=0x3032c,msg=BM_SETIMAGE,wp=00000001,lp=00060328) --- snip ---
Tracing the "bad" case for "Customize" pushbutton control:
--- snip --- ... 0045:trace:msi:msi_dialog_button_control 0x610d30 0x615f40 0045:trace:msi:msi_dialog_add_control L"BUTTON", L"Customize", 00780003, L"{\Tahoma8Black}CustomIcon", 00010040 ... 0045:Call user32.CreateWindowExW(00000000,686c31ee L"BUTTON",0061927e L"CustomIcon",50010040,000000b9,000000df,0000003c,0000003c,000903e6,00000000,00000000,00000000) ret=686622d8 ... 0045:trace:msi:msi_dialog_create_window Dialog L"ReadyToInstall" control L"{\Tahoma8Black}CustomIcon" hwnd 0x10034c ... 0045:trace:msi:msi_load_image 0x19b098 L"{\Tahoma8Black}CustomIcon" 48 48 00000010 ... 0045:trace:msi:MSI_DatabaseOpenViewW L"select * from Binary where `Name` = '{\Tahoma8Black}CustomIcon'" 0x32e298 ... 0045:Call window proc 0x685c0e41 (hwnd=0x10034c,msg=BM_SETIMAGE,wp=00000001,lp=00000000) --- snip ---
Wine must strip any RTF-ismns from string/text fields that are potentially used as lookup keys in tables (example: stream names in binary table).
E.g. text field "{\Tahoma8Black}CustomIcon" should become "CustomIcon" before lookup/query expression.
Also it would be helpful if an ERR is printed in case the icon resource can't be loaded - similar what's being done in dlls/dialog.c:msi_dialog_bitmap_control().
dlls/dialog.c:msi_dialog_button_control -> msi_load_icon -> msi_load_image
Regards
http://bugs.winehq.org/show_bug.cgi?id=9664
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |msi
--- Comment #25 from Nikolay Sivov bunglehead@gmail.com 2010-03-02 16:06:14 --- Thanks, Anastasius. Changing component.
http://bugs.winehq.org/show_bug.cgi?id=9664
--- Comment #26 from Hans Leidekker hans@meelstraat.net 2010-03-03 03:23:22 --- Created an attachment (id=26584) --> (http://bugs.winehq.org/attachment.cgi?id=26584) msi: Strip leading text style label from control text before lookup in binary table.
This patch should fix it.
http://bugs.winehq.org/show_bug.cgi?id=9664
--- Comment #27 from Austin English austinenglish@gmail.com 2010-03-03 11:41:10 --- (In reply to comment #26)
Created an attachment (id=26584)
--> (http://bugs.winehq.org/attachment.cgi?id=26584) [details]
msi: Strip leading text style label from control text before lookup in binary table.
This patch should fix it.
Patch committed: http://source.winehq.org/git/wine.git/?a=commitdiff;h=7b6858546c7a1ed05e4ea8...
Thanks Anastasius/Hans!
http://bugs.winehq.org/show_bug.cgi?id=9664
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #28 from Austin English austinenglish@gmail.com 2010-03-03 11:41:22 --- Gr...
http://bugs.winehq.org/show_bug.cgi?id=9664
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #29 from Alexandre Julliard julliard@winehq.org 2010-03-05 12:42:41 --- Closing bugs fixed in 1.1.40.
http://bugs.winehq.org/show_bug.cgi?id=9664
--- Comment #30 from Ronny Standtke Ronny.Standtke@gmx.net 2010-03-07 11:26:40 --- I can confirm that this bug is fixed now. Thanks!
http://bugs.winehq.org/show_bug.cgi?id=9664
Hans Leidekker hans@meelstraat.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |7b6858546c7a1ed05e4ea85a6f1 | |a387b75f3bb73
http://bugs.winehq.org/show_bug.cgi?id=9664
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Installer Hardware|Other |x86 OS|other |Linux
-
wine-bugs＠winehq.org