[Bug 50538] New: Wine child process exceptions are miscounted

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50538

Bug ID: 50538
           Summary: Wine child process exceptions are miscounted
           Product: Wine-Testbot
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

The "WTBS Crash in a child process (kernel32:toolhelp)." test case shows an
inconsistency in the test failures count between the Windows and Wine VMs.

On Windows we get:

1bec:toolhelp: unhandled exception c0000005 at 0054273D
toolhelp:471: unhandled exception c0000005 in child process 1bec
1750:toolhelp: 3 tests executed (0 marked as todo, 1 failure), 0 skipped.

Here there is 1 exception, 1 failure reported by the parent process but 2 error
lines, and the task's failure count ends up being 2.

But in Wine we get:

Unhandled exception: page fault on write access to 0x00000000 in 32-bit code
(0x00542c1d).
toolhelp:471: unhandled exception c0000005 in child process 0104
00fc:toolhelp: 3 tests executed (0 marked as todo, 1 failure), 0 skipped.

So there is still 1 exception, still 1 failure reported by the parent process,
still 2 error lines, but the task's failure count ends up being just 1.

The issue appears to be that ParseWineTestReport() (and probably dissect too)
detects ": unhandled exception...at" lines but not Wine's "Unhandled
exception:" ones.

This means the TestBot may fail to detect exceptions on Wine.

Meanwhile GetReportLineCategory() and _GetLineKey() detect both.

[Bug 50538] Wine child process exceptions are miscounted

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50538

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]

[Bug 50538] Wine child process exceptions are miscounted

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50538

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |5e7c5603ba0227e6a6f7421ca09
                   |                            |989f14d5bd810
             Status|NEW                         |RESOLVED

--- Comment #1 from François Gouget  ---
This is fixed both in the TestBot and in test.winehq.org:

commit 5e7c5603ba0227e6a6f7421ca09989f14d5bd810
Author: Francois Gouget 
Date:   Wed Feb 10 02:16:01 2021 +0100

testbot/LogUtils: Add support for winedbg's unhandled exception lines.

They replace the test framework's "unhandled exception" lines we get on
    Windows but specify neither the test unit nor the process pid. So just
    assign them to the current test unit.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50538
    Signed-off-by: Francois Gouget 
    Signed-off-by: Alexandre Julliard

commit 93b9a7e085713d815c5a26b756ef1ff7e7d2201f
Author: Francois Gouget 
Date:   Wed Feb 10 02:15:58 2021 +0100

winetest/dissect: Add support for winedbg's unhandled exception lines.

They replace the test framework's "unhandled exception" lines we get on
    Windows but specify neither the test unit nor the process pid. So just
    assign them to the current test unit.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50538
    Signed-off-by: Francois Gouget 
    Signed-off-by: Alexandre Julliard

[Bug 50538] Wine child process exceptions are miscounted

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50538

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from François Gouget  ---
Closing.