[Bug 16338] New: msxml3/tests/xmldoc: format not a string literal and no format arguments

http://bugs.winehq.org/show_bug.cgi?id=16338

Summary: msxml3/tests/xmldoc: format not a string literal and no
                    format arguments
           Product: Wine
           Version: 1.1.9
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Keywords: download, patch, source
          Severity: minor
          Priority: P2
         Component: build-env
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=17643)
 --> (http://bugs.winehq.org/attachment.cgi?id=17643)
patch

gcc -c -I. -I. -I../../../include -I../../../include   -D_REENTRANT -fPIC -Wall
-pipe -fno-strength-reduce -fno-strict-aliasing -Wdeclaration-after-statement
-Wwrite-strings -Wtype-limits -Wpointer-arith  -Werror  -o xmldoc.o xmldoc.c
cc1: warnings being treated as errors
xmldoc.c: In function ‘append_str’:
xmldoc.c:36: error: format not a string literal and no format arguments
make[2]: *** [xmldoc.o] Error 1
make[2]: Leaving directory `/home/austin/wine-git/dlls/msxml3/tests'
make[1]: *** [msxml3/tests] Error 2
make[1]: Leaving directory `/home/austin/wine-git/dlls'
make: *** [dlls] Error 2

Attached patch fixes the issue, but may not be a proper fix.

Only occurs on gcc 4.3+

[Bug 16338] msxml3/tests/xmldoc: format not a string literal and no format arguments

http://bugs.winehq.org/show_bug.cgi?id=16338

Vincent Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Vincent Povirk   2008-12-04 20:20:57 ---
The proper fix is most likely to use strcpy() or a similar (copy) function.
sprintf() is not needed here.

[Bug 16338] msxml3/tests/xmldoc: format not a string literal and no format arguments

http://bugs.winehq.org/show_bug.cgi?id=16338

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Austin English   2008-12-05 12:10:15 ---
Fixed, thanks Vincent!

[Bug 16338] msxml3/tests/xmldoc: format not a string literal and no format arguments

http://bugs.winehq.org/show_bug.cgi?id=16338

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard   2008-12-20 09:06:17 ---
Closing bugs fixed in 1.1.11.