http://bugs.winehq.org/show_bug.cgi?id=30392
Bug #: 30392 Summary: Amazon digital downloads down loader crashes upon use Product: Wine Version: 1.4 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: blocker Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: gamer@jdolson.net Classification: Unclassified
Created attachment 39732 --> http://bugs.winehq.org/attachment.cgi?id=39732 elven legacy trace
i have recently purchased a couple of games on amazon, games that are confirmed to work with wine, however Amazon gives you a small downloader file, and this downloader file crashes and cannot DL the games to install
linux mint 11 wine 1.4 Release: 11 (katya) Edition: Gnome 32-bit
Using built-in specs. COLLECT_GCC=gcc COLLECT_LTO_WRAPPER=/usr/lib/i386-linux-gnu/gcc/i686-linux-gnu/4.5.2/lto-wrapper Target: i686-linux-gnu Configured with: ../src/configure -v --with-pkgversion='Ubuntu/Linaro 4.5.2-8ubuntu4' --with-bugurl=file:///usr/share/doc/gcc-4.5/README.Bugs --enable-languages=c,c++,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-4.5 --enable-shared --enable-multiarch --with-multiarch-defaults=i386-linux-gnu --enable-linker-build-id --with-system-zlib --libexecdir=/usr/lib/i386-linux-gnu --without-included-gettext --enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.5 --libdir=/usr/lib/i386-linux-gnu --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --enable-plugin --enable-gold --enable-ld=default --with-plugin-ld=ld.gold --enable-objc-gc --enable-targets=all --disable-werror --with-arch-32=i686 --with-tune=generic --enable-checking=release --build=i686-linux-gnu --host=i686-linux-gnu --target=i686-linux-gnu Thread model: posix gcc version 4.5.2 (Ubuntu/Linaro 4.5.2-8ubuntu4)
not sure if this one helps, it is the link to the down load on amazon https://images-na.ssl-images-amazon.com/images/G/01/digital/infinity/button_...
Elven_Legacy_Collection_Downloader.exe
also
Swords_of_the_Star_Complete_Collection_Downloader.exe
http://bugs.winehq.org/show_bug.cgi?id=30392
--- Comment #1 from Jim gamer@jdolson.net 2012-04-09 02:49:22 CDT --- Created attachment 39733 --> http://bugs.winehq.org/attachment.cgi?id=39733 elven legacy downloader
http://bugs.winehq.org/show_bug.cgi?id=30392
--- Comment #2 from Jim gamer@jdolson.net 2012-04-09 02:51:54 CDT --- Created attachment 39734 --> http://bugs.winehq.org/attachment.cgi?id=39734 sword of the stars trace
http://bugs.winehq.org/show_bug.cgi?id=30392
--- Comment #3 from Jim gamer@jdolson.net 2012-04-09 02:53:02 CDT --- Created attachment 39735 --> http://bugs.winehq.org/attachment.cgi?id=39735 sword of the stars downloader
http://bugs.winehq.org/show_bug.cgi?id=30392
Jim gamer@jdolson.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #39733|application/octet-stream |application/ms dos mime type| |executable
http://bugs.winehq.org/show_bug.cgi?id=30392
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #39733|application/ms dos |application/x-ms-dos-execut mime type|executable |able
http://bugs.winehq.org/show_bug.cgi?id=30392
Vitaliy Margolen vitaliy-bugzilla@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |normal
--- Comment #4 from Vitaliy Margolen vitaliy-bugzilla@kievinfo.com 2012-04-09 07:56:41 CDT --- Not a blocker: http://bugs.winehq.org/page.cgi?id=fields.html#importance
Please upgrade to wine-1.5.1 and retest. If the problem persists, attach complete terminal output not just a backtrace. And make sure you do install wine debug symbols or compile Wine from source.
Instead of attaching executable files please post links in a future.
Admin: please remove 2 executable attachments.
http://bugs.winehq.org/show_bug.cgi?id=30392
--- Comment #5 from Rosanne DiMesio dimesio@earthlink.net 2012-04-09 10:54:57 CDT --- *** Bug 30391 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=30392
--- Comment #6 from Austin English austinenglish@gmail.com 2012-04-09 11:49:12 CDT --- The content of attachment 39733 has been deleted by Austin English austinenglish@gmail.com who provided the following reason:
Copyrighted file
The token used to delete this attachment was generated at 2012-04-09 11:49:06 CDT.
http://bugs.winehq.org/show_bug.cgi?id=30392
--- Comment #7 from Austin English austinenglish@gmail.com 2012-04-09 11:49:17 CDT --- The content of attachment 39735 has been deleted by Austin English austinenglish@gmail.com who provided the following reason:
Copyrighted file
The token used to delete this attachment was generated at 2012-04-09 11:49:15 CDT.
http://bugs.winehq.org/show_bug.cgi?id=30392
--- Comment #8 from Austin English austinenglish@gmail.com 2012-04-09 11:49:33 CDT --- (In reply to comment #4)
Not a blocker: http://bugs.winehq.org/page.cgi?id=fields.html#importance
Please upgrade to wine-1.5.1 and retest. If the problem persists, attach complete terminal output not just a backtrace. And make sure you do install wine debug symbols or compile Wine from source.
Instead of attaching executable files please post links in a future.
Admin: please remove 2 executable attachments.
Done.
http://bugs.winehq.org/show_bug.cgi?id=30392
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |focht@gmx.net Component|-unknown |user32 Summary|Amazon digital downloads |Amazon digital downloads |down loader crashes upon |down loader crashes upon |use |use (DrawText | |ellipsification fails on | |strings with very small | |width given) Ever Confirmed|0 |1
--- Comment #9 from Anastasius Focht focht@gmx.net 2012-04-09 12:24:52 CDT --- Hello,
confirming. I also requested the deletion of downloader binaries before writing anything. You purchased the content so it belongs to you, not to be shared.
With a quick-fix for this bug on my side I was actually able to start downloading the content. Don't worry, I didn't complete the download ;-)
The problem seems to be a DrawText ellipsification attempt on a string with a very small drawing rectangle (width) given.
--- snip --- ... 0025:Call user32.SetWindowTextW(00010080,004d9f40 L"Elven Legacy Collection") ret=0042efd9 0025:trace:msg:send_inter_thread_message hwnd 0x10080 msg c (WM_SETTEXT) wp 0 lp 4d9f40 ... 0024:Call window proc 0x7ebf56bb (hwnd=0x10080,msg=WM_SETTEXT,wp=00000000,lp=004d9f40) ... 0024:Ret window proc 0x7eb6fd93 (hwnd=0x60052,msg=WM_CTLCOLORSTATIC,wp=000003a8,lp=00010080) retval=0000010c /home/focht/projects/wine/wine-git/dlls/user32/text.c:719: TEXT_NextLineW: Assertion `pellip->under == 0 && pellip->after == 0' failed. 0024:trace:seh:raise_exception code=80000101 flags=1 addr=0xf77cd430 ip=f77cd430 tid=0024 0024:trace:seh:raise_exception eax=00000000 ebx=00003406 ecx=00003406 edx=00000006 esi=00000000 edi=f7622ff4 0024:trace:seh:raise_exception ebp=0032ec78 esp=0032ea14 cs=0023 ds=002b es=002b fs=0063 gs=006b flags=00000296 ... Backtrace: =>0 0xf77cd430 __kernel_vsyscall+0x10() in [vdso].so (0x0032ec78) 1 0xf74a898f gsignal+0x4e() in libc.so.6 (0x0032ec78) 2 0xf74aa2d5 abort+0x174() in libc.so.6 (0x0032ec78) 3 0xf74a16a5 __assert_fail_base+0x154() in libc.so.6 (0x0032ec78) 4 0xf74a1757 __assert_fail+0x56() in libc.so.6 (0x0032ec78) 5 0x7ebd943e TEXT_NextLineW+0x586(hdc=0x3a8, str="Elven Legacy Collection", count=0x32ed2c, dest="......en Legacy Collection?2??", len=0x32ed30, width=0xc, format=0x44060, retsize=0x32f538, last_line=0, p_retstr=0x32f534, tabwidth=0x30, pprefix_offset=0x32ecec, pellip=0x32ecdc) [/home/focht/projects/wine/wine-git/dlls/user32/text.c:719] in user32 (0x0032ec78) 6 0x7ebd9c74 DrawTextExW+0x4d7(hdc=0x3a8, str="Elven Legacy Collection", i_count=0xffffffff, rect=0x32f638, flags=0x44060, dtp=0x32f5ec) [/home/focht/projects/wine/wine-git/dlls/user32/text.c:948] in user32 (0x0032f5b8) 7 0x7ebda422 DrawTextW+0x8c(hdc=0x3a8, str="Elven Legacy Collection", count=0xffffffff, rect=0x32f638, flags=0x44070) [/home/focht/projects/wine/wine-git/dlls/user32/text.c:1132] in user32 (0x0032f608) ... --- snip ---
format 0x44060 = (DT_WORD_ELLIPSIS | DT_PATH_ELLIPSIS | DT_EXPANDTABS | DT_SINGLELINE)
Debugging session:
--- snip --- =>0 0x7ebd8eb7 TEXT_NextLineW(hdc=0x3a8, str="Elven Legacy Collection", count=0x33edb8, dest="", len=0x33edbc, width=0xc, format=0x44060, retsize=0x33f5c4, last_line=0, p_retstr=0x33f5c0, tabwidth=0x30, pprefix_offset=0x33ed78, pellip=0x33ed68) [/home/focht/projects/wine/wine-git/dlls/user32/text.c:590] in user32 (0x0033f644)
Wine-dbg>frame 1 1132 return DrawTextExW(hdc, (LPWSTR)str, count, rect, flags, &dtp); Wine-dbg>p *rect {left=0, top=0, right=0xc, bottom=0xd} --- snip ---
Very small drawing rectangle for the static control. The string won't fit at all, even ellipsified.
DT_PATH_ELLIPSIS being applied:
--- snip --- if (!line_fits && (format & DT_PATH_ELLIPSIS)) { TEXT_PathEllipsify (hdc, dest + seg_j, maxl-seg_j, &j_in_seg, max_seg_width, &size, *p_retstr, pellip); line_fits = (size.cx <= max_seg_width); ellipsified = 1; }
=>0 0x7ebd9327 TEXT_NextLineW+0x470(hdc=0x3a8, str="Elven Legacy Collection", count=0x33edb8, dest="...Elven Legacy Collection", len=0x33edbc, width=0xc, format=0x44060, retsize=0x33f
Wine-dbg>n 695 line_fits = (size.cx <= max_seg_width); Wine-dbg>n 696 ellipsified = 1; Wine-dbg>p line_fits 0 --- snip ---
DT_WORD_ELLIPSIS being applied:
--- snip --- if ((!line_fits && (format & DT_WORD_ELLIPSIS)) || ((format & DT_END_ELLIPSIS) && ((last_line && *count) || (remainder_is_none_or_newline (*count, &str[i]) && !line_fits)))) { int before, len_ellipsis; TEXT_Ellipsify (hdc, dest + seg_j, maxl-seg_j, &j_in_seg, max_seg_width, &size, *p_retstr, &before, &len_ellipsis);
Wine-dbg>p dest "......en Legacy Collection"
Wine-dbg>n 719 assert (pellip->under == 0 && pellip->after == 0); Wine-dbg>p *pellip {before=0, len=0x3, under=0, after=0x17} --- snip ---
Whoops ;-)
Loading the dialog resource into "Resource Hacker" tool yields:
--- snip --- 123 DIALOGEX 0, 0, 319, 94 STYLE DS_FIXEDSYS | DS_NOFAILCREATE | DS_MODALFRAME | DS_CENTER | WS_MINIMIZEBOX | WS_POPUP | WS_CAPTION | WS_SYSMENU EXSTYLE WS_EX_APPWINDOW CAPTION "Amazon Downloader" LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US FONT 8, "MS Shell Dlg", FW_NORMAL, FALSE, 0 { CONTROL "", 1001, STATIC, SS_BITMAP | WS_CHILD | WS_VISIBLE, 7, 7, 15, 13 CONTROL "", 1002, STATIC, SS_LEFT | SS_PATHELLIPSIS | WS_CHILD | WS_VISIBLE | WS_GROUP, 65, 7, 8, 8 CONTROL "", 1003, STATIC, SS_LEFT | WS_CHILD | WS_VISIBLE | WS_GROUP, 114, 7, 8, 8 CONTROL "", 1004, STATIC, SS_LEFT | WS_CHILD | WS_VISIBLE | WS_GROUP, 126, 7, 8, 8 CONTROL "", 1012, STATIC, SS_LEFT | SS_WORDELLIPSIS | WS_CHILD | WS_VISIBLE | WS_GROUP, 65, 19, 244, 8 , 0x00000020 CONTROL "Pause", 1005, BUTTON, BS_PUSHBUTTON | WS_CHILD | WS_DISABLED | WS_TABSTOP, 258, 35, 51, 14 CONTROL "Resume", 1006, BUTTON, BS_PUSHBUTTON | WS_CHILD | WS_DISABLED | WS_TABSTOP, 258, 35, 51, 14 CONTROL "", 1020, STATIC, SS_ETCHEDFRAME | WS_CHILD | WS_VISIBLE | WS_GROUP, 0, 56, 400, 1 CONTROL 103, 1022, STATIC, SS_BITMAP | SS_CENTERIMAGE | SS_REALSIZEIMAGE | WS_CHILD | WS_VISIBLE, 14, 64, 21, 2 --- snip ---
Dialog and first child control creation:
--- snip --- 0024:Call user32.CreateDialogParamW(00400000,0000007b,00000000,004320f0,004d8e10) ret=0042d6db ... 0024:trace:win:WIN_CreateWindowEx L"Amazon Downloader" #8002 ex=00050001 style=80ca08dc 717,466 485x178 parent=(nil) menu=(nil) inst=0x400000 params=(nil) 0024:trace:win:dump_window_styles style: WS_POPUP WS_CAPTION WS_SYSMENU WS_MINIMIZEBOX 000008dc 0024:trace:win:dump_window_styles exstyle: WS_EX_DLGMODALFRAME WS_EX_CONTROLPARENT WS_EX_APPWINDOW ... 0024:trace:win:GetWindowRect hwnd 0x60052 (717,466)-(1202,644) ... 0024:trace:win:WIN_CreateWindowEx created window 0x60052 ... 0024:trace:win:WIN_CreateWindowEx L"" L"Static" ex=00000004 style=5000000e 11,11 23x21 parent=0x60052 menu=0x3e9 inst=0x400000 params=(nil) 0024:trace:win:dump_window_styles style: WS_CHILD WS_VISIBLE 0000000e 0024:trace:win:dump_window_styles exstyle: WS_EX_NOPARENTNOTIFY ... 0024:trace:win:WIN_CreateWindowEx hwnd 0x1007e cs 11,11 23x21 ... 0024:trace:win:WIN_CreateWindowEx created window 0x1007e --- snip ---
Next, the child control in question which has id 1002 (0x3ea): The control has SS_PATHELLIPSIS set so it automatically becomes a single line control.
--- snip --- 0024:trace:win:WIN_CreateWindowEx L"" L"Static" ex=00000004 style=50028000 98,11 12x13 parent=0x60052 menu=0x3ea inst=0x400000 params=(nil) 0024:trace:win:dump_window_styles style: WS_CHILD WS_VISIBLE WS_GROUP 00008000 0024:trace:win:dump_window_styles exstyle: WS_EX_NOPARENTNOTIFY 0024:trace:win:WIN_SetWindowLong 0x10080 -12 3ea W 0024:trace:win:GetWindowRect hwnd 0x10080 (818,499)-(830,512) ... 0024:trace:win:WIN_CreateWindowEx hwnd 0x10080 cs 98,11 12x13 ... 0024:trace:win:WIN_CreateWindowEx created window 0x10080 ... 0024:Call dialog proc 0x4320f0 (hwnd=0x60052,msg=WM_INITDIALOG,wp=000100aa,lp=004d8e10) ... 0024:Call user32.GetDlgItem(00060052,000003ea) ret=00430cc6 0024:Ret user32.GetDlgItem() retval=00010080 ret=00430cc6 ... 0024:Call user32.SendMessageW(00010080,00000030,000003e8,00000000) ret=00430d38 0024:Call window proc 0x7ebf56bb (hwnd=0x10080,msg=WM_SETFONT,wp=000003e8,lp=00000000) 0024:trace:win:WIN_SetWindowLong 0x10080 0 3e8 W 0024:Ret window proc 0x7ebf56bb (hwnd=0x10080,msg=WM_SETFONT,wp=000003e8,lp=00000000) retval=00000000 0024:Ret user32.SendMessageW() retval=00000000 ret=00430d38 ... 0024:Call user32.GetWindowRect(00010080,0032f244) ret=00442269 0024:trace:win:GetWindowRect hwnd 0x10080 (818,499)-(830,512) 0024:Ret user32.GetWindowRect() retval=00000001 ret=00442269 ... --- snip ---
The control in question (hwnd=0x10080, id=1002) is not resized by app after creation to allow text to fit.
If you display/simulate the whole dialog in "Resource Hacker" tool (Dialog 123 -> 1033) the dialog layout seems a bit strange (many small/overlapping controls). Maybe the dialog resource is reused several times with some controls being made visible or hidden, depending on use case.
Not sure what should be done if the width is so small that even ellipsification alone "..." won't fit (truncation?).
I modified the code to better handle the case when width is too small for ellipsification and it helped: the downloader proceeds and actually starts to download the content.
Regards
http://bugs.winehq.org/show_bug.cgi?id=30392
Alex Bradbury asb@asbradbury.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |asb@asbradbury.org
http://bugs.winehq.org/show_bug.cgi?id=30392
Ben Klopfenstein benklop@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |benklop@gmail.com
--- Comment #10 from Ben Klopfenstein benklop@gmail.com 2013-05-15 02:01:29 CDT --- Do you have a patch with the change you made?
http://bugs.winehq.org/show_bug.cgi?id=30392
Ben Klopfenstein benklop@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |benklop@gmail.com
--- Comment #10 from Ben Klopfenstein benklop@gmail.com 2013-05-15 02:01:29 CDT --- Do you have a patch with the change you made?
--- Comment #11 from Ben Klopfenstein benklop@gmail.com 2013-05-15 02:18:46 CDT --- World of tanks downloaded through amazon for free, http://www.amazon.com/dp/B008B2VOEK/ref=hy-cat-f2p-gdl1?pf_rd_p=1550373782&a... is a good candidate for testing this free of charge, though a login account with the publisher (and Amazon) needs to be created.
http://bugs.winehq.org/show_bug.cgi?id=30392
--- Comment #12 from Austin English austinenglish@gmail.com 2013-06-15 18:27:00 CDT --- In 1.6-rc2, I don't get a crash, though I haven't been able to get it to download my game yet..
https://bugs.winehq.org/show_bug.cgi?id=30392
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME
--- Comment #13 from Austin English austinenglish@gmail.com --- (In reply to Austin English from comment #12)
In 1.6-rc2, I don't get a crash, though I haven't been able to get it to download my game yet..
WORKSFORME.
https://bugs.winehq.org/show_bug.cgi?id=30392
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #14 from Austin English austinenglish@gmail.com --- Closing.
https://bugs.winehq.org/show_bug.cgi?id=30392
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|WORKSFORME |---
--- Comment #15 from Nikolay Sivov bunglehead@gmail.com --- Reopening, this bug has a better summary and issue analysis in comment 9.
https://bugs.winehq.org/show_bug.cgi?id=30392
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |aleksander.smirnoff@gmail.c | |om
--- Comment #16 from Nikolay Sivov bunglehead@gmail.com --- *** Bug 14093 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=30392
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sasha969@hotmail.com
--- Comment #17 from Nikolay Sivov bunglehead@gmail.com --- *** Bug 39624 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=30392
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Amazon digital downloads |Multiple applications hit |down loader crashes upon |DrawText assert (Amazon |use (DrawText |downloader, 1C Accounting, |ellipsification fails on |TeamViewer) - |strings with very small |ellipsification fails on |width given) |strings with very small | |width given)
https://bugs.winehq.org/show_bug.cgi?id=30392
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Multiple applications hit |Multiple applications hit |DrawText assert (Amazon |DrawText assert (Amazon |downloader, 1C Accounting, |downloader, 1C Accounting, |TeamViewer) - |TeamViewer) - |ellipsification fails on |ellipsification fails on |strings with very small |strings with very small |width given) |width given
https://bugs.winehq.org/show_bug.cgi?id=30392
Ivan Baldo ibaldo@adinet.com.uy changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ibaldo@adinet.com.uy
https://bugs.winehq.org/show_bug.cgi?id=30392
--- Comment #18 from SaleX sasha969@hotmail.com --- TeamViewer now show window normally.
wine-2.11 Linux Mint 18.2 "Sonya" x86_64
https://bugs.winehq.org/show_bug.cgi?id=30392
Louis Lenders xerox.xerox2000x@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |saif.raza93@gmail.com
--- Comment #19 from Louis Lenders xerox.xerox2000x@gmail.com --- *** Bug 39588 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=30392
Louis Lenders xerox.xerox2000x@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |atnaguzin@gmail.com
--- Comment #20 from Louis Lenders xerox.xerox2000x@gmail.com --- *** Bug 38229 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=30392
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |adamcroteau@comcast.net
--- Comment #21 from Zebediah Figura z.figura12@gmail.com --- *** Bug 47168 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=30392
pattietreutel katyaberezyaka@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |katyaberezyaka@gmail.com
-
wine-bugs＠winehq.org