[Bug 56658] New: When using Kosugi for vertical writing, some punctuation marks are not placed correctly.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56658

Bug ID: 56658
           Summary: When using Kosugi for vertical writing, some
                    punctuation marks are not placed correctly.
           Product: Wine
           Version: 9.8
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: gdi32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: Ubuntu

Created attachment 76433
  --> https://bugs.winehq.org/attachment.cgi?id=76433
Vertical writing comparison (Orange squares added for emphasis)

When using Kosugi, a Japanese font designed by MOTOYA[1], for vertical writing,
some punctuation marks are not placed correctly. Ume Gothic[2], another
Japanese font, doesn't have this issue. See the attachment for details.

Steps to Reproduce:
1. Install Kosugi font, Kosugi-Regular.ttf, to your font directory.
   SHA1(Kosugi-Regular.ttf) = fb02b5f57e8652a1fd499195d7070bafd58e16e2
2. Download Mery Text Editor Ver 3.7.1[3] and unzip it.
   SHA1(MeryPortable-3.7.1.zip) = 8355bbf8919bade31bf333731167b48cb47d9e5e
3. Launch Mery editor with Japanese locale,
   i.e. % LANG=ja_JP.UTF-8 wine Mery.exe
4. Choose Kosugi font in ツール(T) - オプション(O) - 表示 - フォント(F).
5. Enable vertical writing view at 表示(V) - 縦書き(V).
6. Copy and paste the following Japanese text:
   あのイーハトーヴォのすきとおった風、夏でも底に冷たさをもつ青いそら、うつくしい森で飾られたモリーオ市、郊外のぎらぎらひかる草の波。

Actual results:
   "。" and "、" are placed in the lower left hand corner of the square.
   See the left side of the attached image, Kosugi.

Expected results:
   "。" and "、" are placed in the upper right hand corner of the square.
   See the right side of the attached image, Ume Gothic.

[1] https://fonts.google.com/specimen/Kosugi
[2] https://ja.osdn.net/projects/ume-font/wiki/FrontPage
[3] https://www.haijin-boys.com/download/MeryPortable-3.7.1.zip

[Bug 56658] When using Kosugi for vertical writing, some punctuation marks are not placed correctly.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56658

Sagawa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

--- Comment #1 from Sagawa  ---
This is due to glyph substitution not working.
I am investigating this issue and will send an MR when it is ready.

[Bug 56658] When using Kosugi for vertical writing, some punctuation marks are not placed correctly.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56658

--- Comment #2 from Sagawa  ---
Despite our comparison to 'dflt'[1], the font file and OpenType
specification[2] uses 'DFLT' for default script tag. This is the cause of
Kosugi font issue.

While trying out another Google Font, I noticed that KaiseiOpti[3] had more
complicated problems. The GSUB table in the font contains the kana and DFLT
script tags. However, the vert/vrt2 feature is not listed in the kana script.
Instead, it's in the default script. Therefore, we need to fallback to the
default script in this case.

[1]
https://gitlab.winehq.org/wine/wine/-/blame/wine-9.8/dlls/win32u/font.c?ref_...
[2]
https://learn.microsoft.com/en-us/typography/opentype/spec/chapter2#slTbl_sR...
[3] https://fonts.google.com/specimen/Kaisei+Opti

[Bug 56658] When using Kosugi for vertical writing, some punctuation marks are not placed correctly.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56658

--- Comment #3 from Sagawa  ---
I sent MR, https://gitlab.winehq.org/wine/wine/-/merge_requests/5633 .

[Bug 56658] When using Kosugi for vertical writing, some punctuation marks are not placed correctly.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56658

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://www.haijin-boys.com
                   |                            |/download/MeryPortable-3.7.
                   |                            |1.zip
           Keywords|                            |localization, patch

[Bug 56658] When using Kosugi for vertical writing, some punctuation marks are not placed correctly.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56658

--- Comment #4 from Sagawa  ---
Created attachment 76795
  --> https://bugs.winehq.org/attachment.cgi?id=76795
Vertical writing demo with Kosugi

I wrote a demo to show vertical writing without Mery editor.
Please don't forget to install Kosugi font before testing.

[Bug 56658] When using Kosugi for vertical writing, some punctuation marks are not placed correctly.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56658

Sagawa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
      Fixed by SHA1|                            |e12815134968cee82ba098083d9
                   |                            |bbe90abc7e445

--- Comment #5 from Sagawa  ---
Fixed by e12815134968cee82ba098083d9bbe90abc7e445.

[Bug 56658] When using Kosugi for vertical writing, some punctuation marks are not placed correctly.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56658

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 10.1.