[Bug 55652] New: A FindResourceW() call prevents windows.applicationmodel:model from running on Windows 8

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55652

Bug ID: 55652
           Summary: A FindResourceW() call prevents
                    windows.applicationmodel:model from running on Windows
                    8
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]

A FindResourceW() call prevents windows.applicationmodel:model from running on
Windows 8:

model.c:0: Tests skipped: missing entry point (details below)
| windows.applicationmodel_test.exe - Entry Point Not Found
| The procedure entry point FindResourceW could not be located in the dynamic
link library C:\Users\winetest\Documents\windows.applicationmodel_test.exe.

See https://test.winehq.org/data/patterns.html#windows.applicationmodel:model

This is caused by this commit:

commit 8609fef5c822e32998725bad58582764d289c194
Author:     Rémi Bernon 
AuthorDate: Wed Aug 23 11:21:33 2023 +0200

windows.applicationmodel/tests: Test IPackageManager_RegisterPackageAsync.

[Bug 55652] A FindResourceW() call prevents windows.applicationmodel:model from running on Windows 8

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55652

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression, source,
                   |                            |testcase
    Regression SHA1|                            |8609fef5c822e32998725bad585
                   |                            |82764d289c194
                 CC|                            |[e-mail]

--- Comment #1 from François Gouget  ---
I sent a merge request to fix this. As far as I can see the issue is that
kernelbase does not have FindResourceW() on Windows 8 so the fix is to just
link with kernel32 instead.

https://gitlab.winehq.org/wine/wine/-/merge_requests/3958

[Bug 55652] A FindResourceW() call prevents windows.applicationmodel:model from running on Windows 8

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55652

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|8609fef5c822e32998725bad585 |a7fa496b4bb46e0e2a099ee4f86
                   |82764d289c194               |00840e49bcf2a
                 CC|                            |[e-mail]

--- Comment #2 from François Gouget  ---
The Windows error message was wrong and led me to blame the wrong commit (the
commit date was all wrong!).

The real issue is the PathCchRemoveFileSpec() and this is confirmed by a bisect
that shows this issue started with the commit below:

commit a7fa496b4bb46e0e2a099ee4f8600840e49bcf2a
Author:     Mohamad Al-Jaf 
AuthorDate: Fri Aug 11 01:06:32 2023 -0400
Commit:     Alexandre Julliard 
CommitDate: Mon Sep 25 19:09:23 2023 +0200

windows.applicationmodel/tests: Add IStorageItem::get_Path() tests.

(this time the commit date matches when this issue started)

[Bug 55652] A FindResourceW() call prevents windows.applicationmodel:model from running on Windows 8

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55652

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |94e3e2d115147b80bbe732fa6ad
                   |                            |f887c6b22644a
             Status|NEW                         |RESOLVED

--- Comment #3 from François Gouget  ---
Thanks for the fix!

commit 94e3e2d115147b80bbe732fa6adf887c6b22644a
Author:     Mohamad Al-Jaf 
AuthorDate: Thu Sep 28 20:21:03 2023 -0400

windows.applicationmodel/tests: Use PathRemoveFileSpecW() instead of
PathCchRemoveFileSpec().

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55652

[Bug 55652] A FindResourceW() call prevents windows.applicationmodel:model from running on Windows 8

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55652

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 8.18.