https://bugs.winehq.org/show_bug.cgi?id=47907
Bug ID: 47907 Summary: redefinition of typedef ‘IDebugClient’ Product: Wine Version: 4.14 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: version2013@protonmail.com Distribution: ---
in distro:
# uname --kernel-release 3.0.66
# gcc --version 4.3.4
# ldd --version 2.10.1
Compiling wine-4.14 fails with: error: redefinition of typedef ‘IDebugClient’
https://bugs.winehq.org/show_bug.cgi?id=47907
--- Comment #1 from Nathan version2013@protonmail.com --- Created attachment 65402 --> https://bugs.winehq.org/attachment.cgi?id=65402 log.txt
https://bugs.winehq.org/show_bug.cgi?id=47907
--- Comment #2 from Nathan version2013@protonmail.com --- fails to compile: wine-4.15 wine-4.16 wine-4.17
https://bugs.winehq.org/show_bug.cgi?id=47907
--- Comment #3 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- At a guess, gcc is too old.
https://bugs.winehq.org/show_bug.cgi?id=47907
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4@web.de
https://bugs.winehq.org/show_bug.cgi?id=47907
--- Comment #4 from Nathan version2013@protonmail.com --- my bisect attempt:
# cd /opt # git clone git://source.winehq.org/git/wine.git wine-git/ # cd wine-git/ # git bisect start # git bisect good wine-4.13 # git bisect bad wine-4.14
# CC="gcc -m32" ./configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var --x-includes=/usr/X11R7/include --x-libraries=/usr/X11R7/lib --with-x --libdir=/usr/lib32 CFLAGS="-g -O0 -march=i486 -mtune=i686" --verbose && make # git bisect good
# CC="gcc -m32" ./configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var --x-includes=/usr/X11R7/include --x-libraries=/usr/X11R7/lib --with-x --libdir=/usr/lib32 CFLAGS="-g -O0 -march=i486 -mtune=i686" --verbose && make # git bisect bad
# CC="gcc -m32" ./configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var --x-includes=/usr/X11R7/include --x-libraries=/usr/X11R7/lib --with-x --libdir=/usr/lib32 CFLAGS="-g -O0 -march=i486 -mtune=i686" --verbose && make # git bisect good
# CC="gcc -m32" ./configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var --x-includes=/usr/X11R7/include --x-libraries=/usr/X11R7/lib --with-x --libdir=/usr/lib32 CFLAGS="-g -O0 -march=i486 -mtune=i686" --verbose && make # git bisect bad
# CC="gcc -m32" ./configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var --x-includes=/usr/X11R7/include --x-libraries=/usr/X11R7/lib --with-x --libdir=/usr/lib32 CFLAGS="-g -O0 -march=i486 -mtune=i686" --verbose && make # git bisect bad
# CC="gcc -m32" ./configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var --x-includes=/usr/X11R7/include --x-libraries=/usr/X11R7/lib --with-x --libdir=/usr/lib32 CFLAGS="-g -O0 -march=i486 -mtune=i686" --verbose && make # git bisect good
# CC="gcc -m32" ./configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var --x-includes=/usr/X11R7/include --x-libraries=/usr/X11R7/lib --with-x --libdir=/usr/lib32 CFLAGS="-g -O0 -march=i486 -mtune=i686" --verbose && make # git bisect bad
# CC="gcc -m32" ./configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var --x-includes=/usr/X11R7/include --x-libraries=/usr/X11R7/lib --with-x --libdir=/usr/lib32 CFLAGS="-g -O0 -march=i486 -mtune=i686" --verbose && make # git bisect good 27890cfbaa32f518bdc003f3e6d66d0639c0ef15 is the first bad commit commit 27890cfbaa32f518bdc003f3e6d66d0639c0ef15 Author: Alistair Leslie-Hughes leslie_alistair@hotmail.com Date: Tue Aug 13 00:21:10 2019 +0000
include: Add IDebugClient2-7 interfaces.
Signed-off-by: Alistair Leslie-Hughes leslie_alistair@hotmail.com Signed-off-by: Alexandre Julliard julliard@winehq.org
:040000 040000 8d7566d387db3033c33ef9684355fb14f03505f8 c74165aef3de06571d1c88d1d6e7d22d872444a1 M include #
https://bugs.winehq.org/show_bug.cgi?id=47907
Nathan version2013@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |27890cfbaa32f518bdc003f3e6d | |66d0639c0ef15
https://bugs.winehq.org/show_bug.cgi?id=47907
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |leslie_alistair@hotmail.com
--- Comment #5 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- Created attachment 65479 --> https://bugs.winehq.org/attachment.cgi?id=65479 Possible solution.
Can you please try the attached patch?
https://bugs.winehq.org/show_bug.cgi?id=47907
--- Comment #6 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- (In reply to Alistair Leslie-Hughes from comment #3)
At a guess, gcc is too old.
https://bugs.winehq.org/show_bug.cgi?id=47907
--- Comment #7 from Nathan version2013@protonmail.com --- (In reply to Alistair Leslie-Hughes from comment #5) wine-4.18 and wine-4.18 with patch, both fail to compile.
https://bugs.winehq.org/show_bug.cgi?id=47907
--- Comment #8 from Ken Sharp imwellcushtymelike@gmail.com --- (In reply to Alistair Leslie-Hughes from comment #3)
At a guess, gcc is too old.
Invalid?
https://bugs.winehq.org/show_bug.cgi?id=47907
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish@gmail.com
--- Comment #9 from Austin English austinenglish@gmail.com --- (In reply to Ken Sharp from comment #8)
(In reply to Alistair Leslie-Hughes from comment #3)
At a guess, gcc is too old.
Invalid?
Not in my opinion, we don't require a specific version of gcc (4.4 is required for 64-bit, but this is 32-bit).
If we do require a newer version, configure should enforce that.
https://bugs.winehq.org/show_bug.cgi?id=47907
--- Comment #10 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- At the end of the day. I've tried to use that compiler version and no matter how I adjusted the code, at least one error remained.
Maybe it's time to enforce a compiler version.
https://bugs.winehq.org/show_bug.cgi?id=47907
--- Comment #11 from Nathan version2013@protonmail.com --- wine-5.0-rc5
fails to compile in distro listed in comment #0
in the interest of testing with another compiler version, also fails to compile in distro with # gcc --version 4.2.2
https://bugs.winehq.org/show_bug.cgi?id=47907
Nathan Bennett version2013@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
https://bugs.winehq.org/show_bug.cgi?id=47907
Piotr Caban piotr.caban@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |piotr.caban@gmail.com
--- Comment #12 from Piotr Caban piotr.caban@gmail.com --- Created attachment 67278 --> https://bugs.winehq.org/attachment.cgi?id=67278 possible fix
I guess something like attached patch should fix the compilation. On the other hand I'm not sure if it makes sense taking in account that compilation with this version of gcc will not work in much more places (e.g. dlls/msvcrt/crt_wmain.c, dlls/devenum/mediacatenum.c, dlls/winevulkan/vulkan.c)
https://bugs.winehq.org/show_bug.cgi?id=47907
--- Comment #13 from Nathan Bennett version2013@protonmail.com --- (In reply to Piotr Caban from comment #12) Compiling wine-5.0.1 with patch applied resulted in 'wine build complete'. Thank you.
https://bugs.winehq.org/show_bug.cgi?id=47907
--- Comment #14 from Nathan Bennett version2013@protonmail.com --- (In reply to Piotr Caban from comment #12) compiling wine-6.0-rc4 with patch. bug is gone.
Like you mentioned, next bug that stops compilation is: https://bugs.winehq.org/show_bug.cgi?id=50423 (dlls/devenum/mediacatenum.c)
https://bugs.winehq.org/show_bug.cgi?id=47907
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fgouget@codeweavers.com Keywords| |patch
https://bugs.winehq.org/show_bug.cgi?id=47907
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |51160
https://bugs.winehq.org/show_bug.cgi?id=47907
--- Comment #15 from Fabian Maurer dark.shadow4@web.de --- FWIW, I have all changes necessary to compile with gcc 4.3 and will try to upstream them one after another.