[Bug 4264] the 4th coming refuses to install, complain about incorrect registry permissions

http://bugs.winehq.org/show_bug.cgi?id=4264

Jeremy Drake  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Jeremy Drake  2011-01-06 01:50:53 CST ---
Maybe I can shed some light on what some of this software is doing and why.

(In reply to comment #8)
> Refuses to install, saying I don't have the necessary registry permissions.

What this code is doing, if you are on Win2k or later, is verifying that for
HKEY_LOCAL_MACHINE\SOFTWARE\Classes:

1) you can open the key for KEY_WRITE|READ_CONTROL

2) you can get the security descriptor via GetSecurityInfo(...,
SE_REGISTRY_KEY,
OWNER_SECURITY_INFORMATION|GROUP_SECURITY_INFORMATION|DACL_SECURITY_INFORMATION,
...)

3) the security descriptor contains a non-null DACL

This was to preemptively detect a rare and mysterious issue where the registry
permissions on HKEY_CLASSES_ROOT were screwed up, resulting in any registry
keys we created having the wrong permissions through inheritance.  We decided
sending customers in that condition to our customer support to try to
straighten it out before we created a ton of reg keys during install and
mysteriously broke some time later would be a good idea.  Since our main
product is anti-virus, having to deal with broken windows installs is just par
for the course...

(In reply to comment #8)
> Setting winver to win98 appears to skip this and instead it aborts on
> OleLoadPictureFile being unimplemented, bug 10156.

Yeah.  It should be dead simple to get at least a partial implementation, since
OleLoadPicturePath is already implemented.  Or just return an error HRESULT and
not crash.  We can deal with that (we are just trying to draw our logo in the
installer here, nothing that would be fatal if it failed).

Technically, you don't even *need* the full installer framework to install t4c,
anyway.  Just download the game installer that the main installer would have
downloaded, and run it directly.  Note this is unsupported (ie, may stop
working in the future) and the url is subject to change, but
http://www.eacceleration.com/pub/download/thefourthcoming_install.exe should
get you what you need.

If there's any good techniques I can use (having access to the source) to help
debug any of this, let me know and I'll see if I can't find some spare time to
look at it.