[Bug 26071] New: urlmon/class tests show some valgrind warnings

http://bugs.winehq.org/show_bug.cgi?id=26071

Summary: urlmon/class tests show some valgrind warnings
           Product: Wine
           Version: 1.3.13
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Keywords: download, source, testcase
          Severity: minor
          Priority: P2
         Component: urlmon
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Invalid read of size 1
    at  strlen (mc_replace_strmem.c:282)
    by  lstrlenA (string.c:194)
    by  test_IUri_GetPropertyLength (uri.c:7079)
    by  func_uri (uri.c:9961)
    by  run_test (test.h:556)
    by  main (test.h:624)
  Address 0x0 is not stack'd, malloc'd or (recently) free'd

...

Invalid read of size 1
    at  strlen (mc_replace_strmem.c:282)
    by  lstrlenA (string.c:194)
    by  test_IUriBuilder_GetPath (uri.c:8279)
    by  test_IUriBuilder (uri.c:8838)
    by  func_uri (uri.c:9988)
    by  run_test (test.h:556)
    by  main (test.h:624)
  Address 0x0 is not stack'd, malloc'd or (recently) free'd

...

Invalid read of size 1
    at  strlen (mc_replace_strmem.c:282)
    by  lstrlenA (string.c:194)
    by  test_IUriBuilder_GetPath (uri.c:8279)
    by  test_IUriBuilder (uri.c:8838)
    by  func_uri (uri.c:9988)
    by  run_test (test.h:556)
    by  main (test.h:624)
  Address 0x0 is not stack'd, malloc'd or (recently) free'd

...

Invalid write of size 2
    at  combine_uri (uri.c:6018)
    by  CoInternetCombineIUri (uri.c:6132)
    by  test_CoInternetCombineIUri (uri.c:9359)
    by  func_uri (uri.c:10009)
    by  run_test (test.h:556)
    by  main (test.h:624)
  Address 0x7f01e458 is 256 bytes inside a block of size 312 free'd
    at  notify_free (heap.c:262)
    by  RtlFreeHeap (heap.c:1747)
    by  RtlFreeAnsiString (rtlstr.c:173)
    by  FILE_CreateFile (file.c:182)
    by  NtCreateFile (file.c:271)
    by  CreateFileW (file.c:1386)
    by  PROFILE_Open (profile.c:781)
    by  GetPrivateProfileStringW (profile.c:1128)
    by  GetPrivateProfileStringA (profile.c:1171)
    by  GetProfileStringA (profile.c:1199)
    by  SYSPARAMS_Init (sysparams.c:941)
    by  process_attach (user_main.c:276)
    by  DllMain (user_main.c:332)
    by  __wine_spec_dll_entry (dll_entry.c:40)
    by  ??? (loader.c:139)
    by  MODULE_InitDLL (loader.c:978)
    by  process_attach (loader.c:1067)
    by  process_attach (loader.c:1059)
    by  process_attach (loader.c:1059)
    by  process_attach (loader.c:1059)

...

Invalid read of size 2
    at  parse_path_hierarchical (uri.c:1968)
    by  combine_uri (uri.c:6028)
    by  CoInternetCombineIUri (uri.c:6132)
    by  test_CoInternetCombineIUri (uri.c:9359)
    by  func_uri (uri.c:10009)
    by  run_test (test.h:556)
    by  main (test.h:624)
  Address 0x7f01e458 is 256 bytes inside a block of size 312 free'd
    at  notify_free (heap.c:262)
    by  RtlFreeHeap (heap.c:1747)
    by  RtlFreeAnsiString (rtlstr.c:173)
    by  FILE_CreateFile (file.c:182)
    by  NtCreateFile (file.c:271)
    by  CreateFileW (file.c:1386)
    by  PROFILE_Open (profile.c:781)
    by  GetPrivateProfileStringW (profile.c:1128)
    by  GetPrivateProfileStringA (profile.c:1171)
    by  GetProfileStringA (profile.c:1199)
    by  SYSPARAMS_Init (sysparams.c:941)
    by  process_attach (user_main.c:276)
    by  DllMain (user_main.c:332)
    by  __wine_spec_dll_entry (dll_entry.c:40)
    by  ??? (loader.c:139)
    by  MODULE_InitDLL (loader.c:978)
    by  process_attach (loader.c:1067)
    by  process_attach (loader.c:1059)
    by  process_attach (loader.c:1059)
    by  process_attach (loader.c:1059)

...

Invalid write of size 2
    at  combine_uri (uri.c:6018)
    by  CoInternetCombineUrlEx (uri.c:6191)
    by  test_CoInternetCombineUrlEx (uri.c:9673)
    by  func_uri (uri.c:10012)
    by  run_test (test.h:556)
    by  main (test.h:624)
  Address 0x7f01ebf0 is 14 bytes after a block of size 18 free'd
    at  notify_free (heap.c:262)
    by  RtlFreeHeap (heap.c:1747)
    by  RtlFreeUnicodeString (rtlstr.c:319)
    by  RegQueryValueExA (registry.c:1488)
    by  SYSPARAMS_Init (sysparams.c:934)
    by  process_attach (user_main.c:276)
    by  DllMain (user_main.c:332)
    by  __wine_spec_dll_entry (dll_entry.c:40)
    by  ??? (loader.c:139)
    by  MODULE_InitDLL (loader.c:978)
    by  process_attach (loader.c:1067)
    by  process_attach (loader.c:1059)
    by  process_attach (loader.c:1059)
    by  process_attach (loader.c:1059)
    by  attach_process_dlls (loader.c:2535)
    by  ??? (port.c:60)

...

Invalid read of size 2
    at  parse_path_hierarchical (uri.c:1968)
    by  combine_uri (uri.c:6028)
    by  CoInternetCombineUrlEx (uri.c:6191)
    by  test_CoInternetCombineUrlEx (uri.c:9673)
    by  func_uri (uri.c:10012)
    by  run_test (test.h:556)
    by  main (test.h:624)
  Address 0x7f01ebf0 is 14 bytes after a block of size 18 free'd
    at  notify_free (heap.c:262)
    by  RtlFreeHeap (heap.c:1747)
    by  RtlFreeUnicodeString (rtlstr.c:319)
    by  RegQueryValueExA (registry.c:1488)
    by  SYSPARAMS_Init (sysparams.c:934)
    by  process_attach (user_main.c:276)
    by  DllMain (user_main.c:332)
    by  __wine_spec_dll_entry (dll_entry.c:40)
    by  ??? (loader.c:139)
    by  MODULE_InitDLL (loader.c:978)
    by  process_attach (loader.c:1067)
    by  process_attach (loader.c:1059)
    by  process_attach (loader.c:1059)
    by  process_attach (loader.c:1059)
    by  attach_process_dlls (loader.c:2535)
    by  ??? (port.c:60)

[Bug 26071] urlmon/class tests show some valgrind warnings

http://bugs.winehq.org/show_bug.cgi?id=26071

Thomas Mullaly  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Thomas Mullaly  2011-02-14 19:06:59 CST ---
(In reply to comment #0)
> Invalid read of size 1
>     at  strlen (mc_replace_strmem.c:282)
>     by  lstrlenA (string.c:194)
>     by  test_IUri_GetPropertyLength (uri.c:7079)
>     by  func_uri (uri.c:9961)
>     by  run_test (test.h:556)
>     by  main (test.h:624)
>   Address 0x0 is not stack'd, malloc'd or (recently) free'd
>
> ...
>
> Invalid read of size 1
>     at  strlen (mc_replace_strmem.c:282)
>     by  lstrlenA (string.c:194)
>     by  test_IUriBuilder_GetPath (uri.c:8279)
>     by  test_IUriBuilder (uri.c:8838)
>     by  func_uri (uri.c:9988)
>     by  run_test (test.h:556)
>     by  main (test.h:624)
>   Address 0x0 is not stack'd, malloc'd or (recently) free'd
>
> ...
>
> Invalid read of size 1
>     at  strlen (mc_replace_strmem.c:282)
>     by  lstrlenA (string.c:194)
>     by  test_IUriBuilder_GetPath (uri.c:8279)
>     by  test_IUriBuilder (uri.c:8838)
>     by  func_uri (uri.c:9988)
>     by  run_test (test.h:556)
>     by  main (test.h:624)
>   Address 0x0 is not stack'd, malloc'd or (recently) free'd

I think these are non-issue, just calling lstrlen with NULL as the parameter.
> Invalid write of size 2
>     at  combine_uri (uri.c:6018)
>     by  CoInternetCombineIUri (uri.c:6132)
>     by  test_CoInternetCombineIUri (uri.c:9359)
>     by  func_uri (uri.c:10009)
>     by  run_test (test.h:556)
>     by  main (test.h:624)
>   Address 0x7f01e458 is 256 bytes inside a block of size 312 free'd
>     at  notify_free (heap.c:262)
>     by  RtlFreeHeap (heap.c:1747)
>     by  RtlFreeAnsiString (rtlstr.c:173)
>     by  FILE_CreateFile (file.c:182)
>     by  NtCreateFile (file.c:271)
>     by  CreateFileW (file.c:1386)
>     by  PROFILE_Open (profile.c:781)
>     by  GetPrivateProfileStringW (profile.c:1128)
>     by  GetPrivateProfileStringA (profile.c:1171)
>     by  GetProfileStringA (profile.c:1199)
>     by  SYSPARAMS_Init (sysparams.c:941)
>     by  process_attach (user_main.c:276)
>     by  DllMain (user_main.c:332)
>     by  __wine_spec_dll_entry (dll_entry.c:40)
>     by  ??? (loader.c:139)
>     by  MODULE_InitDLL (loader.c:978)
>     by  process_attach (loader.c:1067)
>     by  process_attach (loader.c:1059)
>     by  process_attach (loader.c:1059)
>     by  process_attach (loader.c:1059)
>
> ...
>
> Invalid read of size 2
>     at  parse_path_hierarchical (uri.c:1968)
>     by  combine_uri (uri.c:6028)
>     by  CoInternetCombineIUri (uri.c:6132)
>     by  test_CoInternetCombineIUri (uri.c:9359)
>     by  func_uri (uri.c:10009)
>     by  run_test (test.h:556)
>     by  main (test.h:624)
>   Address 0x7f01e458 is 256 bytes inside a block of size 312 free'd
>     at  notify_free (heap.c:262)
>     by  RtlFreeHeap (heap.c:1747)
>     by  RtlFreeAnsiString (rtlstr.c:173)
>     by  FILE_CreateFile (file.c:182)
>     by  NtCreateFile (file.c:271)
>     by  CreateFileW (file.c:1386)
>     by  PROFILE_Open (profile.c:781)
>     by  GetPrivateProfileStringW (profile.c:1128)
>     by  GetPrivateProfileStringA (profile.c:1171)
>     by  GetProfileStringA (profile.c:1199)
>     by  SYSPARAMS_Init (sysparams.c:941)
>     by  process_attach (user_main.c:276)
>     by  DllMain (user_main.c:332)
>     by  __wine_spec_dll_entry (dll_entry.c:40)
>     by  ??? (loader.c:139)
>     by  MODULE_InitDLL (loader.c:978)
>     by  process_attach (loader.c:1067)
>     by  process_attach (loader.c:1059)
>     by  process_attach (loader.c:1059)
>     by  process_attach (loader.c:1059)

I think these two are related, I've sent a patch which should fix them both.

Thanks for the valgrind reports!

[Bug 26071] urlmon/class tests show some valgrind warnings

http://bugs.winehq.org/show_bug.cgi?id=26071

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Austin English  2011-02-15 16:07:16 CST ---
Fixed by:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=1703368e26d852b8bdc8b1...

I've suppressed the others.

Thanks!

[Bug 26071] urlmon/uri tests show some valgrind warnings

http://bugs.winehq.org/show_bug.cgi?id=26071

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|urlmon/class tests show     |urlmon/uri tests show some
                   |some valgrind warnings      |valgrind warnings

[Bug 26071] urlmon/uri tests show some valgrind warnings

http://bugs.winehq.org/show_bug.cgi?id=26071

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  2011-02-18 12:37:12 CST ---
Closing bugs fixed in 1.3.14.