https://bugs.winehq.org/show_bug.cgi?id=55568
Bug ID: 55568 Summary: kernel32:file - test_GetFileType() fails on 'nul' device on macOS Product: Wine Version: unspecified Hardware: x86-64 OS: Mac OS X Status: NEW Severity: normal Priority: P2 Component: kernel32 Assignee: wine-bugs@winehq.org Reporter: fgouget@codeweavers.com
kernel32:file - test_GetFileType() fails on 'nul' device on macOS:
file.c:3160: Test failed: expected type char for nul got 1
This failure is systematic and only happens on macOS (see Remi's rbernon-macos-* cloud test machines).
See https://test.winehq.org/data/patterns.html#kernel32:file
Where 1 == FILE_TYPE_DISK 2 == FILE_TYPE_CHAR
So GetFileType() fails to distinguish the nul device from a regular disk device on macOS.
https://bugs.winehq.org/show_bug.cgi?id=55568
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |source, testcase
https://bugs.winehq.org/show_bug.cgi?id=55568
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |julliard@winehq.org
--- Comment #1 from François Gouget fgouget@codeweavers.com --- There are 3 additional failures since 2023-09-26:
file.c:3148: Test failed: open C:\users\runner\Temp\tmpe466.tmp failed file.c:3150: Test failed: expected type disk got 0 file.c:3155: Test failed: expected type char for nul got 1 file.c:3180: Test failed: open C:\users\runner\Temp\tmpe466.tmp failed
https://bugs.winehq.org/show_bug.cgi?id=55568
John Szakmeister john@szakmeister.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |john@szakmeister.net
--- Comment #2 from John Szakmeister john@szakmeister.net --- Looking into this, macOS doesn't have a great way of identifying "/dev/null" like Linux and FreeBSD. However, there is one possibility. Would a patch that checked the major and minor device number for 3 and 2, respectively, be okay? It turns out that "/dev/null" has been (3, 2) since the beginning:
The latest in XNU: https://github.com/apple-oss-distributions/xnu/blob/8d741a5de7ff4191bf97d57b...
It looks like it's been that way since the beginning: https://github.com/apple-oss-distributions/xnu/blob/186b8fcebe07315fd53fa84c...
-
WineHQ Bugzilla