[Bug 30603] New: GTA2 crashes on starup

http://bugs.winehq.org/show_bug.cgi?id=30603

Bug #: 30603
           Summary: GTA2 crashes on starup
           Product: Wine
           Version: 1.3.25
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 40044
  --> http://bugs.winehq.org/attachment.cgi?id=40044
Crash from wine-1.5.3-164-gdec3d50

When i try to run GTA2, my screen resolution changes to some lower value
(probably game's native) and GTA2 crashes. If i stay in this lower resolution
and run the game again it runs fine (except bug 30602).

1. I did a regression test between 1.3.24 and 1.3.25:

84413298de371a9e9b9ecfe0dd01f580b7521222 is the first bad commit
commit 84413298de371a9e9b9ecfe0dd01f580b7521222
Author: Henri Verbeet 
Date:   Thu Jul 21 19:16:00 2011 +0200

ddraw: Resize the window after setting the new display mode.

:040000 040000 a2ac1cd6ae0a19178d9aa4610a08b876a9ec5b85
2e07d4f4f939b5673c5b20aca0d6dff24822d95b M      dlls

2. No other bug report suffers from this commit.

3. Revert of this patch after git checkout makes that problem go away. (Can't
be cleanly reverted on top of wine-1.5.3-164-gdec3d50)

The game is freely download-able from it's vendor at
http://www.rockstargames.com/classics/?id=3

[Bug 30603] GTA2 crashes on starup

http://bugs.winehq.org/show_bug.cgi?id=30603

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression
                URL|                            |http://www.rockstargames.co
                   |                            |m/classics/?id=3
                 CC|                            |[e-mail]
    Regression SHA1|                            |84413298de371a9e9b9ecfe0dd0
                   |                            |1f580b7521222

--- Comment #1 from Wylda  2012-05-05 09:46:32 CDT ---

Filling some fields...

[Bug 30603] GTA2 crashes on starup

http://bugs.winehq.org/show_bug.cgi?id=30603

--- Comment #2 from Wylda  2012-06-23 16:00:46 CDT ---
Created attachment 40667
  --> http://bugs.winehq.org/attachment.cgi?id=40667
"patch" for wine-1.5.7

This is a partial revert-patch, which makes the game start again under
wine-1.5.7 and allows me to test bug 30602.

[Bug 30603] GTA2 crashes on starup

http://bugs.winehq.org/show_bug.cgi?id=30603

--- Comment #3 from Wylda  2012-06-23 16:09:17 CDT ---

Ops, i forgot what i wrote in comment #0 - staying in lower resolution avoids
startup crash, so no need to mess with the hack in previous comment...

[Bug 30603] GTA2 crashes on starup

http://bugs.winehq.org/show_bug.cgi?id=30603

--- Comment #4 from Wylda  2012-07-15 04:27:35 CDT ---

Still present in wine-1.5.8-160-g8613d5e.

[Bug 30603] GTA2 crashes on starup

http://bugs.winehq.org/show_bug.cgi?id=30603

--- Comment #5 from Henri Verbeet  2012-08-31 07:45:37 CDT ---
Created attachment 41537
  --> http://bugs.winehq.org/attachment.cgi?id=41537
hack

You're using KWin 4.4, right? I think this may be some variant of bug 23745,
does the attach patch help?

[Bug 30603] GTA2 crashes on starup

http://bugs.winehq.org/show_bug.cgi?id=30603

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 30603] GTA2 crashes on starup

http://bugs.winehq.org/show_bug.cgi?id=30603

--- Comment #6 from Wylda  2012-09-24 16:49:48 CDT ---
> You're using KWin 4.4, right?

Hi Henri, yes i use:
 * debian squeeze
 * KDE v4.4.5 (hopefully it implicates KWin 4.4)
 * 32bit
 * nVidia GT240 v275.09.07

But currently linux is on hold waiting for wheezy & GTX660Ti.
> I think this may be some variant of bug 23745,

Hmmm, but per http://bugs.winehq.org/show_bug.cgi?id=23745#c8 i'm was not
affected in that case.
> does the attach patch help?

Yes! The patch/hack fully fixes the problem under KDE v4.4.5. Thank you Henri!

[Bug 30603] GTA2 crashes on starup

http://bugs.winehq.org/show_bug.cgi?id=30603

--- Comment #7 from Henri Verbeet  2012-09-28 12:03:30 CDT ---
Should be fixed by commit 47c54c4ae7f235780a55ddf670503db4afc11055.

[Bug 30603] GTA2 crashes on starup

http://bugs.winehq.org/show_bug.cgi?id=30603

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |47c54c4ae7f235780a55ddf6705
                   |                            |03db4afc11055
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Henri Verbeet  2012-10-05 07:36:17 CDT ---
Resolving FIXED.

[Bug 30603] GTA2 crashes on starup

http://bugs.winehq.org/show_bug.cgi?id=30603

--- Comment #9 from Wylda  2012-10-11 15:17:01 CDT ---

I did the re-test under wine-1.5.14-307-g1f876a6 and game starts perfectly
again. Many thanks for your work Henri and sorry for such late replay.

[Bug 30603] GTA2 crashes on starup

http://bugs.winehq.org/show_bug.cgi?id=30603

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Alexandre Julliard  2012-10-12 13:34:10 CDT ---
Closing bugs fixed in 1.5.15.