[Bug 34984] New: Original War: intense screen flickering

http://bugs.winehq.org/show_bug.cgi?id=34984

Bug #: 34984
           Summary: Original War: intense screen flickering
           Product: Wine
           Version: 1.7.7
          Platform: x86
               URL: http://www.fileplanet.com/51478/50000/fileinfo/Origina
                    l-War-Demo
        OS/Version: Linux
            Status: NEW
          Keywords: download, regression
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]
    Classification: Unclassified
   Regression SHA1: 9443c95a895a530fdbbb607758f674467e2010c7

The screen is flickering constantly when you start the game. This makes the
game hardly playable.
A regression from Wine 1.7.7:

9443c95a895a530fdbbb607758f674467e2010c7 is the first bad commit
commit 9443c95a895a530fdbbb607758f674467e2010c7
Author: Henri Verbeet 
Date:   Fri Nov 15 08:24:30 2013 +0100

ddraw: Move the display mode related surface desc fixups from
CreateSurface() to ddraw_surface_create_texture().

:040000 040000 06ba732f8090c74706196fd0acedd3d74fda2692
9c3ef07665bd8ffc383d5282cb84a2f535e7ace2 M    dlls

Reverting the commit fixes the problem. Terminal output doesn't contain useful
information. The same commit causes a similar problem in Populous: The
Beginning. Beside the flickering, PoP:TB crashes when I start a new game.
Reverting the commit fixes the crash in Pop:TB.

Fedora 19
Nvidia binary drivers 325.15
X.Org X Server 1.14.4

[Bug 34984] Original War: intense screen flickering

http://bugs.winehq.org/show_bug.cgi?id=34984

--- Comment #1 from Henri Verbeet  2013-11-24 05:07:31 CST ---
Created attachment 46624
  --> http://bugs.winehq.org/attachment.cgi?id=46624
patch

I think the attached patch should help.

[Bug 34984] Original War: intense screen flickering

http://bugs.winehq.org/show_bug.cgi?id=34984

--- Comment #2 from GyB  2013-11-25 11:15:38 CST ---
(In reply to comment #1)
> Created attachment 46624 [details]
> patch
>
> I think the attached patch should help.

The patch fixes the issues in both games, thanks.

[Bug 34984] Original War: intense screen flickering

http://bugs.winehq.org/show_bug.cgi?id=34984

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |8ce73e2ad67746fc28bc760c6fa
                   |                            |4f926fb0c0386
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from GyB  2013-11-25 14:53:23 CST ---
Fixed in wine-1.7.7-42-g15b35f4.

[Bug 34984] Original War: intense screen flickering

http://bugs.winehq.org/show_bug.cgi?id=34984

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  2013-12-06 13:44:45 CST ---
Closing bugs fixed in 1.7.8.