http://bugs.winehq.org/show_bug.cgi?id=24226
Summary: Broken Sword II gives fatal error on startup Product: Wine Version: unspecified Platform: x86 URL: http://appdb.winehq.org/objectManager.php?sClass=versi on&iId=14055 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: directx-ddraw AssignedTo: wine-bugs@winehq.org ReportedBy: octavian.voicu@gmail.com CC: stefan@codeweavers.com
Created an attachment (id=30500) --> (http://bugs.winehq.org/attachment.cgi?id=30500) trace (search for xxx inside file for some comments)
With latest wine compiled from git, Broken Sword II (aka The Smoking Mirror) fails to start, throwing this error: "Fatal error in L:\Sword2\sword2.cpp, line 238! Code 0x00010004"
The game works perfectly with wine-1.0. After a long and painful regression test, I found this:
a47e7badb9484b123be413cdd353ced601b10d99 is the first bad commit commit a47e7badb9484b123be413cdd353ced601b10d99 Author: Stefan Dösinger stefan@codeweavers.com Date: Tue Jul 29 11:03:59 2008 -0500
ddraw: Set ddraw caps in wined3d.
Currently the ddraw capabilities were almost static, except of D3D support. When overlay support is added, the caps depend on certain settings in WineD3D or capabilities available from OpenGL and Xv. So set those caps in wined3d as well.
:040000 040000 ec6e179a447958505e6683385c644b6667dd0fd9 8d1f5599bfcf2db3c3277e172760ecec81a05017 M dlls :040000 040000 9ffd5c4286bdf342dd4714b0cbbf8a3445704426 a24a60b2404c3c80d5be93c3c71053d118e8750b M include
http://bugs.winehq.org/show_bug.cgi?id=24226
--- Comment #1 from Octavian Voicu octavian.voicu@gmail.com 2010-08-31 21:54:53 CDT --- Created an attachment (id=30501) --> (http://bugs.winehq.org/attachment.cgi?id=30501) trace with an older wine version
http://bugs.winehq.org/show_bug.cgi?id=24226
Octavian Voicu octavian.voicu@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
http://bugs.winehq.org/show_bug.cgi?id=24226
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |1.1.2
--- Comment #2 from Dmitry Timoshkov dmitry@codeweavers.com 2010-08-31 23:34:02 CDT --- The point of regression is wine-1.1.2
http://bugs.winehq.org/show_bug.cgi?id=24226
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|1.1.2 |1.1.3
--- Comment #3 from Dmitry Timoshkov dmitry@codeweavers.com 2010-09-01 00:04:46 CDT --- It's rather 1.1.3, 1.1.2 is the release before the regression.
http://bugs.winehq.org/show_bug.cgi?id=24226
--- Comment #4 from Octavian Voicu octavian.voicu@gmail.com 2010-09-01 07:27:10 CDT --- As instructed by Stefan, here is the diff between output of dxcapsviewer before and after offending commit.
Caps Palette Caps - 8BIT Yes - PRIMARYSURFACE Yes BLT Caps Video - Video Color Key - DESTBLT Yes - SRCBLT Yes FX - BLTALPHA Yes - BLTMIRRORLEFTRIGHT Yes - BLTMIRRORUPDOWN Yes - BLTROTATION90 Yes - BLTSHRINKX Yes - BLTSHRINKXN Yes - BLTSHRINKY Yes - BLTSTRETCHX Yes - BLTSTRETCHXN Yes - BLTSTRETCHY Yes - BLTSTRETCHYN Yes
These differences show for the following devices: DirectDraw HAL (display) Hardware Emulation Layer
PS: didn't fill in version because I wasn't sure what to put there; 1.1.3 seems logical, thanks Dmitry.
http://bugs.winehq.org/show_bug.cgi?id=24226
--- Comment #5 from Octavian Voicu octavian.voicu@gmail.com 2010-09-01 08:50:51 CDT --- Sent a patch to add the caps that were forgotten by the offending commit: http://source.winehq.org/patches/data/65654
With this patch, game works again.
http://bugs.winehq.org/show_bug.cgi?id=24226
--- Comment #6 from Henri Verbeet hverbeet@gmail.com 2010-09-01 12:33:39 CDT --- Fixed by f9cdd5097fc5bb2cbfcc4e0c9ce2b39496b48f44, I assume.
http://bugs.winehq.org/show_bug.cgi?id=24226
--- Comment #7 from Octavian Voicu octavian.voicu@gmail.com 2010-09-01 13:06:01 CDT --- (In reply to comment #6)
Fixed by f9cdd5097fc5bb2cbfcc4e0c9ce2b39496b48f44, I assume.
Correct.
PS: thanks Stefan for the tip on using dxcapsviewer.
http://bugs.winehq.org/show_bug.cgi?id=24226
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |wylda@volny.cz Resolution| |FIXED
--- Comment #8 from Wylda wylda@volny.cz 2010-09-01 15:11:18 CDT ---
Reported fixed.
http://bugs.winehq.org/show_bug.cgi?id=24226
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #9 from Alexandre Julliard julliard@winehq.org 2010-09-03 14:05:04 CDT --- Closing bugs fixed in 1.3.2.
http://bugs.winehq.org/show_bug.cgi?id=24226
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |1.2.x
http://bugs.winehq.org/show_bug.cgi?id=24226
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.2.x |---
--- Comment #10 from Alexandre Julliard julliard@winehq.org 2010-10-08 10:40:42 CDT --- Removing 1.2.x milestone from bugs fixed in 1.2.1.
http://bugs.winehq.org/show_bug.cgi?id=24226
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|directx-ddraw |directx-d3d
-
wine-bugs＠winehq.org