[Bug 17190] New: [PATCH] detect Chromium OpenGL

http://bugs.winehq.org/show_bug.cgi?id=17190

Summary: [PATCH] detect Chromium OpenGL
           Product: Wine
           Version: unspecified
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

This patch adds support for detection of Chromium
(http://chromium.sourceforge.net/), the OpenGL stub implementation.

It's been tested with Chromium 1.9 as used in VirtualBox 2.1, on native
Windows, and with this patch it correctly identifies the OpenGL vendor and
version number.

[Bug 17190] [PATCH] detect Chromium OpenGL

http://bugs.winehq.org/show_bug.cgi?id=17190

--- Comment #1 from Robert Millan   2009-01-29 20:12:37 ---
Created an attachment (id=19086)
 --> (http://bugs.winehq.org/attachment.cgi?id=19086)
patch

[Bug 17190] [PATCH] detect Chromium OpenGL

http://bugs.winehq.org/show_bug.cgi?id=17190

Robert Millan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 17190] [PATCH] detect Chromium OpenGL

http://bugs.winehq.org/show_bug.cgi?id=17190

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Stefan Dösinger   2009-01-30 04:58:04 ---
Hi,
Feel free to send the patch to wine-patches, however, there's a warning:

In case you are trying to use WineD3D in Virtualbox for D3D support, I highly
recommend improving Chromium GL instead to give the physical Vendor
information. There are a number of apps that depend on correct PCI ID info to
run properly(Command and Conquer Generals is one of them I think). This is the
reason why we have all this messy opengl detection code in the first place.

[Bug 17190] [PATCH] detect Chromium OpenGL

http://bugs.winehq.org/show_bug.cgi?id=17190

--- Comment #3 from Robert Millan   2009-01-30 08:21:31 ---
(In reply to comment #2)
> Hi,
> Feel free to send the patch to wine-patches, however, there's a warning:
>
> In case you are trying to use WineD3D in Virtualbox for D3D support, I highly
> recommend improving Chromium GL instead to give the physical Vendor
> information. There are a number of apps that depend on correct PCI ID info to
> run properly(Command and Conquer Generals is one of them I think). This is the
> reason why we have all this messy opengl detection code in the first place.

Hi Stefan,

Ok then.  But we still haven't figured out how to detect the amount of video
memory.  Is it possible that it ends up being a Chromium-specific call.  Would
be need to detect Chromium in that case, or just check for the corresponding
extension?

[Bug 17190] [PATCH] detect Chromium OpenGL

http://bugs.winehq.org/show_bug.cgi?id=17190

--- Comment #4 from H. Verbeet   2009-01-30 09:01:58 ---
(In reply to comment #3)
> Ok then.  But we still haven't figured out how to detect the amount of video
> memory.  Is it possible that it ends up being a Chromium-specific call.  Would
> be need to detect Chromium in that case, or just check for the corresponding
> extension?

Well, you can't reliably detect the amount of video memory throuh OpenGL, but
if Chromium were to just pass through the information from the host GL
implementation, it would pass through the regular detection code, which would
at least make it not more broken than directly using the same card on the host
OS.

[Bug 17190] [PATCH] detect Chromium OpenGL

http://bugs.winehq.org/show_bug.cgi?id=17190

Robert Millan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID

--- Comment #5 from Robert Millan   2009-02-02 12:32:18 ---
Not really a bug as explained by Stefan.  Chromium should be adapted instead to
permit pass-through for GL_VENDOR et al.

[Bug 17190] [PATCH] detect Chromium OpenGL

http://bugs.winehq.org/show_bug.cgi?id=17190

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Austin English   2009-02-02 19:09:54 ---
Closing.