[Bug 29257] New: Regression: BYOND client will not run (either with native or builtin msvcrt.dll)
http://bugs.winehq.org/show_bug.cgi?id=29257
Bug #: 29257 Summary: Regression: BYOND client will not run (either with native or builtin msvcrt.dll) Product: Wine Version: 1.3.23 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: msvcrt AssignedTo: wine-bugs@winehq.org ReportedBy: alex.hayton@gmail.com Classification: Unclassified
Created attachment 37841 --> http://bugs.winehq.org/attachment.cgi?id=37841 Stack trace showing the error in question.
I have found a regression that was introduced with 1.3.33. When launching the BYOND client (using the native msvcrt.dll) I get an unhandled exception, which seems to be caused by a call to the undeclared function _getlocaltime64.
When I switch to using the builtin msvcrt.dll I do get slightly further, but the client itself won't get past the server browser and into a game, instead just going into an infinite loop. I'll try and get a stack trace from one of
The error seems to be related to the recent switch to the new version of Gecko introduced in 1.3.33 (BYOND makes heavy use of internal browser windows) as mozsqlite3 is the last place we get to before the error occurs.
The client works pretty well in 1.3.32 (I have since started using PlayOnLinux to launch it using that version). The regression was first introduced in 1.3.33.
I am using Ubuntu 11.04 natty and the Wine PPA - I reinstalled mfc42, vcrun6, wsh56 and gecko via winetricks just to be sure that wasn't the cause of the problem.
http://bugs.winehq.org/show_bug.cgi?id=29257
Dmitry Timoshkov dmitry@baikal.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Component|msvcrt |-unknown Summary|Regression: BYOND client |BYOND client will not run |will not run (either with | |native or builtin | |msvcrt.dll) | Severity|normal |minor
--- Comment #1 from Dmitry Timoshkov dmitry@baikal.ru 2011-12-06 20:59:55 CST --- Please post the results of your regression testing: http://wiki.winehq.org/RegressionTesting
http://bugs.winehq.org/show_bug.cgi?id=29257
--- Comment #2 from Alex Hayton alex.hayton@gmail.com 2011-12-06 21:08:06 CST --- Will give it a go tonight and try to find the specific commit that caused it. Thanks for picking up the issue so quickly!
http://bugs.winehq.org/show_bug.cgi?id=29257
Alex Hayton alex.hayton@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.hayton@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=29257
--- Comment #3 from Alex Hayton alex.hayton@gmail.com 2011-12-08 14:41:52 CST --- Still trying to pin down the exact commit that caused the regression. I got as far as building and testing with the latest wine git version, then compiling the first bisect test for 1.3.32-1.3.33.
It appears that BYOND itself is a bit better in the latest wine git now (using the builtin msvcrt.dll) and the freezing bug upon connecting to servers is fixed, but you can't enable hardware acceleration for the main map display or you just get a white screen. This effectively makes the game unplayable on my system due to performance issues with software rendering.
When running the latest wine git and the native msvcrt.dll, I still get the _localtime64 crash when launching the client, with the same stack trace as previously uploaded.
I will continue investigating and report back when I know the exact commit that caused the issue.
http://bugs.winehq.org/show_bug.cgi?id=29257
Alex Hayton alex.hayton@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|1.3.23 |1.3.33
http://bugs.winehq.org/show_bug.cgi?id=29257
--- Comment #4 from Alex Hayton alex.hayton@gmail.com 2011-12-10 18:09:42 CST --- I have completed the regression test.
Here is the commit that broke it. It looks like it was introduced with the latest gecko upgrade in 1.3.33.
2e5f73e4d75cc510d761fb2bd3adf58c8ca72a8a is the first bad commit commit 2e5f73e4d75cc510d761fb2bd3adf58c8ca72a8a Author: Jacek Caban jacek@codeweavers.com Date: Wed Nov 9 18:11:42 2011 +0100
mshtml: Wine Gecko 1.4 release.
:040000 040000 f44485645eb1f33fbec1b55c2df43a46e2085639 b0a5447fc96f72a289c429ed5da025d4377d0ceb M dlls
Now that I have the source on my machine I'll try and run it with the debugger and hopefully get somewhere with isolating the issue. I am thinking that this must be affecting other apps that are using the native msvcrt.dll?
So now we can go one of two ways, either fix the hardware acceleration issue that affects the builtin msvcrt or fix the crash that's preventing use of the native one...
http://bugs.winehq.org/show_bug.cgi?id=29257
Alex Hayton alex.hayton@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |2e5f73e4d75cc510d761fb2bd3a | |df58c8ca72a8a
http://bugs.winehq.org/show_bug.cgi?id=29257
Alex Hayton alex.hayton@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |mshtml
http://bugs.winehq.org/show_bug.cgi?id=29257
Jacek Caban jacek@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |jacek@codeweavers.com Resolution| |INVALID
--- Comment #5 from Jacek Caban jacek@codeweavers.com 2011-12-18 05:19:45 CST --- (In reply to comment #4)
I am thinking that this must be affecting other apps that are using the native msvcrt.dll?
Yes, that's why it's not a supported configuration.
So now we can go one of two ways, either fix the hardware acceleration issue that affects the builtin msvcrt
That's the right fix, please file a separated bug.
or fix the crash that's preventing use of the native one...
No, there is nothing to fix. Gecko simply uses a function that is not present in native msvcrt.dll you use.
Resolving INVALID.
http://bugs.winehq.org/show_bug.cgi?id=29257
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #6 from Austin English austinenglish@gmail.com 2012-01-23 18:59:45 CST --- Closing INVALID.
-
wine-bugs＠winehq.org